Re: [PR] IGNITE-25359 BinaryStreams moved to ignite-binary-impl [ignite]
nizhikov merged PR #12188: URL: https://github.com/apache/ignite/pull/12188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-25359 BinaryStreams moved to ignite-binary-impl [ignite]
sonarqubecloud[bot] commented on PR #12188: URL: https://github.com/apache/ignite/pull/12188#issuecomment-3079287004 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12188) **Quality Gate failed** Failed conditions  [19 New Code Smells](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12188) (required ≤ 1) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12188) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-25359 BinaryStreams moved to ignite-binary-impl [ignite]
ac1d0globlya commented on PR #12188: URL: https://github.com/apache/ignite/pull/12188#issuecomment-3079262392 @sergey-chugunov-1985 README.txt for both ignite-binary-api, ignite-binary-impl added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-25359 BinaryStreams moved to ignite-binary-impl [ignite]
ac1d0globlya commented on code in PR #12188:
URL: https://github.com/apache/ignite/pull/12188#discussion_r2210824292
##
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreams.java:
##
@@ -18,11 +18,25 @@
package org.apache.ignite.internal.binary.streams;
import java.nio.ByteBuffer;
+import java.util.Iterator;
+import org.apache.ignite.internal.util.CommonUtils;
+import org.apache.ignite.internal.util.typedef.internal.A;
/**
* Utility class to provide static methods to create {@link BinaryInputStream}
or {@link BinaryOutputStream} in different modes.
*/
public class BinaryStreams {
+/** Streams factory implementation. */
+private static final BinaryStreamsFactory factory;
+
+static {
+Iterator factories =
CommonUtils.loadService(BinaryStreamsFactory.class).iterator();
+
+A.ensure(factories.hasNext(), "BinaryStreamsFactory implementation not
found. Please, add ignite-binary-impl to classpath");
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-25359 BinaryStreams moved to ignite-binary-impl [ignite]
ac1d0globlya commented on code in PR #12188:
URL: https://github.com/apache/ignite/pull/12188#discussion_r2210822035
##
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreamsFactory.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.binary.streams;
+
+import java.nio.ByteBuffer;
+
+/**
+ * Utility class to provide static methods to create {@link BinaryInputStream}
or {@link BinaryOutputStream} in different modes.
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-25359 BinaryStreams moved to ignite-binary-impl [ignite]
sergey-chugunov-1985 commented on PR #12188: URL: https://github.com/apache/ignite/pull/12188#issuecomment-3078390350 I suggest to add a README.txt/README.md file to ignite-binary-impl module with a short description of what this module is about and how it is supposed to use it. Module's name is very general and doesn't provide a lot of information though the module is rather important for developers in the community. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-25359 BinaryStreams moved to ignite-binary-impl [ignite]
sergey-chugunov-1985 commented on code in PR #12188:
URL: https://github.com/apache/ignite/pull/12188#discussion_r2209960746
##
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreams.java:
##
@@ -18,11 +18,25 @@
package org.apache.ignite.internal.binary.streams;
import java.nio.ByteBuffer;
+import java.util.Iterator;
+import org.apache.ignite.internal.util.CommonUtils;
+import org.apache.ignite.internal.util.typedef.internal.A;
/**
* Utility class to provide static methods to create {@link BinaryInputStream}
or {@link BinaryOutputStream} in different modes.
*/
public class BinaryStreams {
+/** Streams factory implementation. */
+private static final BinaryStreamsFactory factory;
+
+static {
+Iterator factories =
CommonUtils.loadService(BinaryStreamsFactory.class).iterator();
+
+A.ensure(factories.hasNext(), "BinaryStreamsFactory implementation not
found. Please, add ignite-binary-impl to classpath");
Review Comment:
I suggest to be more specific in this error message and give a hint that we
tried and failed to load a service from classpath.
How about `Implementation for BinaryStreamsFactory service not found. Please
add ignite-binary-impl to classpath`.
##
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/streams/BinaryStreamsFactory.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.binary.streams;
+
+import java.nio.ByteBuffer;
+
+/**
+ * Utility class to provide static methods to create {@link BinaryInputStream}
or {@link BinaryOutputStream} in different modes.
Review Comment:
Javadoc is incorrect, it is not a utility class with a bunch of static
methods but an interface suitable for loading via ServiceLoader mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-25359 BinaryStreams moved to ignite-binary-impl [ignite]
sonarqubecloud[bot] commented on PR #12188: URL: https://github.com/apache/ignite/pull/12188#issuecomment-3072635603 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12188) **Quality Gate failed** Failed conditions  [19 New Code Smells](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12188) (required ≤ 1) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12188) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-25359 BinaryStreams moved to ignite-binary-impl [ignite]
sonarqubecloud[bot] commented on PR #12188: URL: https://github.com/apache/ignite/pull/12188#issuecomment-3072404901 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12188) **Quality Gate failed** Failed conditions  [19 New Code Smells](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12188) (required ≤ 1) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12188) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] IGNITE-25359 BinaryStreams moved to ignite-binary-impl [ignite]
nizhikov opened a new pull request, #12188: URL: https://github.com/apache/ignite/pull/12188 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### The Contribution Checklist - [ ] There is a single JIRA ticket related to the pull request. - [ ] The web-link to the pull request is attached to the JIRA ticket. - [ ] The JIRA ticket has the _Patch Available_ state. - [ ] The pull request body describes changes that have been made. The description explains _WHAT_ and _WHY_ was made instead of _HOW_. - [ ] The pull request title is treated as the final commit message. The following pattern must be used: `IGNITE- Change summary` where `` - number of JIRA issue. - [ ] A reviewer has been mentioned through the JIRA comments (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) - [ ] The pull request has been checked by the Teamcity Bot and the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html)) ### Notes - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute) - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules) - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot) If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com _#ignite_ channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
