Re: [PR] IGNITE-25921 Fix treating RO txn as applicable for direct mapping [ignite-3]
ascherbakoff commented on code in PR #6272:
URL: https://github.com/apache/ignite-3/pull/6272#discussion_r2215904427
##
modules/client/src/main/java/org/apache/ignite/internal/client/tx/DirectTxUtils.java:
##
@@ -256,7 +256,7 @@ public static CompletableFuture
resolveChannel(
String opNode = pm == null ? null : pm.nodeConsistentId();
if (tx != null) {
-return tx.hasCommitPartition() && opNode != null ? opNode :
tx.nodeName();
+return !tx.isReadOnly() && tx.hasCommitPartition() && opNode !=
null ? opNode : tx.nodeName();
Review Comment:
It wasn't imlemented yet. I've created a ticket:
https://issues.apache.org/jira/browse/IGNITE-25956
##
modules/client/src/main/java/org/apache/ignite/internal/client/tx/DirectTxUtils.java:
##
@@ -256,7 +256,7 @@ public static CompletableFuture
resolveChannel(
String opNode = pm == null ? null : pm.nodeConsistentId();
if (tx != null) {
-return tx.hasCommitPartition() && opNode != null ? opNode :
tx.nodeName();
+return !tx.isReadOnly() && tx.hasCommitPartition() && opNode !=
null ? opNode : tx.nodeName();
Review Comment:
It wasn't implemented yet. I've created a ticket:
https://issues.apache.org/jira/browse/IGNITE-25956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-25921 Fix treating RO txn as applicable for direct mapping [ignite-3]
korlov42 commented on code in PR #6272:
URL: https://github.com/apache/ignite-3/pull/6272#discussion_r2215869562
##
modules/client/src/main/java/org/apache/ignite/internal/client/tx/DirectTxUtils.java:
##
@@ -256,7 +256,7 @@ public static CompletableFuture
resolveChannel(
String opNode = pm == null ? null : pm.nodeConsistentId();
if (tx != null) {
-return tx.hasCommitPartition() && opNode != null ? opNode :
tx.nodeName();
+return !tx.isReadOnly() && tx.hasCommitPartition() && opNode !=
null ? opNode : tx.nodeName();
Review Comment:
if my understanding correct, this will disable direct mapping for RO
transactions. Won't better to support direct mapping for RO transactions as
well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-25921 Fix treating RO txn as applicable for direct mapping [ignite-3]
ascherbakoff closed pull request #6272: IGNITE-25921 Fix treating RO txn as applicable for direct mapping URL: https://github.com/apache/ignite-3/pull/6272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-25921 Fix treating RO txn as applicable for direct mapping [ignite-3]
ptupitsyn commented on code in PR #6272:
URL: https://github.com/apache/ignite-3/pull/6272#discussion_r2215821310
##
modules/client/src/main/java/org/apache/ignite/internal/client/tx/DirectTxUtils.java:
##
@@ -256,7 +256,7 @@ public static CompletableFuture
resolveChannel(
String opNode = pm == null ? null : pm.nodeConsistentId();
if (tx != null) {
-return tx.hasCommitPartition() && opNode != null ? opNode :
tx.nodeName();
+return !tx.isReadOnly() && tx.hasCommitPartition() && opNode !=
null ? opNode : tx.nodeName();
Review Comment:
```suggestion
return !tx.isReadOnly() && tx.hasCommitPartition() && opNode !=
null
? opNode
: tx.nodeName();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] IGNITE-25921 Fix treating RO txn as applicable for direct mapping [ignite-3]
ascherbakoff opened a new pull request, #6272: URL: https://github.com/apache/ignite-3/pull/6272 https://issues.apache.org/jira/browse/IGNITE-25921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
