Re: [PR] IGNITE-24201 Remove GridClient from control.sh [ignite]
NSAmelchev merged PR #11804: URL: https://github.com/apache/ignite/pull/11804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IGNITE-24201 Remove GridClient from control.sh [ignite]
sonarqubecloud[bot] commented on PR #11804: URL: https://github.com/apache/ignite/pull/11804#issuecomment-2606529467 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11804) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11804&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11804&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=11804&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11804&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11804&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11804) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IGNITE-24201 Remove GridClient from control.sh [ignite]
sonarqubecloud[bot] commented on PR #11804: URL: https://github.com/apache/ignite/pull/11804#issuecomment-2598627214 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11804) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11804&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11804&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=11804&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11804&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11804&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11804) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IGNITE-24201 Remove GridClient from control.sh [ignite]
sonarqubecloud[bot] commented on PR #11804: URL: https://github.com/apache/ignite/pull/11804#issuecomment-2596267869 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11804) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11804&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11804&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=11804&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11804&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11804&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11804) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IGNITE-24201 Remove GridClient from control.sh [ignite]
nizhikov commented on code in PR #11804:
URL: https://github.com/apache/ignite/pull/11804#discussion_r1916182598
##
modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/ArgumentParser.java:
##
@@ -98,12 +93,6 @@ public class ArgumentParser {
/** Option is used for auto confirmation. */
public static final String CMD_AUTO_CONFIRMATION = "--yes";
-/** Ping interval for grid client. See {@link
GridClientConfiguration#getPingInterval()}. */
-static final String CMD_PING_INTERVAL = "--ping-interval";
-
-/** Ping timeout for grid client. See {@link
GridClientConfiguration#getPingTimeout()}. */
-static final String CMD_PING_TIMEOUT = "--ping-timeout";
-
/** Verbose mode. */
public static final String CMD_VERBOSE = "--verbose";
Review Comment:
Do we still need `--verbose` parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] IGNITE-24201 Remove GridClient from control.sh [ignite]
nizhikov commented on code in PR #11804:
URL: https://github.com/apache/ignite/pull/11804#discussion_r1916145598
##
modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/CommandHandler.java:
##
@@ -282,9 +259,8 @@ public int
execute(List rawArgs) {
while (true) {
try (
-CloseableCliCommandInvoker invoker =
useConnectorConnection()
-? new CliCommandInvoker<>(args.command(),
args.commandArg(), getClientConfiguration(args))
-: new CliIgniteClientInvoker<>(args.command(),
args.commandArg(), clientConfiguration(args))
+CloseableCliCommandInvoker invoker =
Review Comment:
Looks like we don't need `CloseableCliCommandInvoker` anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] IGNITE-24201 Remove GridClient from control.sh [ignite]
sonarqubecloud[bot] commented on PR #11804: URL: https://github.com/apache/ignite/pull/11804#issuecomment-2590456235 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11804) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11804&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11804&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=11804&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11804&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11804&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11804) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IGNITE-24201 Remove GridClient from control.sh [ignite]
sonarqubecloud[bot] commented on PR #11804: URL: https://github.com/apache/ignite/pull/11804#issuecomment-2589685213 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11804) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11804&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=11804&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=11804&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11804&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=11804&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=11804) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
