Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
petrov-mg merged PR #13346: URL: https://github.com/apache/ignite/pull/13346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4947736886 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkOperationContextAwareCustomMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
petrov-mg commented on code in PR #13346: URL: https://github.com/apache/ignite/pull/13346#discussion_r3564570048 ## modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java: ## Review Comment: **sendCustomMessage** is not used in `ZookeeperDiscoverySpi` now. `ZookeeperDiscoverySpi` now uses **sendCustomEvent**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4947536201 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkOperationContextAwareCustomMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
Vladsz83 commented on code in PR #13346: URL: https://github.com/apache/ignite/pull/13346#discussion_r3564561816 ## modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java: ## Review Comment: Is used in `ZookeeperDiscoverySpi` which resides other package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
Vladsz83 commented on code in PR #13346:
URL: https://github.com/apache/ignite/pull/13346#discussion_r3564522326
##
modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java:
##
@@ -1164,6 +1174,18 @@ private void
marshalCredentialsOnJoin(ZookeeperClusterNode node) throws IgniteSp
}
}
+/**
+ * Sends from-Ignite custom event, not Zookeeper-related. Is aware of
distributed {@link OperationContext}.
+ *
+ * @see ZkCustomEventMessage
+ */
+public void sendExternalCustomMessage(DiscoverySpiCustomMessage msg) {
+// Holds the distributed operation context.
+msg = new ZkCustomEventMessage(msg,
opCtxDispatcher.collectDistributedAttributes());
+
+sendCustomMessage(msg);
+}
Review Comment:
> Up to you whether to remove the `null` check for `msg`.
Already done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
petrov-mg commented on code in PR #13346: URL: https://github.com/apache/ignite/pull/13346#discussion_r3564520420 ## modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java: ## Review Comment: It is better to make `sendCustomMessage` method package-private now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
petrov-mg commented on code in PR #13346:
URL: https://github.com/apache/ignite/pull/13346#discussion_r3564518459
##
modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java:
##
@@ -1164,6 +1174,18 @@ private void
marshalCredentialsOnJoin(ZookeeperClusterNode node) throws IgniteSp
}
}
+/**
+ * Sends from-Ignite custom event, not Zookeeper-related. Is aware of
distributed {@link OperationContext}.
+ *
+ * @see ZkCustomEventMessage
+ */
+public void sendExternalCustomMessage(DiscoverySpiCustomMessage msg) {
+// Holds the distributed operation context.
+msg = new ZkCustomEventMessage(msg,
opCtxDispatcher.collectDistributedAttributes());
+
+sendCustomMessage(msg);
+}
Review Comment:
Up to you whether to remove the `null` check for `msg`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
Vladsz83 commented on code in PR #13346: URL: https://github.com/apache/ignite/pull/13346#discussion_r3564506612 ## modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java: ## Review Comment: ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
Vladsz83 commented on code in PR #13346:
URL: https://github.com/apache/ignite/pull/13346#discussion_r3564501385
##
modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java:
##
@@ -1164,6 +1174,18 @@ private void
marshalCredentialsOnJoin(ZookeeperClusterNode node) throws IgniteSp
}
}
+/**
+ * Sends from-Ignite custom event, not Zookeeper-related. Is aware of
distributed {@link OperationContext}.
+ *
+ * @see ZkCustomEventMessage
+ */
+public void sendExternalCustomMessage(DiscoverySpiCustomMessage msg) {
+// Holds the distributed operation context.
+msg = new ZkCustomEventMessage(msg,
opCtxDispatcher.collectDistributedAttributes());
+
+sendCustomMessage(msg);
+}
Review Comment:
Looks like `msg` cannot be null,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4947139526 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
petrov-mg commented on code in PR #13346: URL: https://github.com/apache/ignite/pull/13346#discussion_r3564474272 ## modules/zookeeper/src/test/java/org/apache/ignite/spi/discovery/zk/internal/ZkOperationContextSendAttributesTest.java: ## @@ -0,0 +1,33 @@ + Review Comment: Remove an empty line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
petrov-mg commented on code in PR #13346:
URL: https://github.com/apache/ignite/pull/13346#discussion_r3564371246
##
modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryImpl.java:
##
@@ -1164,6 +1174,18 @@ private void
marshalCredentialsOnJoin(ZookeeperClusterNode node) throws IgniteSp
}
}
+/**
+ * Sends from-Ignite custom event, not Zookeeper-related. Is aware of
distributed {@link OperationContext}.
+ *
+ * @see ZkCustomEventMessage
+ */
+public void sendExternalCustomMessage(DiscoverySpiCustomMessage msg) {
+// Holds the distributed operation context.
+msg = new ZkCustomEventMessage(msg,
opCtxDispatcher.collectDistributedAttributes());
+
+sendCustomMessage(msg);
+}
Review Comment:
```suggestion
public void sendCustomEvent(DiscoverySpiCustomMessage msg) {
OperationContextMessage opCtx =
opCtxDispatcher.collectDistributedAttributes();
if (opCtx != null && msg != null)
sendCustomMessage(new ZkOperationContextAwareCustomMessage(msg,
opCtx));
else
sendCustomMessage(msg);
}
```
##
modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.spi.discovery.zk.internal;
+
+import org.apache.ignite.internal.OperationContextMessage;
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.thread.context.OperationContext;
+import org.apache.ignite.internal.thread.context.OperationContextDispatcher;
+import org.apache.ignite.plugin.extensions.communication.MessageFactory;
+import org.apache.ignite.spi.discovery.DiscoverySpiCustomMessage;
+import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
+import
org.apache.ignite.spi.discovery.tcp.messages.TcpDiscoveryAbstractMessage;
+import org.apache.ignite.spi.discovery.zk.ZookeeperDiscoverySpi;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * A holder for effective attributes of distributed {@link
OperationContext}. Analogue of
+ * {@link TcpDiscoveryAbstractMessage#opCtxMsg} while we do not use a common
base class for all the Zookeeper messages.
+ *
+ * NOTE: The difference is also the limitation on message type. In {@link
TcpDiscoverySpi} we transfer distributed
+ * {@link OperationContext} with all the messages. In {@link
ZookeeperDiscoverySpi} with from-Ignite
+ * {@link DiscoverySpiCustomMessage} only.
+ *
+ * @see OperationContextDispatcher
+ * @see ZookeeperDiscoverySpi#sendCustomEvent(DiscoverySpiCustomMessage)
+ */
+public class ZkCustomEventMessage implements DiscoverySpiCustomMessage {
+/** */
+@Order(0)
+DiscoverySpiCustomMessage delegate;
+
+/** */
+@Order(1)
+@Nullable OperationContextMessage opCtxMsg;
+
+/** Default constructor for {@link MessageFactory}. */
+public ZkCustomEventMessage() {
+// No-op.
+}
+
+/**
+ * @param delegate Original message.
+ * @param opCtxMsg Distributed operation context message.
+ */
+public ZkCustomEventMessage(DiscoverySpiCustomMessage delegate, @Nullable
OperationContextMessage opCtxMsg) {
+this.delegate = delegate;
+this.opCtxMsg = opCtxMsg;
+}
+
+/** {@inheritDoc} */
+@Override public @Nullable DiscoverySpiCustomMessage ackMessage() {
+DiscoverySpiCustomMessage res = delegate.ackMessage();
+
+assert !(res instanceof ZkCustomEventMessage);
+
+if (opCtxMsg == null || res == null)
+return res;
+
+return new ZkCustomEventMessage(res, opCtxMsg);
Review Comment:
```suggestion
DiscoverySpiCustomMessage ack = delegate.ackMessage();
return ack == null ? null : new
ZkOperationContextAwareCustomMessage(ack, opCtxMsg);
```
##
modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4933817363 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4928690144 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4927885466 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4927640831 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4927578434 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4927503419 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4927480311 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13346: URL: https://github.com/apache/ignite/pull/13346#issuecomment-4925986355 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
Vladsz83 closed pull request #13284: IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage URL: https://github.com/apache/ignite/pull/13284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4916148620 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4915739607 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4913340792 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4907612016 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4902353856 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4894237739 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4893682128 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4893675010 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4893353067 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4892359796 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4892332540 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4891915273 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4876784079 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4850775894 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityContextImpl.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4842234264 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityContextImpl.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4841728283 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityContextImpl.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4841324517 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityContextImpl.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4834410572 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityContextImpl.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4834207532 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityContextImpl.java` - `modules/zookeeper/src/main/java/org/apache/ignite/spi/discovery/zk/internal/ZkCustomEventMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4808937923 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityContextImpl.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
Vladsz83 commented on code in PR #13284:
URL: https://github.com/apache/ignite/pull/13284#discussion_r3480400648
##
modules/core/src/test/java/org/apache/ignite/internal/thread/context/OperationContextAttributesTest.java:
##
@@ -877,14 +877,16 @@ private void
doTestOperationContextAttributesPropagation(boolean discovery) thro
@Override public void start(PluginContext ctx) {
GridKernalContext kctx = ((IgniteEx)ctx.grid()).context();
-
kctx.operationContextDispatcher().registerDistributedAttribute(0, dAttr1);
+int dAttr1Id = OperationContextDispatcher.MAX_ATTRS_CNT - 2;
Review Comment:
Sometimes, we'll fill out the ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
Vladsz83 commented on code in PR #13284: URL: https://github.com/apache/ignite/pull/13284#discussion_r3480395622 ## modules/core/src/main/java/org/apache/ignite/internal/CoreMessagesProvider.java: ## @@ -606,7 +606,9 @@ public CoreMessagesProvider(Marshaller dfltMarsh, Marshaller schemaAwareMarsh, C // [11500 - 11600]: IO, networking messages. msgIdx = NODE_ID_MSG_TYPE; withNoSchema(NodeIdMessage.class); +msgIdx = HANDSHAKE_MSG_TYPE; Review Comment: Minor reliability fix. Wanted to bring long ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4808223569 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityContextMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
Vladsz83 commented on code in PR #13284: URL: https://github.com/apache/ignite/pull/13284#discussion_r3480391527 ## modules/core/src/main/java/org/apache/ignite/internal/CoreMessagesProvider.java: ## @@ -688,9 +690,10 @@ public CoreMessagesProvider(Marshaller dfltMarsh, Marshaller schemaAwareMarsh, C // [13400 - 13500]: Operation context messages. msgIdx = 13400; withNoSchema(OperationContextMessage.class); +withNoSchema(SecurityContextMessage.class); -// [13500 - 13600]: Rolling Upgrade messages. Review Comment: We kept a 100-numbers-space earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
Vladsz83 commented on code in PR #13284:
URL: https://github.com/apache/ignite/pull/13284#discussion_r3480381606
##
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java:
##
@@ -478,6 +481,8 @@ private void updateClientNodes(UUID leftNodeId) {
/** {@inheritDoc} */
@Override public void start() throws IgniteCheckedException {
+ctx.operationContextDispatcher().registerDistributedAttribute(0,
SEC_OP_CTX_ATTR);
Review Comment:
Here we could put a ticket ref. to consider creation of a determined
attributes id enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-28754 Replace SecurityAwareCustomMessageWrapper with OperationContextMessage [ignite]
github-actions[bot] commented on PR #13284: URL: https://github.com/apache/ignite/pull/13284#issuecomment-4808150783 ## Possible compatibility issues. Please, check rolling upgrade cases This PR modifies protected classes (with **Order** annotation). Changes to these classes can break rolling upgrade compatibility. **Affected files:** - `modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java` - `modules/core/src/main/java/org/apache/ignite/internal/processors/security/SecurityContextMessage.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
