Re: [jclouds] Add keystone user add and delete methods. (#290)

@@ -123,4 +137,29 @@ @Fallback(EmptySetOnNotFoundOr404.class) ListenableFuture? extends Set? extends Role listRolesOfUserOnTenant(@PathParam(userId) String userId, @PathParam(tenantId) String tenantId); + + /** +* @see UserApi#add(String, String, Boolean,

[jira] [Commented] (JCLOUDS-467) nameNodes only taking first name with AWS

[ https://issues.apache.org/jira/browse/JCLOUDS-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900119#comment-13900119 ] Ignasi Barrera commented on JCLOUDS-467: Maybe just taking the nodeNames iterator

Re: [jclouds] Add keystone user add and delete methods. (#290)

@@ -81,4 +81,21 @@ */ Set? extends Role listRolesOfUserOnTenant(String userId, String tenantId); + /** +* Create a new user in keystone. Creates (per Javadoc style guide - descriptive over imperative) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Add keystone user add and delete methods. (#290)

+ @Path(/users) + @RequestFilters(AuthenticateRequest.class) + @Fallback(NullOnNotFoundOr404.class) + ListenableFuture? extends User add(@PayloadParam(username) String userName, +@PayloadParam(email) String userEmail, +

Re: [jclouds] Add keystone user add and delete methods. (#290)

+ + User newUser = userApi.add(randUser, email, true, password); + + // validate that our new user exists + Set? extends User newUsers = userApi.list().concat().toSet(); + assertTrue(newUsers.contains(newUser)); + + // validate that we can delete

Re: [jclouds] Add keystone user add and delete methods. (#290)

Fixed javadoc style comments. I'm not particularly tied to the fallback behavior on user deletion; I'm open to other options. Once we figure out what behavior we want, I'll update the javadoc so that it better describes the behavior. --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Add keystone user add and delete methods. (#290)

@@ -86,4 +88,37 @@ public void testUsersByName() { } } + + public void testAddDeleteUser() { I wrote this as one test because the test for the delete operation requires that the add operation succeed, and that we know the ID of the user that was created. We should be

Re: [jclouds] Add keystone user add and delete methods. (#290)

[jclouds-pull-requests #601](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/601/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/290#issuecomment-35023554

[jira] [Created] (JCLOUDS-468) Nova needs to handle key pair creation better in the ComputeService

Everett Toews created JCLOUDS-468: - Summary: Nova needs to handle key pair creation better in the ComputeService Key: JCLOUDS-468 URL: https://issues.apache.org/jira/browse/JCLOUDS-468 Project:

[jira] [Commented] (JCLOUDS-468) Nova needs to handle key pair creation better in the ComputeService

[ https://issues.apache.org/jira/browse/JCLOUDS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901196#comment-13901196 ] Ignasi Barrera commented on JCLOUDS-468: The DigitalOcean provider also needs a