Thanks for the review comments @nacx ! I do need to add (back) the code to
actually use the keyvaultidAndSecret, will do that. Will address the other
comments as well.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@nacx Please let me know what are the next steps towards this change.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1114#issuecomment-314311148
@nacx Thanks for the detailed description on injecting optional async blob
store context. I have followed the inheritance approach and updated the pull
request.
I have also made changes to invoke function to return ListenableFuture.
Please let me know any other changes to be made in this pull
@kishore25kumar pushed 2 commits.
20c84d2 Added binding optional async blob store in base class
56ff532 Fixed checkstyle issues
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
>I have also made changes to invoke function to return ListenableFuture.
That was the suggestion to simplify the base driver class code, if that didn't
introduce significant overhead.
I think it actually makes sense for the driver implementations to have the
invoke and invokeAsync signatures
@kishore25kumar pushed 1 commit.
9a6b749 Changed invoke method return type to ListenableFuture
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@nacx Sorry I took it wrong. Wrapping the sync result in the future makes more
sense. I this way no driver needs to be touched. I have made changes to my pull
request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> Wrapping the sync result in the future makes more sense. I this way no driver
> needs to be touched. I have made changes to my pull request.
My comment wasn't clear. Thanks! :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
