Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

2014-02-05 Thread Andrew Phillips
@@ -91,6 +91,21 @@ version${jclouds.version}/version scopetest/scope /dependency +!-- +exclusions +exclusion +groupIdnet.schmizz/groupId +artifactIdsshj/artifactId +

Re: [jclouds] Enable connecting to Rackspace Swift with Swift module through OpenStack Keystone (#282)

2014-02-05 Thread Andrew Phillips
@everett-toews: Suggestion for how to proceed with this PR? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/282#issuecomment-34214904

Re: [jclouds] Adding bcpkix to the jclouds-sshj driver. Required by sshj. (1.7.x backport) (#279)

2014-02-05 Thread Andrew Phillips
Committed to [1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=3db57e01b06d401da38b35850697812457df41cd) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/279#issuecomment-34217308

Re: [jclouds] Adding bcpkix to the jclouds-sshj driver. Required by sshj. (1.6.x backport) (#280)

2014-02-05 Thread Andrew Phillips
Committed to [1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=9fbe68ef934868eaeaa2ab4dc5c1727b70b2f78b) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/280#issuecomment-34217347

Re: [jclouds] Adding bcpkix to the jclouds-sshj driver. Required by sshj. (#278)

2014-02-05 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=4330eaec57fe0306043a11eef727c66ae71f3a70) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/278#issuecomment-34217249

Re: [jclouds] JCLOUDS-450. Adding support for EC2 MaxCount option. (#277)

2014-02-05 Thread Andrew Phillips
@@ -285,4 +279,36 @@ public void testinboundPortsStatic() { assertEquals(options.getInboundPorts()[0], 22); assertEquals(options.getInboundPorts()[1], 30); } + + @Test + public void testMaxCountDefault() { + EC2TemplateOptions options = new EC2TemplateOptions();

Re: [jclouds] Adds a top-level zone filter. (#283)

2014-02-05 Thread Andrew Phillips
@@ -74,6 +76,19 @@ protected String setIfTestSystemPropertyPresent(Properties overrides, String key return null; } + /** +* This helps live testing against specific zones only. +* @param zones A list of zones, usually from getConfiguredZones() +* @return

Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

2014-02-05 Thread Andrew Phillips
+import static com.google.common.base.Preconditions.checkState; +import static com.google.common.collect.Iterables.contains; +import static com.google.common.collect.Iterables.filter; +import static com.google.common.collect.Iterables.transform; +import static

Re: [jclouds] Adds a top-level zone filter. (#283)

2014-02-05 Thread Andrew Phillips
for (String zone : filterZones(api.getConfiguredZones())) { Would it be possible to override getConfiguredZones for tests in some other way? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/283#issuecomment-34230068

Re: [jclouds] Adds a top-level zone filter. (#283)

2014-02-05 Thread Andrew Phillips
I felt that would be too invasive, but perhaps doable. Thoughts? I don't know enough about how getConfiguredZones is set up. If it's something that could be overridden at wiring time, that might work. Obviously, changes to look for special test properties is probably not what we want in the

Re: [jclouds] Adds a top-level zone filter. (#283)

2014-02-06 Thread Andrew Phillips
I feel this is safer and more consistent with what already have. Any chance to move it a little closer to where it's actually going to be used? Do we have a base class for OpenStack API live tests, for example? --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Adds a top-level zone filter. (#283)

2014-02-06 Thread Andrew Phillips
jclouds-pull-requests #581 UNSTABLE Unrelated [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/org.apache.jclouds$jclouds-compute/581/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/). Good to go for me. I was

Re: [jclouds] Adds a top-level zone filter. (#283)

2014-02-06 Thread Andrew Phillips
No backporting to 1.7.x, just to be sure! ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/283#issuecomment-34380776

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

2014-02-07 Thread Andrew Phillips
@abayer @nacx @andrewgaul: thoughts on merging this one? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/281#issuecomment-34431668

[jclouds-chef] Adding inceptionYear 2009 to the project POM (#40)

2014-02-07 Thread Andrew Phillips
Backport of ef826676 to 1.7.x You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-chef backport-incp-year Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-chef/pull/40 -- Commit Summary -- * Adding

[jclouds-karaf] Adding inceptionYear 2009 to the top-level POM (#33)

2014-02-07 Thread Andrew Phillips
You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-karaf add-incp-year Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-karaf/pull/33 -- Commit Summary -- * Adding lt;inceptionYeargt; 2009 to the top-level

[jclouds-karaf] Adding inceptionYear 2009 to the top-level POM (1.7.x) (#34)

2014-02-07 Thread Andrew Phillips
1.7.x version of https://github.com/jclouds/jclouds-karaf/pull/33 You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-karaf add-incp-year-1.7.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-karaf/pull/34 --

Re: [jclouds-chef] Adding inceptionYear 2009 to the project POM (#40)

2014-02-07 Thread Andrew Phillips
but merge this after the release :) Erm...yes...that was indeed the plan ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/40#issuecomment-34434467

Re: [jclouds-karaf] [JCLOUDS-189] Upgrade to Karaf 2.3.2. Explicitly specify jclouds feature... (#24)

2014-02-07 Thread Andrew Phillips
jclouds-karaf-pull-requests #31 UNSTABLE All integration tests failing with errors such as: ``` features:install jclouds-aws-sts java.lang.Exception: No feature named 'jclouds-aws-sts' with version '0.0.0' available ``` Also a bunch of new Checkstyle violations: *

Re: [jclouds-karaf] Adding inceptionYear 2009 to the top-level POM (1.7.x) (#34)

2014-02-07 Thread Andrew Phillips
jclouds-karaf-pull-requests #33 UNSTABLE Checkstyle complaining here - no [test failures](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/33/testReport/) --- Reply to this email directly or view it on GitHub:

Re: [jclouds-karaf] [JCLOUDS-189] Upgrade to Karaf 2.3.2. Explicitly specify jclouds feature... (#24)

2014-02-07 Thread Andrew Phillips
it seems that maven repository is not ~/.m2/repository No, it isn't (thankfully in terms of avoiding where did that JAR come from?? problems, if you ask me). Is there any way we can make this a configurable value? --- Reply to this email directly or view it on GitHub:

Re: [jclouds-karaf] [JCLOUDS-189] Upgrade to Karaf 2.3.2. Explicitly specify jclouds feature... (#24)

2014-02-07 Thread Andrew Phillips
Is this something new in 2.3.2, by the way? Other PRs to this repo seem to work fine, e.g. https://github.com/jclouds/jclouds-karaf/pull/22 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/24#issuecomment-34438815

Re: [jclouds-karaf] [JCLOUDS-189] Upgrade to Karaf 2.3.2. Explicitly specify jclouds feature... (#24)

2014-02-07 Thread Andrew Phillips
Let me check Thanks! What is 1. looks for the specified url..? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/24#issuecomment-34439823

[jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-07 Thread Andrew Phillips
Looks like the workaround for Guava 1635 will be with us for a while on 1.7.x You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds cleanup-5976159-1.7.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/284 --

Re: [jclouds-karaf] Adding inceptionYear 2009 to the top-level POM (#33)

2014-02-07 Thread Andrew Phillips
jclouds-karaf-pull-requests #32 UNSTABLE That's Checkstyle complaining - the build itself has no [test failures](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/32/testReport/) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-07 Thread Andrew Phillips
jclouds-java-7-pull-requests #1054 UNSTABLE Unrelated [test

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-07 Thread Andrew Phillips
7u51 DEV@cloud job running: https://jclouds.ci.cloudbees.com/job/jclouds-java-7u51/35/console --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/284#issuecomment-34442894

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-07 Thread Andrew Phillips
@nacx: Will wait for 1.7.1 to be pushed before merging... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/284#issuecomment-34465408

[jclouds-chef] Adding inceptionYear 2009 to the project POM (1.6.x) (#41)

2014-02-07 Thread Andrew Phillips
Backport of ef82667 to 1.7.x. See #40 You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-chef backport-incp-year-1.6.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-chef/pull/41 -- Commit Summary -- *

[jclouds-karaf] Adding inceptionYear 2009 to the top-level POM (1.6.x) (#35)

2014-02-07 Thread Andrew Phillips
You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-karaf add-incp-year-1.6.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-karaf/pull/35 -- Commit Summary -- * Adding lt;inceptionYeargt; 2009 to the

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

2014-02-10 Thread Andrew Phillips
Committed to master: [#1](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=02615adc4f45799d07f61727167b65c87458f573), [#2](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=4c07702d29de64df45c11819c2cc9d725382b0c2). --- Reply to this email directly or view it on

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

2014-02-10 Thread Andrew Phillips
Another verification build running against master [using 7u51](https://jclouds.ci.cloudbees.com/job/jclouds-java-7u51/36/console) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/281#issuecomment-34643210

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

2014-02-10 Thread Andrew Phillips
I asked about a 15.0.1 release in the upstream Guava issue: I saw that, thanks @andrewgaul! Curious to see if there'll be any response... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/281#issuecomment-34652502

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

2014-02-10 Thread Andrew Phillips
A final verification build running against master using 7u51 ``` channel stopped Finished: SUCCESS ``` --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/281#issuecomment-34662659

Re: [jclouds-labs-openstack] Adds support for Rackspace Cloud Big Data (#78)

2014-02-10 Thread Andrew Phillips
+ * +/jclouds.osgi.import + /properties + + repositories +repository + idapache-snapshots/id + urlhttps://repository.apache.org/content/repositories/snapshots/url + releases +enabledfalse/enabled + /releases + snapshots +

Re: [jclouds-labs-openstack] Adds support for Rackspace Cloud Big Data (#78)

2014-02-10 Thread Andrew Phillips
+ * +/jclouds.osgi.import + /properties + + repositories +repository + idapache-snapshots/id + urlhttps://repository.apache.org/content/repositories/snapshots/url + releases +enabledfalse/enabled + /releases + snapshots +

Re: [jclouds] JCLOUDS-459: Limit maximum user threads (#287)

2014-02-11 Thread Andrew Phillips
@@ -66,7 +66,7 @@ public static Properties defaultProperties() { props.setProperty(PROPERTY_SO_TIMEOUT, 6 + ); props.setProperty(PROPERTY_CONNECTION_TIMEOUT, 6 + ); props.setProperty(PROPERTY_IO_WORKER_THREADS, 20 + ); -

Re: [jclouds] JCLOUDS-460: Add jitter to avoid thundering herd (#286)

2014-02-11 Thread Andrew Phillips
@@ -126,6 +127,9 @@ public void imposeBackoffExponentialDelay(long period, int pow, int failureCount public void imposeBackoffExponentialDelay(long period, long maxPeriod, int pow, int failureCount, int max, String commandDescription) { long delayMs = (long) (period

Re: [jclouds-karaf] Adding inceptionYear 2009 to the top-level POM (#33)

2014-02-11 Thread Andrew Phillips
@nacx: Could you quickly have a look at these? Looks like Ioannis is not available. Not a big change, thankfully ;-) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/33#issuecomment-34774052

Re: [jclouds-karaf] Adding inceptionYear 2009 to the top-level POM (#33)

2014-02-11 Thread Andrew Phillips
Thanks, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/33#issuecomment-34774605

Re: [jclouds-karaf] Adding inceptionYear 2009 to the top-level POM (#33)

2014-02-11 Thread Andrew Phillips
Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=6abf499b0090dc934ccd4678aba97dcb744e64ad) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/33#issuecomment-34782102

Re: [jclouds-karaf] Adding inceptionYear 2009 to the top-level POM (1.7.x) (#34)

2014-02-11 Thread Andrew Phillips
Committed to [1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=1c6801c47fbde3d4d08a36b563e890225a05e8b2). Failures are due to missing 1.7.2-SNAPSHOT deps. --- Reply to this email directly or view it on GitHub:

Re: [jclouds-karaf] Adding inceptionYear 2009 to the top-level POM (1.6.x) (#35)

2014-02-11 Thread Andrew Phillips
Committed to [1.6.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=commit;h=62c1f6acdc5cd5bbafeeb8ce6b18d8127dbc7960) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/35#issuecomment-34782414

Re: [jclouds] JCLOUDS-460: Add jitter to avoid thundering herd (#286)

2014-02-11 Thread Andrew Phillips
@@ -126,6 +127,9 @@ public void imposeBackoffExponentialDelay(long period, int pow, int failureCount public void imposeBackoffExponentialDelay(long period, long maxPeriod, int pow, int failureCount, int max, String commandDescription) { long delayMs = (long) (period

Re: [jclouds] JCLOUDS-459: Limit maximum user threads (#287)

2014-02-11 Thread Andrew Phillips
Thanks for the explanation, @andrewgaul! Code comment to explain the value of 50 would be nice, but +1 from me without that, too. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/287#issuecomment-34821878

Re: [jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-11 Thread Andrew Phillips
+ return false; + } + if (response.getStatusCode() == 500) { + byte[] content = HttpUtils.closeClientButKeepContentStream(response); + // Content can be null in the case of HEAD requests + if (content != null) { +try { +

Re: [jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-11 Thread Andrew Phillips
+ + @Inject + public AtmosServerErrorRetryHandler(BackoffLimitedRetryHandler backoffHandler, +AtmosUtils utils) { + this.backoffHandler = backoffHandler; + this.utils = utils; + } + + @Inject(optional = true) + @Named(Constants.PROPERTY_MAX_RETRIES) +

Re: [jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-11 Thread Andrew Phillips
+ } + + @Inject(optional = true) + @Named(Constants.PROPERTY_MAX_RETRIES) + private int retryCountLimit = 5; + @Resource + protected Logger logger = Logger.NULL; + + public boolean shouldRetryRequest(HttpCommand command, HttpResponse response) { + if

Re: [jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-11 Thread Andrew Phillips
+ HttpCommand command = createMock(HttpCommand.class); + String content = String.format(HTTP_MESSAGE_FORMAT, 1040, The server is busy. Please try again); + HttpResponse response = HttpResponse.builder().statusCode(500).payload(content).build(); + +

Re: [jclouds] JCLOUDS-137: Retry on HTTP 500 AtmosError 1040 (#285)

2014-02-11 Thread Andrew Phillips
Committed to master and 1.7.x. Ah, I see my review is already a little late :-( @andrewgaul: most of the questions are minor, the only one that we may really need to look at, I think, is about making sure we increment the failure count correctly. --- Reply to this email directly or view it on

Re: [jclouds-chef] Adding inceptionYear 2009 to the project POM (#40)

2014-02-11 Thread Andrew Phillips
Closed #40. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/40

Re: [jclouds-chef] Adding inceptionYear 2009 to the project POM (#40)

2014-02-11 Thread Andrew Phillips
Reopened #40. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/40

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-11 Thread Andrew Phillips
Closed #284. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/284

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-11 Thread Andrew Phillips
Reopened #284. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/284

Re: [jclouds-chef] Adding inceptionYear 2009 to the project POM (#40)

2014-02-11 Thread Andrew Phillips
jclouds-chef-pull-requests #102 FAILURE Eek. Jumped the gun a bit there ;-) Still missing some deps: ``` Caused by: org.sonatype.aether.transfer.ArtifactNotFoundException: Could not find artifact org.apache.jclouds:jclouds-allcompute:jar:1.7.2-SNAPSHOT ``` --- Reply to this email directly or

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-11 Thread Andrew Phillips
jclouds-java-7-pull-requests #1060 FAILURE Still a problem with Checkstyle deps. Looks like it's looking in the wrong repo: ``` Caused by: org.apache.maven.plugin.PluginResolutionException: Plugin org.apache.maven.plugins:maven-checkstyle-plugin:2.11 or one of its dependencies could not be

Re: [jclouds-chef] Adding inceptionYear 2009 to the project POM (#40)

2014-02-11 Thread Andrew Phillips
Closed #40. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/40

Re: [jclouds-chef] Adding inceptionYear 2009 to the project POM (#40)

2014-02-11 Thread Andrew Phillips
Reopened #40. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/40

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-11 Thread Andrew Phillips
Looks like it's looking in the wrong repo: Waiting on https://github.com/jclouds/jclouds/pull/289 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/284#issuecomment-34830859

[jclouds] Update checkstyle plugin dep config (1.7.x) (#289)

2014-02-11 Thread Andrew Phillips
Backport of https://github.com/jclouds/jclouds/pull/288 to 1.7.x You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds update-checkstyle-config-1.7.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/289 --

[jclouds] Update checkstyle plugin dependency config (#288)

2014-02-11 Thread Andrew Phillips
The problem is that, even though the Checkstyle plugin config in the jclouds-project profile is correctly applied, the effective POM in jclouds-project _still_ contains the dependency, even though it doesn#39;t need it: lt;plugingt;

Re: [jclouds-chef] Adding inceptionYear 2009 to the project POM (#40)

2014-02-11 Thread Andrew Phillips
Committed to [1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-chef.git;a=commit;h=fd97267b9f0b14c77acf406ff45ae46074d1) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/40#issuecomment-34831044

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-11 Thread Andrew Phillips
jclouds-pull-requests #588 SUCCESS Weird. Maybe we don't need the repo thing after all. Let's try one more time... --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/284#issuecomment-34831412

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-11 Thread Andrew Phillips
Closed #284. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/284

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-11 Thread Andrew Phillips
Reopened #284. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/284

Re: [jclouds] Update checkstyle plugin dependency config (#288)

2014-02-11 Thread Andrew Phillips
Not sure we _need_ the plugin repo change for this, actually...let me see if we can remove it entirely. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/288#issuecomment-34831513

Re: [jclouds] Update checkstyle plugin dependency config (#288)

2014-02-11 Thread Andrew Phillips
Committed to master: [#1](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=d7d76291ae244ee2bd03b59cc1a5157b599f7d58), [#2](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=a1fc6558edb7d6c5fa6d490243e3ae8321864ad5). @nacx Please let me know if you have any

Re: [jclouds] Update checkstyle plugin dep config (1.7.x) (#289)

2014-02-11 Thread Andrew Phillips
jclouds » jclouds #836 UNSTABLE Unrelated [test

Re: [jclouds] Update checkstyle plugin dep config (1.7.x) (#289)

2014-02-11 Thread Andrew Phillips
Committed to 1.7.x: [#1](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=5f7a4aa5bf68cf1011ed7142265effc37c95908b), [#2](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=4804edb7e873b9ce7161a38a69cf1706106c1d89) --- Reply to this email directly or view it on

Re: [jclouds] Cleaning up checkstyle warnings caused by 5976159 (#284)

2014-02-11 Thread Andrew Phillips
Committed to 1.7.x: [#1](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=4804edb7e873b9ce7161a38a69cf1706106c1d89), [#2](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=b1a2baee6227cd9cbad87189fb6b54747cbc8cdd) --- Reply to this email directly or view it on

Re: [jclouds] Update checkstyle plugin dependency config (#288)

2014-02-11 Thread Andrew Phillips
Thanks for checking, by the way! On an unrelated note, I see that the core Checkstyle config now [also has](https://github.com/jclouds/jclouds/blob/master/project/pom.xml#L662): ``` includeTestSourceDirectorytrue/includeTestSourceDirectory ``` Should we add this here? --- Reply to this email

[jclouds-chef] Adding test source scanning to Checkstyle config (#42)

2014-02-12 Thread Andrew Phillips
Backport of 4cef85d from the main jclouds repo You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-chef port-4cef85d Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-chef/pull/42 -- Commit Summary -- * Adding

[jclouds-chef] Adding test source scanning to Checkstyle config (1.7.x) (#43)

2014-02-12 Thread Andrew Phillips
1.7.x version of https://github.com/jclouds/jclouds-chef/pull/42 You can merge this Pull Request by running: git pull https://github.com/jclouds/jclouds-chef port-4cef85d-1.7.x Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-chef/pull/43 -- Commit

Re: [jclouds-chef] Adding test source scanning to Checkstyle config (#42)

2014-02-12 Thread Andrew Phillips
@nacx: Looks OK? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/42#issuecomment-34901248

Re: [jclouds-chef] Adding test source scanning to Checkstyle config (1.7.x) (#43)

2014-02-12 Thread Andrew Phillips
Committed to [1.7.x](https://git-wip-us.apache.org/repos/asf?p=jclouds-chef.git;a=commit;h=3aff904fb9b5b071ad13e3a25f37b274c8ec7e7d) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-chef/pull/43#issuecomment-34904781

Re: [jclouds] Implement a poor-mans rollback if static nat creation fails (#184)

2014-02-13 Thread Andrew Phillips
I'll give it a go and test this with the master branch. Thanks, @spark404! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/184#issuecomment-34985369

Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-13 Thread Andrew Phillips
@@ -81,4 +81,21 @@ */ Set? extends Role listRolesOfUserOnTenant(String userId, String tenantId); + /** +* Create a new user in keystone. Creates (per Javadoc style guide - descriptive over imperative) --- Reply to this email directly or view it on GitHub:

Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-13 Thread Andrew Phillips
@@ -81,4 +81,21 @@ */ Set? extends Role listRolesOfUserOnTenant(String userId, String tenantId); + /** +* Create a new user in keystone. +* +* @param userName the name for the new user +* @param userEmail the email address for the new user +* @param

Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-13 Thread Andrew Phillips
+ @Path(/users) + @RequestFilters(AuthenticateRequest.class) + @Fallback(NullOnNotFoundOr404.class) + ListenableFuture? extends User add(@PayloadParam(username) String userName, +@PayloadParam(email) String userEmail, +

Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-13 Thread Andrew Phillips
@@ -86,4 +88,37 @@ public void testUsersByName() { } } + + public void testAddDeleteUser() { Split this out into two tests, one depending on the other? Like this, if the test fails, we don't know which of the operations broke... --- Reply to this email directly or view

Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-13 Thread Andrew Phillips
+ + User newUser = userApi.add(randUser, email, true, password); + + // validate that our new user exists + Set? extends User newUsers = userApi.list().concat().toSet(); + assertTrue(newUsers.contains(newUser)); + + // validate that we can delete

Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-13 Thread Andrew Phillips
@@ -86,4 +88,37 @@ public void testUsersByName() { } } + + public void testAddDeleteUser() { We should be able to figure out which operation failed by looking at which assert failed. Sure, but if you're looking at test results in Jenkins or whatever, it's nice when

Re: [jclouds] JCLOUDS-470. Include region in group name for AWSEC2SecurityGroupExtensi... (#291)

2014-02-14 Thread Andrew Phillips
@@ -41,13 +46,6 @@ import org.jclouds.net.domain.IpPermission; import org.jclouds.net.domain.IpProtocol; -import com.google.common.base.Function; -import com.google.common.base.Supplier; -import com.google.common.cache.LoadingCache; -import com.google.common.collect.Iterables; -import

Re: [jclouds] JCLOUDS-470. Include region in group name for AWSEC2SecurityGroupExtensi... (#291)

2014-02-14 Thread Andrew Phillips
+1 - looks good to me. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/291#issuecomment-35130627

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread Andrew Phillips
@@ -175,12 +175,13 @@ public String apply(NodeMetadata in) { MapString, ? extends NodeMetadata instancesById = Maps.uniqueIndex(input, instanceId); ImmutableSet.BuilderNodeMetadata builder = ImmutableSet.NodeMetadata builder(); + ListString namesToUse =

Re: [jclouds] JCLOUDS-470. Include region in group name for AWSEC2SecurityGroupExtensi... (#291)

2014-02-14 Thread Andrew Phillips
jclouds-java-7-pull-requests #1073 UNSTABLE Unrelated [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1073/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/) --- Reply to

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread Andrew Phillips
if (generateInstanceNames !common.containsKey(Name)) { for (Map.EntryString, ? extends NodeMetadata entry : instancesById.entrySet()) { String id = entry.getKey(); String name; -if (!nodeNames.isEmpty()) { - name =

Re: [jclouds-labs-openstack] Adds support for Rackspace Cloud Files API (#79)

2014-02-14 Thread Andrew Phillips
@jdaggett Just to make sure I'm getting this right...this is a different/new version of the CloudFiles API as that covered by the [current provider](https://github.com/jclouds/jclouds/blob/master/apis/cloudfiles/src/main/java/org/jclouds/cloudfiles/CloudFilesApiMetadata.java)? If so, could you

Re: [jclouds] JCLOUDS-467. Properly iterate over node names for EC2 instance creation. (#292)

2014-02-14 Thread Andrew Phillips
A question and a minor comment, that's all. +1 - looks good to me. Thanks, @abayer! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/292#issuecomment-35131001

Re: [jclouds] Backport JCLOUDS-470 to 1.7.x (#294)

2014-02-14 Thread Andrew Phillips
Pending PR builders, +1 - looks good to me! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/294#issuecomment-35133169

Re: [jclouds] Add keystone user add and delete methods. (#290)

2014-02-14 Thread Andrew Phillips
jclouds » jclouds #845 UNSTABLE Real [test failures](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds.api$openstack-keystone/845/testReport/junit/org.jclouds.openstack.keystone.v2_0.features/UserApiExpectTest/testCreateUser/) here. --- Reply to this email directly or

Re: [jclouds-site] Adding a link to the 1.7.1 release notes (#57)

2014-02-16 Thread Andrew Phillips
Probably best for you to review, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/57#issuecomment-35220310

Re: [jclouds-site] Adding a link to the 1.7.1 release notes (#57)

2014-02-16 Thread Andrew Phillips
![image](https://f.cloud.github.com/assets/223702/2181765/41c8442a-9765-11e3-8ff6-b7f8d73cf7c5.png) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/57#issuecomment-35220444

Re: [jclouds-site] Adding a link to the 1.7.1 release notes (#57)

2014-02-17 Thread Andrew Phillips
Thanks for merging, @nacx! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/57#issuecomment-35266050

Re: [jclouds-site] User guides (a7fd029)

2014-02-17 Thread Andrew Phillips
Trailing `//` in the code sample? @nacx: Or are these intentional? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/commit/a7fd029fc94238d3c84c3ade675578ca9883920f#commitcomment-5396812

Re: [jclouds-site] User guides (a7fd029)

2014-02-17 Thread Andrew Phillips
Same trailing `//` here. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/commit/a7fd029fc94238d3c84c3ade675578ca9883920f#commitcomment-5396824

Re: [jclouds-site] User guides (a7fd029)

2014-02-17 Thread Andrew Phillips
Broken link. Still to come? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/commit/a7fd029fc94238d3c84c3ade675578ca9883920f#commitcomment-5396830

Re: [jclouds-site] User guides (a7fd029)

2014-02-17 Thread Andrew Phillips
Broken link. Still to come? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/commit/a7fd029fc94238d3c84c3ade675578ca9883920f#commitcomment-5396832

Re: [jclouds-site] User guides (a7fd029)

2014-02-17 Thread Andrew Phillips
Broken link. Still to come? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/commit/a7fd029fc94238d3c84c3ade675578ca9883920f#commitcomment-5396833

Re: [jclouds-site] User guides (a7fd029)

2014-02-17 Thread Andrew Phillips
Company is now called Chef --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/commit/a7fd029fc94238d3c84c3ade675578ca9883920f#commitcomment-5396913

  1   2   3   4   5   6   7   8   9   10   >