Re: [jclouds-labs] Cleanup round 1 of azurecompute: Output value types. (#92)

2014-10-21 Thread Daniel Estévez
- /** -* Specifies the name for the virtual machine. The name must be unique -* within Windows Azure. -*/ - private final String roleName; + /** Specifies the name for the virtual machine. The name must be unique within Windows Azure. */ Actually this is not true.

Re: [jclouds/jclouds-labs] Checks existence of node before getting SecurityGroups and Images (#360)

2017-02-16 Thread Daniel Estévez
@danielestevez pushed 1 commit. c24e690 Changes log message -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/360/files/a79e560de96d32abaf8bf52a2b093bc39523687a..c24e690f26b4e3fae5b3663f129f8e4bdcfa20b7

Re: [jclouds/jclouds-labs] Checks existence of node before getting SecurityGroups and Images (#360)

2017-02-09 Thread Daniel Estévez
@danielestevez pushed 1 commit. a79e560 Returns null image if node not found -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] Checks existence of node before getting SecurityGroups and Images (#360)

2017-02-13 Thread Daniel Estévez
@danielestevez pushed 1 commit. 92d3336 Overrides tests -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/360/files/a79e560de96d32abaf8bf52a2b093bc39523687a..92d3336bc6fb3b2ff61b17c1a64ba1d5030dd7c2

Re: [jclouds/jclouds-labs] Adds new available Azure locations (#362)

2017-02-16 Thread Daniel Estévez
:up: Where did you get those locations info? https://azure.microsoft.com/en-ca/regions/ doesn't show them -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-labs] Adds new available Azure locations (#362)

2017-02-16 Thread Daniel Estévez
@danielestevez pushed 1 commit. 0442b71 Adds missing location code -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/362/files/13488ee3674dd22e1bcbef1c11c908042e10e96b..0442b7125cfbfe29612f7176663d7efc7a39fcb6

[jclouds/jclouds-labs] Adds new available Azure locations (#362)

2017-02-15 Thread Daniel Estévez
Returned by Location API but not whitelisted yet reference https://azure.microsoft.com/en-ca/regions/ You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/362 -- Commit Summary -- * Adds new available Azure locations according to

[jclouds/jclouds-labs] Fixes error in availabilitySetName field (#361)

2017-02-15 Thread Daniel Estévez
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/361 -- Commit Summary -- * Fixes error in availabilitySetName field -- File Changes -- M

[jclouds/jclouds-labs] Checks existence of node before getting SecurityGroups and Images (#360)

2017-02-09 Thread Daniel Estévez
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/360 -- Commit Summary -- * Checks existence of node before getting SecurityGroups and Images -- File Changes -- M

Re: [jclouds/jclouds-labs] Checks existence of node before getting SecurityGroups and Images (#360)

2017-02-17 Thread Daniel Estévez
@danielestevez pushed 1 commit. fee81c5 Fixes missing log message -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/360/files/c24e690f26b4e3fae5b3663f129f8e4bdcfa20b7..fee81c55eff009ed917785036decd884ca105b50

Re: [jclouds/jclouds-labs] Checks existence of node before getting SecurityGroups and Images (#360)

2017-02-17 Thread Daniel Estévez
danielestevez commented on this pull request. > @@ -123,8 +123,7 @@ public Image call() throws Exception { Image image = resourceDefinitionToImage.create(cloneTemplate.getSourceNodeId(), cloneTemplate.getName()) .apply(definitions.get(0)); -

Re: [jclouds/jclouds-labs] Checks existence of node before getting SecurityGroups and Images (#360)

2017-02-17 Thread Daniel Estévez
@danielestevez pushed 1 commit. fe3a13b Fixes log message again -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/360/files/fee81c55eff009ed917785036decd884ca105b50..fe3a13bd07d2927ab4f69c8e1ce8ee451c048857

Re: [jclouds/jclouds-labs] JCLOUDS-1254 Filters storage account by current available locations (#370)

2017-03-17 Thread Daniel Estévez
danielestevez commented on this pull request. > @@ -16,10 +16,23 @@ */ package org.jclouds.azurecompute.arm.compute; +import static com.google.common.base.Preconditions.checkState; +import static com.google.common.collect.Iterables.contains; +import static

[jclouds/jclouds-labs] JCLOUDS-1254 Filters storage account by current available locations (#370)

2017-03-17 Thread Daniel Estévez
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/370 -- Commit Summary -- * JCLOUDS-1254 Filters storage account by current available locations -- File Changes -- M

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-03-20 Thread Daniel Estévez
danielestevez commented on this pull request. > + public void deleteImageResourceDoesNotExist() { + assertNull(api().delete(imageName)); + } + + @Test(dependsOnMethods = "deleteImageResourceDoesNotExist") + public void CreateVirtualMachineImageFromExistingVM() { + String id =

Re: [jclouds/jclouds-labs] [JCLOUDS-1257] Initial support ManagedDataDisks (#372)

2017-03-20 Thread Daniel Estévez
danielestevez commented on this pull request. > +import org.jclouds.rest.annotations.ResponseParser; +import org.jclouds.rest.annotations.SelectJson; +import org.jclouds.rest.binders.BindToJsonPayload; + +@Path("/resourcegroups/{resourcegroup}/providers/Microsoft.Compute/images")

Re: [jclouds/jclouds-labs] Implements metrics and metricdefinitions API (#396)

2017-06-27 Thread Daniel Estévez
danielestevez commented on this pull request. > +/** + * + */ +@AutoValue +public abstract class MetricData { + + /** +* The timestamp for the metric value in ISO 8601 format. +*/ + public abstract Date timeStamp(); + + /** +* The average value in the time range +*/ +

Re: [jclouds/jclouds-labs] Implements metrics and metricdefinitions API (#396)

2017-06-27 Thread Daniel Estévez
@danielestevez pushed 1 commit. d353bbc Returns numeric data as Double/Long -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] Implements metrics and metricdefinitions API (#396)

2017-06-26 Thread Daniel Estévez
@danielestevez pushed 1 commit. 9312229 Addresses comments by @nacx -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/396/files/44cd5b8fe62b6bae060b3995c438533cfc249dc2..9312229b35c40debb33e66e324958102348dc751

[jclouds/jclouds-labs] Fixes India regions to their actual name (#392)

2017-05-22 Thread Daniel Estévez
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/392 -- Commit Summary -- * Fixes India regions to their actual name -- File Changes -- M azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/Region.java (6)

Re: [jclouds/jclouds-labs] Implements metrics and metricdefinitions API (#396)

2017-06-16 Thread Daniel Estévez
danielestevez commented on this pull request. > +* The metrics API includes operations to get insights into entities > within your +* subscription. +* +* @see https://docs.microsoft.com/en-us/rest/api/monitor/metrics;>docs +*/ + @Delegate + MetricsApi

Re: [jclouds/jclouds-labs] Implements metrics and metricdefinitions API (#396)

2017-06-16 Thread Daniel Estévez
danielestevez commented on this pull request. > + * A Metric definition for a resource + */ +@AutoValue +public abstract class MetricDefinition { + + @Nullable + public abstract String resourceid(); + + public abstract MetricDefinition.MetricName name(); + + @Nullable + public

Re: [jclouds/jclouds-labs] Implements metrics and metricdefinitions API (#396)

2017-06-16 Thread Daniel Estévez
danielestevez commented on this pull request. > +/** + * + */ +@AutoValue +public abstract class MetricData { + + /** +* The timestamp for the metric value in ISO 8601 format. +*/ + public abstract Date timeStamp(); + + /** +* The average value in the time range +*/ +

[jclouds/jclouds-labs] Implements metrics and metricdefinitions API (#396)

2017-06-13 Thread Daniel Estévez
- https://docs.microsoft.com/en-us/rest/api/monitor/metrics - https://docs.microsoft.com/en-us/rest/api/monitor/metricdefinitions You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/396 -- Commit Summary -- * Implements metrics and

Re: [jclouds/jclouds] Removes check for group name when deleting (#1202)

2018-05-04 Thread Daniel Estévez
Checked again: The problem happens when trying to security groups from nodes not created by jclouds and therefore, not respecting naming convention (using Upper case breaks

Re: [jclouds/jclouds] JCLOUDS-1294: Attempt to retry RetryableErrors in Azure ARM (#1203)

2018-05-04 Thread Daniel Estévez
Well, i can confirm it fixes the failing tests :clap: I'll run the full suite of LiveTests to see if i find more problems -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Removes check for group name when deleting (#1202)

2018-05-07 Thread Daniel Estévez
For the first point, i supposed it made sense to delete only those "implicit" orphaned groups created by jclouds, but it's true it'd delete groups from the subscription so adding a tag would make this process indeed more robust. For the validator, i thought there was maybe a reason to use a

[jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-14 Thread Daniel Estévez
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1207 -- Commit Summary -- * Uses default password with conflictive characters -- File Changes -- M

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-14 Thread Daniel Estévez
cc @demobox -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1207#issuecomment-388958574

Re: [jclouds/jclouds] Fixes Run SSH script for passwords with special characters (#1205)

2018-05-14 Thread Daniel Estévez
danielestevez commented on this pull request. > @@ -103,7 +103,7 @@ public void simpleRootTestWithSudoPassword() { expect(sshClient.getUsername()).andReturn("tester"); expect(sshClient.getHostAddress()).andReturn("somewhere.example.com"); expect( -

Re: [jclouds/jclouds] Fixes Run SSH script for passwords with special characters (#1205)

2018-05-14 Thread Daniel Estévez
danielestevez commented on this pull request. > @@ -112,7 +112,8 @@ protected ExecResponse runCommand(String command) { public String execAsRoot(String command) { if (node.getCredentials().identity.equals("root")) { } else if (node.getCredentials().shouldAuthenticateSudo()) {

[jclouds/jclouds] Fixes Run SSH script for passwords with special characters (#1205)

2018-05-11 Thread Daniel Estévez
Passwords can contain special characters as parentheses, password parameter should be wrapped in '' to avoid this syntax errors in SSH command You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1205 -- Commit Summary -- * Fixes Run SSH

Re: [jclouds/jclouds] Fixes Run SSH script for passwords with special characters (#1205)

2018-05-11 Thread Daniel Estévez
It's just a sometimes since these kind of characters can be included in password random generator https://github.com/danielestevez/jclouds/blob/9fef6ed06b027c1525579c88b58aa9f5833687fd/core/src/main/java/org/jclouds/util/PasswordGenerator.java#L65 -- You are receiving this because you are

[jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

2018-05-11 Thread Daniel Estévez
To avoid problems with the cache, and specifically running the AzureComputeImageExtensionLiveTest suite. ARM is quite slow and it takes usually more than one minute (default value) for certain operations. The testImageIsCachedAfterBeingCreated in that suite fails often since it takes longer

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

2018-05-11 Thread Daniel Estévez
Sorry about that, fixed -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1206#issuecomment-388499413

Re: [jclouds/jclouds] Removes check for group name when deleting (#1202)

2018-05-04 Thread Daniel Estévez
Ok! I'll take a look at it again. When i tried it it was trying to remove a security group already existing in the user subscription, maybe the problem is there -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1418: Add missing PowerState values (#1208)

2018-05-15 Thread Daniel Estévez
LGTM we need to cover these new states. :+1: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1208#issuecomment-389181232

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-17 Thread Daniel Estévez
Good to know! Then i guess it's again another problem with the caseInsensitive feature since i always try in one of the problematic regions **CanadaEast** Will investigate further -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-17 Thread Daniel Estévez
Some context about what @nacx is talking about https://stackoverflow.com/questions/50068324/azure-arm-api-returns-locations-with-inconsistent-case It affects also other of the new regions (not only CanadaEast) and working on it we discovered some unrelated issues like this one with the default

Re: [jclouds/jclouds] Fixes assert for IpPermissions collection (#1209)

2018-05-16 Thread Daniel Estévez
Fail!... and fixed! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1209#issuecomment-389517489

[jclouds/jclouds] Fixes assert for IpPermissions collection (#1209)

2018-05-15 Thread Daniel Estévez
Azure does not return IpPermissions in order so this test fails randomly You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1209 -- Commit Summary -- * Fixes assert for IpPermissions collection -- File Changes -- M

Re: [jclouds/jclouds] Removes check for group name when deleting (#1202)

2018-05-23 Thread Daniel Estévez
This simple validator should work https://github.com/jclouds/jclouds/pull/1213 and we could close this PR -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1202#issuecomment-391501389

[jclouds/jclouds] Adds new more relaxed validator for Azure entities (#1213)

2018-05-23 Thread Daniel Estévez
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1213 -- Commit Summary -- * Adds new more relaxed validator for Azure entities -- File Changes -- A

Re: [jclouds/jclouds] Adds new more relaxed validator for Azure entities (#1213)

2018-05-24 Thread Daniel Estévez
Added a test! (and fixed an error message by the way) with all the main cases i could think of @nacx Also, i added this class under _org.jclouds.azurecompute.arm.config.*_ not sure if it's the best place so feel free to suggest any other one -- You are receiving this because you are

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-16 Thread Daniel Estévez
danielestevez commented on this pull request. > + // Otherwise fallback to the image default credentials strategy + if (template instanceof CloneImageTemplate) { + final CloneImageTemplate cloneImageTemplate = (CloneImageTemplate) template; + future =

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-16 Thread Daniel Estévez
Tried and fixes the issues with the missing credentials in _testSpawnNodeFromImage_ :+1: However _testImageIsRemovedFromCacheAfterDeletion_ still fails it _testSpawnNodeFromImage_ is enabled but that's a different issue. -- You are receiving this because you are subscribed to this thread.

Re: [jclouds/jclouds] Removes check for group name when deleting (#1202)

2018-05-16 Thread Daniel Estévez
About this, i started to implement a custom validation for ARM here extending current interfaces https://github.com/danielestevez/jclouds/commits/groupNamingValidation Still not sure about the implementation, and specially naming but there it is if you want to take a look -- You are receiving

[jclouds/jclouds] Fixes/adds fields primary for NetworkInterfaceCard (#1217)

2018-06-14 Thread Daniel Estévez
* Field 'primary' was missing in NetworkInterfaceCardProperties * Field 'primary' was misplaced in IpConfiguration instead of IpConfigurationProperties This causes problems when using the provider to configure multiple IPs per NIC and multiple NICs per VirtualMachine Check

[jclouds/jclouds] Adds minor improvements to readability (#1215)

2018-05-29 Thread Daniel Estévez
Based on suggestions by @demobox in original PR https://github.com/jclouds/jclouds/pull/1213 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1215 -- Commit Summary -- * Adds minor improvements to readability -- File Changes -- M

[jclouds/jclouds] Checks network availability before working with created networks (#1214)

2018-05-29 Thread Daniel Estévez
This affected (at least) [AzureComputeImageExtensionLiveTest](https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/compute/extensions/AzureComputeImageExtensionLiveTest.java) running in some regions. (worked in North/West Europe but

Re: [jclouds/jclouds] Adds new more relaxed validator for Azure entities (#1213)

2018-05-29 Thread Daniel Estévez
Thanks for the suggestions @demobox, PR was already merged but i added those improvements here https://github.com/jclouds/jclouds/pull/1215 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Adds minor improvements to readability (#1215)

2018-05-29 Thread Daniel Estévez
@danielestevez pushed 1 commit. 2fd4f07 changes exception text for readability -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] Adds minor improvements to readability (#1215)

2018-05-29 Thread Daniel Estévez
danielestevez commented on this pull request. > @@ -54,7 +55,7 @@ private CharMatcher getAcceptableRange() { protected IllegalArgumentException exception(String name, String reason) { return new IllegalArgumentException( -String.format("Object '%s' doesn't match Azure

Re: [jclouds/jclouds] Adds minor improvements to readability (#1215)

2018-05-30 Thread Daniel Estévez
I think so! I opened the PR against 2.1.x as in the previous one but @nacx will surely merge it to 2.1.x and master -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jclouds/jclouds] Implements VirtualMachineAPI deallocate operation (#1220)

2018-06-29 Thread Daniel Estévez
https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/deallocate You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1220 -- Commit Summary -- * Implements VirtualMachineAPI deallocate operation -- File Changes -- M

[jclouds/jclouds] Protects from NPE since SecurityGroup.getLocation() is nullable (#1201)

2018-05-03 Thread Daniel Estévez
Right now running the AzureComputeSecurityGroupExtensionLiveTest will fail with a NPE if you have any securityGroup in you subscription in any location not included in Set locations You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1201

[jclouds/jclouds] Removes check for group name when deleting (#1202)

2018-05-03 Thread Daniel Estévez
This currently fails if you use a securityGroup with Upper case letters in your subscription. Naming check shouldn't be needed in a delete operation. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1202 -- Commit Summary -- * Removes

[jclouds/jclouds] Adds new Generally Available azure locations for Australia and France (#1219)

2018-06-21 Thread Daniel Estévez
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1219 -- Commit Summary -- * Adds new Generally Available azure locations for Australia and France -- File Changes -- M

Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance types (#1233)

2018-07-31 Thread Daniel Estévez
Isn't this the same PR as https://github.com/jclouds/jclouds/pull/1232 but with wrong checkstyle? If i'm right, could you please close this one? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1387: Add support for c5 instance types in AWS ec2 (#1232)

2018-07-31 Thread Daniel Estévez
danielestevez approved this pull request. Thanks @VRanga000 the code looks good for those new profiles! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance types (#1233)

2018-07-31 Thread Daniel Estévez
Sorry! Got it now. Please review the checkstyle since it seems to be breaking the build -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1233#issuecomment-409394722

Re: [jclouds/jclouds] JCLOUDS-1387: Add support for c5 instance types in AWS ec2 (#1232)

2018-08-01 Thread Daniel Estévez
Pushed to [master](https://github.com/jclouds/jclouds/commit/982c6bea0252689c23628079ab66998ac2a36aa9) and [2.1.x](https://github.com/jclouds/jclouds/commit/0ee68a5f836a654619a5bbf635e19e1d478f058e)! Thanks @VRanga000 !! -- You are receiving this because you are subscribed to this thread.

Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance types (#1233)

2018-08-01 Thread Daniel Estévez
danielestevez approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1233#pullrequestreview-142542476

Re: [jclouds/jclouds] JCLOUDS-1387: Add support for c5 instance types in AWS ec2 (#1232)

2018-08-01 Thread Daniel Estévez
Closed #1232. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1232#event-1766300928

Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance types (#1233)

2018-08-01 Thread Daniel Estévez
Closed #1233. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1233#event-1766308008

Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance types (#1233)

2018-08-01 Thread Daniel Estévez
Pushed to [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e54312aa) and [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cf672337) !! Thanks @VRanga000 !! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-08 Thread Daniel Estévez
danielestevez commented on this pull request. > } catch (Exception ex) { logger.warn(ex, "Error cleaning up resources for node %s", deadNode); } + + List securityGroups = cleanupResources.findOrphanedSecurityGroups(regionAndId.regionId(),

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-08 Thread Daniel Estévez
danielestevez commented on this pull request. > } catch (Exception ex) { logger.warn(ex, "Error cleaning up resources for node %s", deadNode); } + + List securityGroups = cleanupResources.findOrphanedSecurityGroups(regionAndId.regionId(),

Re: [jclouds/jclouds-site] draft release notes 2.1.1 (#217)

2018-08-10 Thread Daniel Estévez
danielestevez commented on this pull request. > +* [JCLOUDS-1410] - SoftLayer cannot provision with private image +* [JCLOUDS-1422] - LocalBlobStore.list ignores recursive flag when prefix set +* [JCLOUDS-1427] - NPE when deserializing Elastic IPs that have tags +* [JCLOUDS-1433] -

Re: [jclouds/jclouds-site] draft release notes 2.1.1 (#217)

2018-08-15 Thread Daniel Estévez
danielestevez commented on this pull request. > +## Credits + +jclouds would like to thank everyone who contributed time and effort in order to make this release happen: + +* [Vikas Rangarajan](https://github.com/VRanga000) for his contribution to the new instance types supported in the AWS

Re: [jclouds/jclouds-site] draft release notes 2.1.1 (#217)

2018-08-14 Thread Daniel Estévez
danielestevez commented on this pull request. > +1. [Known Issues](#knownissues) +1. [Credits](#credits) +1. [Test Results](#test) + +## Introduction + +Apache jclouds 2.1.1 is the first bugfix release after jclouds 2.1 and comes with several bugfixes and performance improvements. +You can

Re: [jclouds/jclouds-site] draft release notes 2.1.1 (#217)

2018-08-10 Thread Daniel Estévez
danielestevez commented on this pull request. > +1. [Introduction](#intro) +1. [Release Highlights](#highlights) +1. [Known Issues](#knownissues) +1. [Credits](#credits) +1. [Test Results](#test) + +## Introduction + +Apache jclouds 2.1.1 is the first bugfix release after jclouds 2.1 and comes

Re: [jclouds/jclouds-site] draft release notes 2.1.1 (#217)

2018-08-10 Thread Daniel Estévez
danielestevez commented on this pull request. > +* [JCLOUDS-1410] - SoftLayer cannot provision with private image +* [JCLOUDS-1422] - LocalBlobStore.list ignores recursive flag when prefix set +* [JCLOUDS-1427] - NPE when deserializing Elastic IPs that have tags +* [JCLOUDS-1433] -

Re: [jclouds/jclouds-site] draft release notes 2.1.1 (#217)

2018-08-14 Thread Daniel Estévez
@danielestevez pushed 1 commit. a7a5604 Adds more JIRA issues fixed and mentions contributors -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-08 Thread Daniel Estévez
danielestevez commented on this pull request. > } catch (Exception ex) { logger.warn(ex, "Error cleaning up resources for node %s", deadNode); } + + List securityGroups = cleanupResources.findOrphanedSecurityGroups(regionAndId.regionId(),

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS (#443)

2018-08-08 Thread Daniel Estévez
danielestevez commented on this pull request. > +import org.jclouds.rest.annotations.RequestFilters; +import org.jclouds.rest.annotations.ResponseParser; +import org.jclouds.rest.annotations.Transform; + +import javax.inject.Inject; +import javax.inject.Named; +import javax.inject.Singleton;

Re: [jclouds/jclouds] JCLOUDS-1441: Enables support for ARM regions in China (#1237)

2018-09-04 Thread Daniel Estévez
@danielestevez pushed 1 commit. 4511cf1 Adds unit test for china oauth endpoint check -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1441: Enables support for ARM regions in China (#1237)

2018-09-04 Thread Daniel Estévez
@danielestevez pushed 1 commit. f1087b6 Adapted Endpoints for APIs GraphRBAC and Vault -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1441: Enables support for ARM regions in China (#1237)

2018-09-06 Thread Daniel Estévez
Squashed and merged to [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/951b6b44) and [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a07ab5a9) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1441: Enables support for ARM regions in China (#1237)

2018-09-06 Thread Daniel Estévez
Closed #1237. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1237#event-1830625159

[jclouds/jclouds] JCLOUDS-1441: Enables support for ARM regions in China (#1237)

2018-08-29 Thread Daniel Estévez
- Only one blocker hardcoded was fixed in AzureComputeHttpApiModule.java - Endpoints for GraphAPI and VaultAPI are also hardcoded but we could deal with this as separate PRs (i couldn't make this work with Guice) - Also added two new China regions to keep the plugin up to date. Just with this

[jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

2018-07-09 Thread Daniel Estévez
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1225 -- Commit Summary -- * Adds listAll to PublicIPAddressAPI * Adds listAll to NetworkInterfaceCardApi -- File Changes -- M

Re: [jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

2018-07-10 Thread Daniel Estévez
danielestevez commented on this pull request. > @@ -119,6 +119,16 @@ public void listPublicIPAddresses() { assertTrue(ipList.size() > 0); } + @Test(groups = "live", dependsOnMethods = "createPublicIPAddress") + public void listAllPublicIPAddresses() { same :) -- You are

Re: [jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

2018-07-10 Thread Daniel Estévez
danielestevez commented on this pull request. > @SelectJson("value") @GET @Fallback(EmptyListOnNotFoundOr404.class) List list(); + @Named("networkinterfacecard:list_all") + @Path("/providers/Microsoft.Network/networkInterfaces") + @SelectJson("value") + @GET +

Re: [jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

2018-07-10 Thread Daniel Estévez
danielestevez commented on this pull request. > + String path = String + .format("/subscriptions/%s/providers/Microsoft.Network/networkInterfaces?%s", subscriptionid, apiVersion); + + assertSent(server, "GET", path); + assertTrue(nicList.size() == 3); +

Re: [jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

2018-07-10 Thread Daniel Estévez
danielestevez commented on this pull request. > @@ -105,6 +105,12 @@ public void listNetworkInterfaceCards() { assertTrue(nicList.contains(api().get(nicName))); } + @Test(dependsOnMethods = "createNetworkInterfaceCard") + public void listAllNetworkInterfaceCards() { Good

Re: [jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

2018-07-10 Thread Daniel Estévez
@danielestevez pushed 3 commits. ebf4a1c Addresses comments on tests 4ce685a Removes resourceGroup parameter from NetworkInterfaceCardApi ca677c6 Removes resourceGroup parameter from PublicIPAddressApi -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

2018-07-10 Thread Daniel Estévez
danielestevez commented on this pull request. > @SelectJson("value") @GET @Fallback(EmptyListOnNotFoundOr404.class) List list(); + @Named("networkinterfacecard:list_all") + @Path("/providers/Microsoft.Network/networkInterfaces") + @SelectJson("value") + @GET +

Re: [jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

2018-07-10 Thread Daniel Estévez
Removed previous solution and added the optional/nullable resourcegroup parameter as solution! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1225#issuecomment-403970005

Re: [jclouds/jclouds] Adds listall methods to NetworkInterfaceCardApi and PublicIPAddressApi (#1225)

2018-07-10 Thread Daniel Estévez
danielestevez commented on this pull request. > @SelectJson("value") @GET @Fallback(EmptyListOnNotFoundOr404.class) List list(); + @Named("networkinterfacecard:list_all") + @Path("/providers/Microsoft.Network/networkInterfaces") + @SelectJson("value") + @GET +

[jclouds/jclouds] Adds missing virtualMachine field to NetworkInterfaceCardProperties (#1229)

2018-07-11 Thread Daniel Estévez
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1229 -- Commit Summary -- * Adds missing virtualMachine field to NetworkInterfaceCardProperties -- File Changes -- M

[jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

2018-07-12 Thread Daniel Estévez
https://docs.microsoft.com/en-us/rest/api/virtualnetwork/virtualnetworks/checkipaddressavailability You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1231 -- Commit Summary -- * Adds method checkIpAvailability to VirtualNetworkApi --

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

2018-07-12 Thread Daniel Estévez
danielestevez commented on this pull request. > @@ -73,4 +74,11 @@ VirtualNetwork > createOrUpdate(@PathParam("virtualnetworkname") String virtualnet @DELETE @ResponseParser(FalseOn204.class) boolean delete(@PathParam("virtualnetworkname") String virtualnetworkname); + +

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

2018-07-12 Thread Daniel Estévez
danielestevez commented on this pull request. > + public void checkIpAvailable() throws InterruptedException { + server.enqueue(jsonResponse("/ipavailable.json")); + + final VirtualNetworkApi vnApi = api.getVirtualNetworkApi(resourcegroup); + IpAddressAvailabilityResult

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

2018-07-12 Thread Daniel Estévez
@danielestevez pushed 1 commit. 37ce4a7 Addresses @nacx comments -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1231/files/427fcdb34f6e8698e2c0ad218f65aac4a8964ef8..37ce4a7d29ad54d9b9436e668336bed07a998a7f

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

2018-07-12 Thread Daniel Estévez
danielestevez commented on this pull request. > VirtualNetwork vn = api().createOrUpdate(virtualNetworkName, LOCATION, null, virtualNetworkProperties); + resourceAvailable.apply(new Supplier() { + @Override + public Provisionable get() { +

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

2018-07-12 Thread Daniel Estévez
danielestevez commented on this pull request. > + */ +package org.jclouds.azurecompute.arm.domain; + +import java.util.List; + +import org.jclouds.javax.annotation.Nullable; +import org.jclouds.json.SerializedNames; + +import com.google.auto.value.AutoValue; +import

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

2018-07-12 Thread Daniel Estévez
@danielestevez pushed 1 commit. e71ce96 Fixed formatter maximum line width. Removed redundantTest -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] Adds method checkIpAvailability to VirtualNetworkApi (#1231)

2018-07-12 Thread Daniel Estévez
Squashed and ready to merge, thanks @nacx ! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1231#issuecomment-404673071

Re: [jclouds/jclouds] Implements VirtualMachineAPI deallocate operation (#1220)

2018-07-09 Thread Daniel Estévez
@danielestevez pushed 1 commit. cb8881b Adds missing mock test -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1220/files/b76a2b6ecf997e4214fa7990b3d58d1f1b095043..cb8881bbac7f8fc448acd59772c00891814d7cea

  1   2   >