Re: [jclouds/jclouds] Remove hardcoded content size for personality in Openstack Nova (#1012)

2016-09-26 Thread Zack Shoylev
I wouldn't be opposed, though I don't think refactoring old code to remove such checks is strictly necessary or high priority (unless actually needed). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Remove hardcoded content size for personality in Openstack Nova (#1012)

2016-09-23 Thread arvindn05
in that case, should we also remove the check for maximum file path size being 255 bytes? I left that in because that is not configurable in openstack. checkArgument( path.getBytes().length < 255, String.format("maximum length of path is 255 bytes. Path specified

Re: [jclouds/jclouds] Remove hardcoded content size for personality in Openstack Nova (#1012)

2016-09-23 Thread Zack Shoylev
This is a good change. We should be moving toward server-side validation in general. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1012#issuecomment-249228831

Re: [jclouds/jclouds] Remove hardcoded content size for personality in Openstack Nova (#1012)

2016-09-23 Thread Ignasi Barrera
Closed #1012. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1012#event-800048297

Re: [jclouds/jclouds] Remove hardcoded content size for personality in Openstack Nova (#1012)

2016-09-22 Thread arvindn05
@nacx Please review when you get a chance https://issues.apache.org/jira/browse/JCLOUDS-1175 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1012#issuecomment-249039546

[jclouds/jclouds] Remove hardcoded content size for personality in Openstack Nova (#1012)

2016-09-22 Thread arvindn05
Fix issue JCLOUDS-1175 by removing hardcoded content sizes in Openstack Nova API You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1012 -- Commit Summary -- * Remove hardcoded limitation of content size in Openstack Nova