Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)
@alibazlamit pushed 1 commit. 3ebda7e test fix -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431/files/536b9a976929ab3aad39b5756aec955d6f299f16..3ebda7edf3007ba25dfa23c3cf926cbdc2573b71
Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)
@alibazlamit pushed 1 commit. 536b9a9 Add baremetal logic to ComputeServiceAdapter -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431/files/a7553ae71c1064ac5a25fe3efb06fa60782b885d..536b9a976929ab3aad39b5756aec955d6f299f16
Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)
Not familiar with the oneandone API but looks like `baremetal` is another servertype for server creation. If this is correct, then we could either introduce a OneAndOneTemplateOption for serverType or try to infer it from hardwareProfiles if this additional flag is available. Makes sense? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-365719651
Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)
I am sorry for the confusion, but there was a question in my previous comment, something that i would like to add to the PR before we merge it. Could you please take a look at it and let me know if you can maybe point me towards a solution. Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-365717821
Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)
Thanks @alibazlamit for the summary. Would you mind to copy that into a jira issue as described at point 2 at https://cwiki.apache.org/confluence/display/JCLOUDS/How+to+Contribute Ideally you can rename the PR using the jira issue I'd. That would hugely help us to manage the project.Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-365716228
Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)
@andreaturli one main feature that this PR is introducing is the Bare-metal Servers, now i have implemented that as a feature but it is not integrated with the compute API. Basically there is a new property introduced `server_type` which defaults to `cloud` or could be `baremetal`, do you have any idea/examples where you can choose the server type when building a template, i know that with templates you can choose which images to use and what hardware goes, but how can we introduce choosing a `baremetal` or `cloud` server type? Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-365711350
Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)
thanks @alibazlamit could you please open a jira issue that describes the rationale for this PR? Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-365676093
Re: [jclouds/jclouds-labs] Oneandone baremetal update (#431)
Compute test results : https://gist.github.com/alibazlamit/fab05a5e3235be8202f34c627d8bdc65 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-365646226
[jclouds/jclouds-labs] Oneandone baremetal update (#431)
This PR holds the latest updates in the 1&1 API You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/431 -- Commit Summary -- * Baremetal update * updates * Baremetal update -- File Changes -- M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/OneAndOneApi.java (4) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/OneAndOneProviderMetadata.java (2) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/compute/OneandoneComputeServiceAdapter.java (128) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/compute/config/OneAndOneComputeServiceContextModule.java (25) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/compute/function/ServerToNodeMetadata.java (4) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/compute/function/SingleServerApplianceToImage.java (2) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/compute/strategy/CleanupResources.java (7) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/config/OneAndOneProperties.java (1) A oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/BareMetalModel.java (71) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/FirewallPolicy.java (9) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/Hardware.java (9) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/Image.java (28) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/LoadBalancer.java (9) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/MonitoringPolicy.java (8) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/PrivateNetwork.java (9) A oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/RecoveryImage.java (59) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/Server.java (55) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/ServerAppliance.java (13) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/SharedStorage.java (10) A oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/SingleRecoveryImage.java (47) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/SingleServerAppliance.java (40) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/Types.java (18) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/domain/Vpn.java (9) A oneandone/src/main/java/org/apache/jclouds/oneandone/rest/features/RecoveryImageApi.java (55) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/features/ServerApi.java (16) M oneandone/src/main/java/org/apache/jclouds/oneandone/rest/util/ServerApplianceParser.java (15) M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/compute/OneAndOneComputeServiceLiveTest.java (4) M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/compute/function/CustomHardwareToHardwareTest.java (2) M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/compute/function/ServerToNodeMetadataTest.java (4) A oneandone/src/test/java/org/apache/jclouds/oneandone/rest/features/RecoveryImageApiLiveTest.java (61) A oneandone/src/test/java/org/apache/jclouds/oneandone/rest/features/RecoveryImageApiMockTest.java (116) M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/features/ServerApiLiveTest.java (2) M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/features/ServerApiMockTest.java (16) M oneandone/src/test/java/org/apache/jclouds/oneandone/rest/internal/BaseOneAndOneLiveTest.java (4) M oneandone/src/test/resources/compute/image.json (1) M oneandone/src/test/resources/compute/server.json (4) M oneandone/src/test/resources/firewallpolicies/get.json (3) M oneandone/src/test/resources/firewallpolicies/list.json (6) M oneandone/src/test/resources/firewallpolicies/list.options.json (6) M oneandone/src/test/resources/image/get.json (1) M oneandone/src/test/resources/image/list.json (2) M oneandone/src/test/resources/image/list.options.json (1) M oneandone/src/test/resources/loadbalancer/get.json (3) M oneandone/src/test/resources/loadbalancer/list.json (6) M oneandone/src/test/resources/loadbalancer/list.options.json (6) M oneandone/src/test/resources/monitoringpolicy/get.json (3) M oneandone/src/test/resources/monitoringpolicy/list.json (6) M oneandone/src/test/resources/monitoringpolicy/list.options.json (6) M oneandone/src/test/resources/privatenetwork/get.json (1) M oneandone/src/test/resources/privatenetwork/list.json (6) M oneandone/src/test/resources/privatenetwork/list.options.json (6) A oneandone/src/test/resources/recoveryimages/get.json (9) A oneandone/src/test/resources/recoveryimages/recoveryimages.json (41) A oneandone/s
