Closed #1231.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1231#event-1732679475
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/92076d6b) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4d1f64d7). Thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Squashed and ready to merge, thanks @nacx !
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1231#issuecomment-404673071
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1231#pullrequestreview-136854963
@danielestevez pushed 1 commit.
e71ce96 Fixed formatter maximum line width. Removed redundantTest
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
nacx commented on this pull request.
> + public void checkIpAvailable() throws InterruptedException {
+ server.enqueue(jsonResponse("/ipavailable.json"));
+
+ final VirtualNetworkApi vnApi = api.getVirtualNetworkApi(resourcegroup);
+ IpAddressAvailabilityResult checkResult =
danielestevez commented on this pull request.
> + public void checkIpAvailable() throws InterruptedException {
+ server.enqueue(jsonResponse("/ipavailable.json"));
+
+ final VirtualNetworkApi vnApi = api.getVirtualNetworkApi(resourcegroup);
+ IpAddressAvailabilityResult
nacx commented on this pull request.
> + public void checkIpAvailable() throws InterruptedException {
+ server.enqueue(jsonResponse("/ipavailable.json"));
+
+ final VirtualNetworkApi vnApi = api.getVirtualNetworkApi(resourcegroup);
+ IpAddressAvailabilityResult checkResult =
@danielestevez pushed 1 commit.
37ce4a7 Addresses @nacx comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1231/files/427fcdb34f6e8698e2c0ad218f65aac4a8964ef8..37ce4a7d29ad54d9b9436e668336bed07a998a7f
danielestevez commented on this pull request.
>
VirtualNetwork vn = api().createOrUpdate(virtualNetworkName, LOCATION,
null, virtualNetworkProperties);
+ resourceAvailable.apply(new Supplier() {
+ @Override
+ public Provisionable get() {
+
danielestevez commented on this pull request.
> + */
+package org.jclouds.azurecompute.arm.domain;
+
+import java.util.List;
+
+import org.jclouds.javax.annotation.Nullable;
+import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+import
danielestevez commented on this pull request.
> @@ -73,4 +74,11 @@ VirtualNetwork
> createOrUpdate(@PathParam("virtualnetworkname") String virtualnet
@DELETE
@ResponseParser(FalseOn204.class)
boolean delete(@PathParam("virtualnetworkname") String virtualnetworkname);
+
+
nacx commented on this pull request.
> + */
+package org.jclouds.azurecompute.arm.domain;
+
+import java.util.List;
+
+import org.jclouds.javax.annotation.Nullable;
+import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+import
13 matches
Mail list logo
