Please reopen against apache/jclouds if this is still relevant.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1240#issuecomment-663855829
Closed #1240.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1240#event-3586274056
@nakomis does this pull request need anything to move forward?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1240#issuecomment-458261013
nacx commented on this pull request.
> @@ -171,9 +216,12 @@ public boolean cleanupSecurityGroupIfOrphaned(String
> resourceGroup, String group
logger.debug(">> deleting orphaned security group %s from
%s...", name, resourceGroup);
try {
> Hi, thanks for the feedback. I've addressed a couple of the comments above,
> and pushed a couple of changes to address the others
Looks like the changes are note pushed?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
danielestevez commented on this pull request.
> @@ -171,9 +216,12 @@ public boolean cleanupSecurityGroupIfOrphaned(String
> resourceGroup, String group
logger.debug(">> deleting orphaned security group %s from
%s...", name, resourceGroup);
try {
Hi, thanks for the feedback. I've addressed a couple of the comments above, and
pushed a couple of changes to address the others
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
nakomis commented on this pull request.
> @@ -231,7 +309,10 @@ private static boolean
> isOrphanedJcloudsAvailabilitySet(AvailabilitySet availabi
}
private boolean deleteVirtualMachine(String group, VirtualMachine
virtualMachine) {
- return
nakomis commented on this pull request.
> @@ -171,9 +216,12 @@ public boolean cleanupSecurityGroupIfOrphaned(String
> resourceGroup, String group
logger.debug(">> deleting orphaned security group %s from
%s...", name, resourceGroup);
try {
nakomis commented on this pull request.
> + // Wait for 404 on the disk api
+ Predicate diskDeleted = new Predicate() {
+ @Override
+ public boolean apply(IdReference input) {
+return api.getDiskApi(input.resourceGroup()).get(input.name()) ==
null;
+
demobox commented on this pull request.
> @@ -110,6 +122,27 @@ protected VirtualMachineInStatePredicateFactory
> provideNodeSuspendedPredicate(fi
timeouts.nodeTerminated, pollPeriod.pollInitialPeriod,
pollPeriod.pollMaxPeriod);
}
+ @Provides
+
danielestevez commented on this pull request.
> @@ -110,6 +122,27 @@ protected VirtualMachineInStatePredicateFactory
> provideNodeSuspendedPredicate(fi
timeouts.nodeTerminated, pollPeriod.pollInitialPeriod,
pollPeriod.pollMaxPeriod);
}
+ @Provides
+
demobox commented on this pull request.
> +import org.jclouds.azurecompute.arm.features.DiskApi;
+import org.jclouds.azurecompute.arm.features.NetworkInterfaceCardApi;
+import org.jclouds.azurecompute.arm.features.NetworkSecurityGroupApi;
+import
demobox commented on this pull request.
> logger.debug(">> the resource group %s is empty. Deleting...",
> group);
- deleted =
resourceDeleted.apply(api.getResourceGroupApi().delete(group));
+ URI uri = api.getResourceGroupApi().delete(group);
+ deleted = uri
demobox commented on this pull request.
> }
}
return deleted;
}
+ private void cleanupVirtualNetworks(String resourceGroupName) {
+ for (VirtualNetwork virtualNetwork :
api.getVirtualNetworkApi(resourceGroupName).list()) {
+ if
demobox commented on this pull request.
> @@ -121,7 +131,17 @@ public boolean cleanupVirtualMachineNICs(VirtualMachine
> virtualMachine) {
PublicIPAddress ip =
api.getPublicIPAddressApi(publicIpResourceGroup).get(publicIpName);
if (ip.tags() != null &&
demobox commented on this pull request.
> @@ -110,6 +122,27 @@ protected VirtualMachineInStatePredicateFactory
> provideNodeSuspendedPredicate(fi
timeouts.nodeTerminated, pollPeriod.pollInitialPeriod,
pollPeriod.pollMaxPeriod);
}
+ @Provides
+
> Thanks, @nakomis! And many thanks for taking care of adding new tests. It's
> highly appreciated!
+1 to that - many thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
nacx commented on this pull request.
Thanks, @nakomis! And many thanks for taking care of adding new tests. It's
highly appreciated!
> @@ -98,7 +109,8 @@ protected VirtualMachineInStatePredicateFactory
> provideVirtualMachineRunningPred
@Named(TIMEOUT_RESOURCE_DELETED)
protected
19 matches
Mail list logo
