Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-17 Thread Andrew Phillips
Thanks for taking care of the merging and cherry-picking, Ignasi!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1207#issuecomment-390093278

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-17 Thread Ignasi Barrera
Closed #1207.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1207#event-1631249749

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-17 Thread Ignasi Barrera
Merged to 
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/bdb9a3af) and 
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/45230c87). Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1207#issuecomment-389768566

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-15 Thread Ignasi Barrera
> does this cover the cases that were discussed in the previous PR?

I think so :) Goot to merge @demobox?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1207#issuecomment-389185657

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-15 Thread Ignasi Barrera
nacx approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1207#pullrequestreview-120256478

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-14 Thread Andrew Phillips
Thanks, Daniel!

@nacx You probably have a bit more context with regard to the overall change - 
does this cover the cases that were discussed in the previous PR?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1207#issuecomment-388966431

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-14 Thread Daniel Estévez
cc @demobox 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1207#issuecomment-388958574