I believe that f6d47b9c0eed7f2fa43f458e2d913305a21938ad supersedes this pull
request. If not, please reopen and rebase.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1180.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1180#event-1574807455
Thanks @wltjr for your help with that!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1180#issuecomment-367092362
Started a [discussion on dev mailing
list](https://lists.apache.org/thread.html/904924028f0ba0e7e14a6f9e3fd52742ac9cd6bb6cdea0296f92fd1c@%3Cdev.jclouds.apache.org%3E)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@demobox Sure I can see about joining the lists. One route is also to keep a
legacy version of jclouds. Like a 2.0.x branch, and then 2.1.x can be jdk 1.8
or newer. Seems odd that they would want a new jclouds, but other stuff old.
Given other stuff likely has bugs fixed in newer updates.
Not
> Thanks for the effort you put on this and for taking your time to have a look
> at it!
@wltjr Just wanted to add my thanks for trying to take this on to Ignasi's.
Agree that the compatibility landscape has changed over time, and that a
discussion about where to draw the line is certainly
I had local builds failing I forced pushed and passed CI. Which is why I was
asking. What is odd is the amount of issues that came up as part of the PR that
did not in my env. I was building it the standard way via maven, where I was
getting the additional modifications. But I feel those are
>This is really a mess, CI gives different failures than locally... What is
>going on with that?
That's not really true. If you run the same build than the CI system, which is
a standard Maven build, you'll get the same failures.
>You cannot support that many versions of guava with API
375 classes need be modified
```
$ grep -l "import com.google.common.base.Predicate;" -r * | wc -l
375
```
I think I will avoid using jclouds and maybe remove from my package. This is
insanity It also is not required in my env, so I am not sure why any of
this is even necessary. This
Maven is horrible and this is taking way to long to fix. I have to fix each
class by class. Maven stops after first failure. In my environment I see all
issues so I can address all at once. This is taking really long and is very
inefficient style of development. About to switch over to looking
For some reason usage is not inheriting [guava
Predicate](https://github.com/google/guava/blob/master/guava/src/com/google/common/base/Predicate.java#L78)
implementation of
[test](https://docs.oracle.com/javase/9/docs/api/java/util/function/Predicate.html#test-T-).
This is really a mess, CI
jclouds builds fine with Java 8. The problem arises when using Java 8 with
Guava >= 21.0. The pull request builder does not force a concrete Guava version
and builds the project with the default jclouds one, that's why the build
succeeded.
You can easily reproduce the issue by passing the
See how that is, think I addressed the last checkstyle issue. If other build
failures let me know and I will address. Though have to make a call on the
guava 22+ vs 19-. From 20 on its not an issue. But supporting <20 and beyond
>=22 will be an issue.
--
You are receiving this because you are
Added patches for compute. To use Guava 22 you will need to switch from
```getHostText``` to ```getHost```. I can make that change but its no going
back. It is deprecated in [guava
20](https://github.com/google/guava/blob/v20.0/guava/src/com/google/common/net/HostAndPort.java#L83)
and [guava
I build it differently straight javac basically. But you can see I am using
[guava
24](https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/jclouds-core/jclouds-core-.ebuild#L34).
All the [jclouds packages I have are updated to guava
@nacx there pushed with changes to that file. It was another static import
issue... Just remove static, add class name to methods, and done. Maybe more
though we will see. I did not run into that for what ever reason. Though the
changes are safe for anyone. Just changing code syntax/semantics,
I do not have that build failure, or I would have addressed it. I can fix in
the same branch and push. Did it build otherwise before? I thought that issue
in Jira was open for it failing under 1.8 or something. Also I am using guava
24 and Java 9. Though I would imagine Java 9 to be pickier. I
I just compiled your branch, with the patch in this PR, with Java 8 and Guava
21.0 (see the command I used to build the project in my previous comment) and
the build fails for the mentioned reason. It does not even try to build compute
or other projects, as it fails to build `core`.
I mean, I
@nacx are you getting that failure with my patches or in general?
Like in the [compute
package](https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/jclouds-compute/jclouds-compute-.ebuild#L55)
I made. I had to change the static imports to regular usage. I guess that
maybe a
Thanks for the PR @wltjr!
I've tried a local build with Java 8 and Guava 21.0 and it is still failing:
```bash
ibarrera@ibarrera:~/src/asf/jclouds $ mvn -version
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
2014-12-14T18:29:23+01:00)
Maven home: /opt/maven
Java version:
Sure I didn't catch that, guess the compiler doesn't care. I am making the
[changes on the
fly](https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/dev-java/jclouds-core/jclouds-core-.ebuild#L55)
at build time so kinda moot to me. But that hopefully explains the failure.
Its nasty
I think it failed due to `checkstyle`. Can you add an space before `Functions`
at lines 102 and 189?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1180#issuecomment-366162733
Not sure why its showing it failed. It seemed to pass all tests and created a
jar.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1180#issuecomment-366151593
23 matches
Mail list logo
