Re: [jclouds/jclouds-labs] JCLOUDS-1183 oneandone-monitoringpolicy-api (#325)

2016-11-03 Thread Ignasi Barrera
Merged to master as [87c54700](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/87c54700). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/325#issuecomment-258093063

Re: [jclouds/jclouds-labs] JCLOUDS-1183 oneandone-monitoringpolicy-api (#325)

2016-11-03 Thread Ignasi Barrera
Closed #325. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/325#event-846079568

Re: [jclouds/jclouds-labs] JCLOUDS-1183 oneandone-monitoringpolicy-api (#325)

2016-11-03 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/325#pullrequestreview-6968179

Re: [jclouds/jclouds-labs] JCLOUDS-1183 oneandone-monitoringpolicy-api (#325)

2016-10-31 Thread alibazlamit
@nacx Fixed and squashed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/325#issuecomment-257287992

Re: [jclouds/jclouds-labs] JCLOUDS-1183 oneandone-monitoringpolicy-api (#325)

2016-10-31 Thread alibazlamit
alibazlamit commented on this pull request. > + MonitoringPolicy updateResult = > monitoringPolicyApi().update(currentPolicy.id(), payload); + + assertNotNull(updateResult); + assertEquals(updateResult.name(), updatedName); + + } + + @Test(dependsOnMethods = "testUpdate") +

Re: [jclouds/jclouds-labs] JCLOUDS-1183 oneandone-monitoringpolicy-api (#325)

2016-10-31 Thread alibazlamit
@alibazlamit pushed 1 commit. da5d9a7 Fixed minor issues -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/325/files/51657897c8190b51401f2fcd503295f832096a74..da5d9a74cd4810e6b064d9f68c14deefa058875f

Re: [jclouds/jclouds-labs] JCLOUDS-1183 oneandone-monitoringpolicy-api (#325)

2016-10-25 Thread Ignasi Barrera
nacx requested changes on this pull request. Most are minor comments. Thanks @alibazlamit! > + +@AutoValue +public abstract class MonitoringPolicy { + + public abstract String id(); + + public abstract String name(); + + @Nullable + public abstract String description(); + + @Nullable +

Re: [jclouds/jclouds-labs] JCLOUDS-1183 oneandone-monitoringpolicy-api (#325)

2016-10-14 Thread alibazlamit
@alibazlamit pushed 1 commit. 922333f changed minor -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/325/files/70e56a498c28294f9bb6a6e448be19aed8cf267d..922333ffefd9ee061c275d02184f30664909a2a7

Re: [jclouds/jclouds-labs] JCLOUDS-1183 oneandone-monitoringpolicy-api (#325)

2016-10-14 Thread alibazlamit
@alibazlamit pushed 1 commit. 70e56a4 minor change -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/325/files/22ec3650d8eee359d8d3433455fbd206e4576a45..70e56a498c28294f9bb6a6e448be19aed8cf267d