Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-21 Thread Andrea Turli 
thx @nacx, merged at 
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/28c56e06)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248632037

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-21 Thread Andrea Turli 
Closed #320.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#event-797411872

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-21 Thread Ignasi Barrera 
nacx approved this pull request.



> private final ProviderMetadata providerMetadata;
+   private final DeploymentToVMDeployment deploymentToVMDeployment;

Better declare and inject it as `Function` to make it 
easier to re-bind.

> @@ -288,7 +279,7 @@ public VMImage getImage(final String id) {
 
@Override
public Iterable listLocations() {
-  final Iterable whiteListZoneName = findWhiteListOfRegions();
+  final Iterable whiteListedRegionNames = findWhiteListOfRegions();

You are parsing this list in several places. Just call this in the constructor 
and assign to a class final variable.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#pullrequestreview-960424

Re: [jclouds/jclouds-labs] separate the DeploymentToVMDeployment to a function (#320)

2016-09-21 Thread Ignasi Barrera 
Just minors. let's merge it, since I plan to open a PR with the minor fixes in 
a while.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/320#issuecomment-248627353