Re: [jclouds] Fixes potentially deleting a null server id. (#323)

2014-03-24 Thread Zack Shoylev 
 I think we should be good just having this change on master..?

Agreed. Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38460370

Re: [jclouds] Fixes potentially deleting a null server id. (#323)

2014-03-21 Thread Andrew Phillips 
 @@ -88,7 +88,9 @@ public void testCreateInAvailabilityZone() {
  Server server = serverApi.get(serverId);
  assertEquals(server.getStatus(), Server.Status.ACTIVE);
   } finally {
 -serverApi.delete(serverId);
 +if (serverId!=null) {

[minor] Add spaces, i.e. `(serverId != null)`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323/files#r10850674

Re: [jclouds] Fixes potentially deleting a null server id. (#323)

2014-03-21 Thread BuildHive 
[jclouds ยป jclouds 
#935](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/935/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38315244

Re: [jclouds] Fixes potentially deleting a null server id. (#323)

2014-03-21 Thread Andrew Phillips 
+1 - good to go for me!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38316357

Re: [jclouds] Fixes potentially deleting a null server id. (#323)

2014-03-21 Thread CloudBees pull request builder plugin 
[jclouds-pull-requests 
#681](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/681/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38316298

Re: [jclouds] Fixes potentially deleting a null server id. (#323)

2014-03-21 Thread CloudBees pull request builder plugin 
[jclouds-java-7-pull-requests 
#1151](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1151/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38316949

Re: [jclouds] Fixes potentially deleting a null server id. (#323)

2014-03-21 Thread Zack Shoylev 
About to merge then

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38318532

Re: [jclouds] Fixes potentially deleting a null server id. (#323)

2014-03-21 Thread Zack Shoylev 
merged

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/323#issuecomment-38336598