[jclouds-pull-requests
#603](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/603/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292#issuecomment-35125311
[jclouds-java-7-pull-requests
#1074](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1074/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292#issuecomment-35125395
[jclouds » jclouds
#844](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/844/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
@@ -175,12 +175,13 @@ public String apply(NodeMetadata in) {
MapString, ? extends NodeMetadata instancesById =
Maps.uniqueIndex(input, instanceId);
ImmutableSet.BuilderNodeMetadata builder =
ImmutableSet.NodeMetadata builder();
+ ListString namesToUse =
if (generateInstanceNames !common.containsKey(Name)) {
for (Map.EntryString, ? extends NodeMetadata entry :
instancesById.entrySet()) {
String id = entry.getKey();
String name;
-if (!nodeNames.isEmpty()) {
- name =
if (generateInstanceNames !common.containsKey(Name)) {
for (Map.EntryString, ? extends NodeMetadata entry :
instancesById.entrySet()) {
String id = entry.getKey();
String name;
-if (!nodeNames.isEmpty()) {
- name =
A question and a minor comment, that's all. +1 - looks good to me. Thanks,
@abayer!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/292#issuecomment-35131001
[jclouds » jclouds
#846](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/846/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
