GitHub user mete0r opened a pull request:
https://github.com/apache/libcloud/pull/1088
Fix Linode DNS records to have 'priority' in extra
## Fix Linode DNS records to have 'priority' in extra field
### Description
Linode DNS Record does not expose 'priority' value on its `extra` field,
which is used in `DNSDriver._get_bind_record_line()`. It's required for MX/SRV
records to be exported with `DNSDriver.export_to_bind_format()`.
Linode DNS resources already have 'PRIORITY' field (see
https://www.linode.com/api/dns/domain.resource.list and
https://github.com/apache/libcloud/blob/trunk/libcloud/test/dns/fixtures/linode/resource_list.json),
we can just copy it into the `extra` field.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mete0r/libcloud
LIBCLOUD-937_linode-dns-record-priority-extra-field
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1088.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1088
commit e62a5ddd8dfc1d0a78111257fae66cbe4593f5a8
Author: mete0r
Date: 2017-08-07T16:52:45Z
Fix Linode DNS records to have 'priority' in extra
'priority' extra field is being used in
DNSDriver._get_bind_record_line() for export_zone_to_bind_format()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
