rgoers commented on code in PR #2442:
URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1552486927
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ppkarwasz commented on code in PR #2442:
URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1562164031
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation
ppkarwasz commented on code in PR #2442:
URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1562087991
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/DefaultThreadContextMap.java:
##
@@ -231,4 +231,21 @@ public boolean equals(final Object obj) {
rgoers commented on code in PR #2454:
URL: https://github.com/apache/logging-log4j2/pull/2454#discussion_r1562074401
##
log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java:
##
@@ -540,18 +552,18 @@ private synchronized void reload() {
ppkarwasz commented on PR #2442:
URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2051349123
I realized now that in this PR I assume that the `Object` returned by
`saveMap` will be used **only** once in a `restoreMap` call. This assumption
might be too restrictive for
vy commented on issue #2467:
URL:
https://github.com/apache/logging-log4j2/issues/2467#issuecomment-2051581481
@sdavids, thanks for the heads up. Fixed in
c88a546125f80ce840e96008ae6b96050ff24a7e and
c79cc7519c42fed2cfc01c943803d200a66fddd7 for `2.x` and `main`, respectively.
--
This
vy closed issue #2467: Use non-commercial host for SslConfigurationTest
URL: https://github.com/apache/logging-log4j2/issues/2467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ppkarwasz commented on PR #2442:
URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2051291811
> Son of a gun, I forgot to hit submit so none of my comments have been
viewable.
It happens to me all the time or even I hit it, but a network problem
prevents the
ppkarwasz closed pull request #2450: Simplify `DefaultScopedContextProvider`
URL: https://github.com/apache/logging-log4j2/pull/2450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ppkarwasz commented on PR #2450:
URL: https://github.com/apache/logging-log4j2/pull/2450#issuecomment-2051463364
I closed it, since a similar solution appeared in #2438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rgoers commented on PR #2438:
URL: https://github.com/apache/logging-log4j2/pull/2438#issuecomment-2053435531
@jvz I don't understand your comment Matt. While a ScopedContext performs a
similar function as the ThreadContext (but in a much safer way) it shares no
code with it at all. Did
rgoers commented on code in PR #2442:
URL: https://github.com/apache/logging-log4j2/pull/2442#discussion_r1563689177
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/ExtendedThreadContext.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
sdavids opened a new pull request, #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468
https://github.com/apache/logging-log4j2/issues/2462#issuecomment-2045821938
## Checklist
* Base your changes on `2.x` branch if you are targeting Log4j 2; use `main`
otherwise
sdavids commented on PR #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468#issuecomment-2052182025
There are currently no tests for the JMX support.
`org.apache.logging.log4j.core.jmx.Server#isJmxDisabled` is `private` and
`PropertiesUtil.getProperties()` lazily caches
ppkarwasz opened a new pull request, #2469:
URL: https://github.com/apache/logging-log4j2/pull/2469
This PR is an evolution of #1943, that adds an easy to use way to add
metrics and other instrumentation to Log4j Core.
It introduces an `InstrumentationService` class that is used each
sdavids commented on PR #2468:
URL: https://github.com/apache/logging-log4j2/pull/2468#issuecomment-2052243202
The double negative `log4j2.disableJmx=false` is unfortunate, but we would
have to deprecate an existing system property and introduce a new one
`log4j2.enableJmx` otherwise.
--
github-actions[bot] merged PR #97:
URL: https://github.com/apache/logging-log4j-transform/pull/97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] opened a new pull request, #97:
URL: https://github.com/apache/logging-log4j-transform/pull/97
Bumps org.slf4j:slf4j-api from 2.0.12 to 2.0.13.
[