[GitHub] dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.

2019-01-29 Thread GitBox
dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458578245 I propose to add both oldFile and newFile to the method arguments. Is there a reasoning why the pull request is

[GitHub] dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual.

2019-01-29 Thread GitBox
dpsenner commented on issue #46: '(doc)' make the method RollingFileAppender.RollFile() virtual. URL: https://github.com/apache/logging-log4net/pull/46#issuecomment-458574137 Would it be more appropriate to add an invocation of an emty but virtual PostRollFile method?