[GitHub] matthiasblaesing commented on issue #395: [NETBEANS-138] Fixed InjectedTasksSupportTest test.

matthiasblaesing commented on issue #395: [NETBEANS-138] Fixed InjectedTasksSupportTest test. URL: https://github.com/apache/incubator-netbeans/pull/395#issuecomment-372779314 @blackleg as noone seems to know what this test should test I suggest to remove it. We gain nothing by doing a fi

[GitHub] vieiro opened a new pull request #3: Asciidoc tutorials

vieiro opened a new pull request #3: Asciidoc tutorials URL: https://github.com/apache/incubator-netbeans-website-cleanup/pull/3 Automatic conversion/cleanup from HTML to asciidoc format. This is an automated message from the

[GitHub] matthiasblaesing commented on issue #419: [NETBEANS-408] Fix AntJUnitManagerProviderTest test at junit.ant.ui module.

matthiasblaesing commented on issue #419: [NETBEANS-408] Fix AntJUnitManagerProviderTest test at junit.ant.ui module. URL: https://github.com/apache/incubator-netbeans/pull/419#issuecomment-372785746 I would not fix it this way. A call to new can't return NULL, so the assert will never be

[GitHub] jlahoda closed pull request #445: Merge jdk18_3 ("var" support) branch to master

jlahoda closed pull request #445: Merge jdk18_3 ("var" support) branch to master URL: https://github.com/apache/incubator-netbeans/pull/445 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] blackleg commented on issue #395: [NETBEANS-138] Fixed InjectedTasksSupportTest test.

blackleg commented on issue #395: [NETBEANS-138] Fixed InjectedTasksSupportTest test. URL: https://github.com/apache/incubator-netbeans/pull/395#issuecomment-372790619 @matthiasblaesing It seems right, I will update pull request to remove the test. --

[GitHub] blackleg commented on issue #419: [NETBEANS-408] Fix AntJUnitManagerProviderTest test at junit.ant.ui module.

blackleg commented on issue #419: [NETBEANS-408] Fix AntJUnitManagerProviderTest test at junit.ant.ui module. URL: https://github.com/apache/incubator-netbeans/pull/419#issuecomment-372792679 Thanks @matthiasblaesing . I updated the pull request following your indications.

[GitHub] blackleg commented on issue #395: [NETBEANS-138] Removed InjectedTasksSupportTest test.

blackleg commented on issue #395: [NETBEANS-138] Removed InjectedTasksSupportTest test. URL: https://github.com/apache/incubator-netbeans/pull/395#issuecomment-372799960 @matthiasblaesing I removed the test. This is an autom

[GitHub] matthiasblaesing closed pull request #419: [NETBEANS-408] Fix AntJUnitManagerProviderTest test at junit.ant.ui module.

matthiasblaesing closed pull request #419: [NETBEANS-408] Fix AntJUnitManagerProviderTest test at junit.ant.ui module. URL: https://github.com/apache/incubator-netbeans/pull/419 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] matthiasblaesing closed pull request #395: [NETBEANS-138] Removed InjectedTasksSupportTest test.

matthiasblaesing closed pull request #395: [NETBEANS-138] Removed InjectedTasksSupportTest test. URL: https://github.com/apache/incubator-netbeans/pull/395 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prove

[GitHub] jlahoda closed pull request #442: If compilation during indexing fails on exception, try to fallback to?

jlahoda closed pull request #442: If compilation during indexing fails on exception, try to fallback to? URL: https://github.com/apache/incubator-netbeans/pull/442 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] jlahoda closed pull request #441: Not using the Log.error(..., String, ...) variant, as that does not e…

jlahoda closed pull request #441: Not using the Log.error(..., String, ...) variant, as that does not e… URL: https://github.com/apache/incubator-netbeans/pull/441 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] jlahoda commented on issue #441: Not using the Log.error(..., String, ...) variant, as that does not e…

jlahoda commented on issue #441: Not using the Log.error(..., String, ...) variant, as that does not e… URL: https://github.com/apache/incubator-netbeans/pull/441#issuecomment-372892484 The Travis failure seems like a glitch in starting the job. I don't see a way to re-run that, so I'll c

[GitHub] jlahoda opened a new pull request #452: Not using the Log.error(..., String, ...) variant, as that does not e…

jlahoda opened a new pull request #452: Not using the Log.error(..., String, ...) variant, as that does not e… URL: https://github.com/apache/incubator-netbeans/pull/452 …xist in JDK mainline anymore. This has been approved as: https://github.com/apache/incubator-netbeans/pull/441

[GitHub] jlahoda commented on issue #452: Not using the Log.error(..., String, ...) variant, as that does not e…

jlahoda commented on issue #452: Not using the Log.error(..., String, ...) variant, as that does not e… URL: https://github.com/apache/incubator-netbeans/pull/452#issuecomment-372899299 Please see: https://github.com/apache/incubator-netbeans/pull/441 for approvals.

[GitHub] jlahoda closed pull request #452: Not using the Log.error(..., String, ...) variant, as that does not e…

jlahoda closed pull request #452: Not using the Log.error(..., String, ...) variant, as that does not e… URL: https://github.com/apache/incubator-netbeans/pull/452 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake