[GitHub] JaroslavTulach closed pull request #392: form: Fix compile error under Java 9, method cannot be applied to types

JaroslavTulach closed pull request #392: form: Fix compile error under Java 9, method cannot be applied to types URL: https://github.com/apache/incubator-netbeans/pull/392 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] geertjanw closed pull request #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo…

geertjanw closed pull request #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo… URL: https://github.com/apache/incubator-netbeans/pull/534 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] geertjanw commented on issue #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo…

geertjanw commented on issue #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo… URL: https://github.com/apache/incubator-netbeans/pull/534#issuecomment-387648848 OK, merging. This is an automated

[GitHub] timboudreau commented on issue #537: Maven Indexing Optimizations

timboudreau commented on issue #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#issuecomment-387647186 FYI, I've updated the patch to use 2-3 path elements to determine JDK membership. More than that would not be a smart compromise on

[GitHub] geertjanw commented on issue #392: form: Fix compile error under Java 9, method cannot be applied to types

geertjanw commented on issue #392: form: Fix compile error under Java 9, method cannot be applied to types URL: https://github.com/apache/incubator-netbeans/pull/392#issuecomment-387650267 Any reason not to merge this, any potential side effects anticipated?

[GitHub] geertjanw closed pull request #538: [NETBEANS-620] Profiling SQL queries doesn't work under JDK 10

geertjanw closed pull request #538: [NETBEANS-620] Profiling SQL queries doesn't work under JDK 10 URL: https://github.com/apache/incubator-netbeans/pull/538 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] timboudreau opened a new pull request #541: Fix maven output window links for newer versions of Maven

timboudreau opened a new pull request #541: Fix maven output window links for newer versions of Maven URL: https://github.com/apache/incubator-netbeans/pull/541 This patch was already submitted (and IIRC, accepted) in the netbeans.org hg repo, but was applied after the Apache contribution

[GitHub] eirikbakke commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener.

eirikbakke commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener. URL: https://github.com/apache/incubator-netbeans/pull/515#issuecomment-387822051 Myself, I can't think of any possible adverse side-effects to this one.

[GitHub] matthiasblaesing commented on issue #540: [NETBEANS-305] Remove references to GPL/LGPL-21 licenses

matthiasblaesing commented on issue #540: [NETBEANS-305] Remove references to GPL/LGPL-21 licenses URL: https://github.com/apache/incubator-netbeans/pull/540#issuecomment-387841640 I updated the PR, as the first push did not properly remove the `o.jdesktop.beansbinding` directory. Travis

[GitHub] matthiasblaesing commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener.

matthiasblaesing commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener. URL: https://github.com/apache/incubator-netbeans/pull/515#issuecomment-387850642 I know that I'm late to the game, but I would try to avoid changing

[GitHub] emilianbold commented on issue #537: Maven Indexing Optimizations

emilianbold commented on issue #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#issuecomment-387888672 I didn't review the patch, just noticed it is references on the mailing list. @geertjanw, isn't 24 hours kinda short?

[GitHub] timboudreau commented on issue #537: Maven Indexing Optimizations

timboudreau commented on issue #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#issuecomment-387905711 It really isn't that exciting a patch. The resulting code does the same things, just much more efficiently. -Tim On Wed, May

[GitHub] eirikbakke commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener.

eirikbakke commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener. URL: https://github.com/apache/incubator-netbeans/pull/515#issuecomment-387898258 Yes, matthiasblaesing, that works, too. Tested and seems to work. I added

[GitHub] jlahoda opened a new pull request #40: Trying to setup a location for updates, redirecting to the synergy VM…

jlahoda opened a new pull request #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40 … for now. This is an automated message from the

[GitHub] geertjanw commented on issue #541: Fix maven output window links for newer versions of Maven

geertjanw commented on issue #541: Fix maven output window links for newer versions of Maven URL: https://github.com/apache/incubator-netbeans/pull/541#issuecomment-387886163 I don't see any reason not to merge this. Any comments, objections? If no responses, will merge in 24 hours.

[GitHub] jkovalsky commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

jkovalsky commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-387901695 https://netbeans-vm.apache.org/uc/9.0/updates.xml.gz now exists. Please merge this pull

[GitHub] emilianbold commented on a change in pull request #537: Maven Indexing Optimizations

emilianbold commented on a change in pull request #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187236285 ## File path: maven.indexer/src/org/netbeans/modules/maven/indexer/MatchWords.java ## @@ -0,0 +1,109 @@

[GitHub] vieiro commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

vieiro commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-387942502 NOTE: HTTP 302 (moved temporarily) is better than HTTP 301 (moved permanently) in this case.

[GitHub] vieiro closed pull request #40: Trying to setup a location for updates, redirecting to the synergy VM…

vieiro closed pull request #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] vieiro commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

vieiro commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-387938568 https://netbeans.apache.org//nb/updates/9.0/updates.xml.gz seems to be working now.