[GitHub] JaroslavTulach commented on a change in pull request #629: Language Server Protocol client

JaroslavTulach commented on a change in pull request #629: Language Server Protocol client URL: https://github.com/apache/incubator-netbeans/pull/629#discussion_r209164800 ## File path: libs.lsp/nbproject/project.properties ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Sof

[GitHub] rtaneja1 commented on a change in pull request #653: [NETBEANS-1043]:Fixed updation of method-reference upon refactor move of method

rtaneja1 commented on a change in pull request #653: [NETBEANS-1043]:Fixed updation of method-reference upon refactor move of method URL: https://github.com/apache/incubator-netbeans/pull/653#discussion_r209200265 ## File path: refactoring.java/src/org/netbeans/modules/refactoring/

[GitHub] jlahoda commented on a change in pull request #629: Language Server Protocol client

jlahoda commented on a change in pull request #629: Language Server Protocol client URL: https://github.com/apache/incubator-netbeans/pull/629#discussion_r20981 ## File path: libs.lsp/nbproject/project.properties ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software F

[GitHub] jlahoda commented on a change in pull request #629: Language Server Protocol client

jlahoda commented on a change in pull request #629: Language Server Protocol client URL: https://github.com/apache/incubator-netbeans/pull/629#discussion_r20981 ## File path: libs.lsp/nbproject/project.properties ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software F

[GitHub] sarveshkesharwani commented on issue #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop

sarveshkesharwani commented on issue #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop URL: https://github.com/apache/incubator-netbeans/pull/650#issuecomment-412065983 @sdedic @rtaneja1 @arusinha I have made the necessary changes incorporating the review comments. ---

[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop

sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r209255399 ## File path: java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java ###

[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop

sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r209254448 ## File path: java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java ###

[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop

sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r209254795 ## File path: java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java ###

[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop

sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r209255399 ## File path: java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java ###

[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop

sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r209255399 ## File path: java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java ###

[GitHub] sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop

sdedic commented on a change in pull request #650: [NETBEANS-1075]-Adding var hints for enhanced-for-loop URL: https://github.com/apache/incubator-netbeans/pull/650#discussion_r209255399 ## File path: java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertToVarHint.java ###

[GitHub] arusinha commented on issue #653: [NETBEANS-1043]:Fixed updation of method-reference upon refactor move of method

arusinha commented on issue #653: [NETBEANS-1043]:Fixed updation of method-reference upon refactor move of method URL: https://github.com/apache/incubator-netbeans/pull/653#issuecomment-412147286 I had implemented in last commit review comments of @rtaneja1 @vikasprabhakar -

[GitHub] SirIntellegence commented on issue #508: [NETBEANS-643] Mercurial Annotate fails on files with spaces in them …

SirIntellegence commented on issue #508: [NETBEANS-643] Mercurial Annotate fails on files with spaces in them … URL: https://github.com/apache/incubator-netbeans/pull/508#issuecomment-412193036 I don't see any existing tests for the blame logic. I would add to them if they were there, but

[GitHub] SirIntellegence commented on issue #508: [NETBEANS-643] Mercurial Annotate fails on files with spaces in them …

SirIntellegence commented on issue #508: [NETBEANS-643] Mercurial Annotate fails on files with spaces in them … URL: https://github.com/apache/incubator-netbeans/pull/508#issuecomment-412195332 I forgot to save before pushing the first one. Stupid mistake... --