[GitHub] matthiasblaesing commented on issue #1034: NETBEANS-1499 - change package.json icon

matthiasblaesing commented on issue #1034: NETBEANS-1499 - change package.json icon URL: https://github.com/apache/incubator-netbeans/pull/1034#issuecomment-462447508 Ok - Apache legal gave its verdict: As long as we use the icon in the way we plan (as an icon representing the programm),

[GitHub] lkishalmi commented on issue #1128: [NETBEANS-2102] Do not add single files to the Gradle classpath.

lkishalmi commented on issue #1128: [NETBEANS-2102] Do not add single files to the Gradle classpath. URL: https://github.com/apache/incubator-netbeans/pull/1128#issuecomment-462512543 @jlahoda Thanks for the tip using FileUtil.urlForArchiveOrDir! It makes the whole method much better and

[GitHub] lkishalmi merged pull request #1128: [NETBEANS-2102] Do not add single files to the Gradle classpath.

lkishalmi merged pull request #1128: [NETBEANS-2102] Do not add single files to the Gradle classpath. URL: https://github.com/apache/incubator-netbeans/pull/1128 This is an automated message from the Apache Git Service. To

[GitHub] jlahoda commented on issue #1107: Starting to eliminate remaining usages of old javadoc API and impleme…

jlahoda commented on issue #1107: Starting to eliminate remaining usages of old javadoc API and impleme… URL: https://github.com/apache/incubator-netbeans/pull/1107#issuecomment-462632886 FWIW, review for a patch that actually removes the old javadoc API from JDK:

[GitHub] rtaneja1 commented on issue #1121: [NETBEANS-2022]:Updation for external nb-javac jar in libs.javacapi a…

rtaneja1 commented on issue #1121: [NETBEANS-2022]:Updation for external nb-javac jar in libs.javacapi a… URL: https://github.com/apache/incubator-netbeans/pull/1121#issuecomment-462645977 Approved This is an automated

[GitHub] Chris2011 commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks.

Chris2011 commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks. URL: https://github.com/apache/incubator-netbeans/pull/1061#issuecomment-462261302 Only to let you know, that is not only gradle related. All started w/o

[GitHub] arsi-apli commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks.

arsi-apli commented on issue #1061: [NETBEANS-168] Simple least intrustive patch prevent IDE to burn CPU on broken symlinks. URL: https://github.com/apache/incubator-netbeans/pull/1061#issuecomment-462263515 Gradle has a bug in it that triggers it:

[GitHub] arusinha commented on a change in pull request #1079: [NETBEANS-1780]:Fixed formatting issue in Switch Expression(JDK-12)

arusinha commented on a change in pull request #1079: [NETBEANS-1780]:Fixed formatting issue in Switch Expression(JDK-12) URL: https://github.com/apache/incubator-netbeans/pull/1079#discussion_r255537866 ## File path:

[GitHub] arusinha commented on issue #1079: [NETBEANS-1780]:Fixed formatting issue in Switch Expression(JDK-12)

arusinha commented on issue #1079: [NETBEANS-1780]:Fixed formatting issue in Switch Expression(JDK-12) URL: https://github.com/apache/incubator-netbeans/pull/1079#issuecomment-462354989 > I am sorry, but there should be tests for the change. In some cases, it is difficult to say if the

[GitHub] arusinha commented on a change in pull request #1079: [NETBEANS-1780]:Fixed formatting issue in Switch Expression(JDK-12)

arusinha commented on a change in pull request #1079: [NETBEANS-1780]:Fixed formatting issue in Switch Expression(JDK-12) URL: https://github.com/apache/incubator-netbeans/pull/1079#discussion_r255540297 ## File path:

[GitHub] jtulach opened a new pull request #14: Using the same model in two views

jtulach opened a new pull request #14: Using the same model in two views URL: https://github.com/apache/incubator-netbeans-html4j/pull/14 If the same model is used in two views, the binding in the second one is broken. Let's start with a test to demonstrate the problem.

[GitHub] eppleton commented on issue #14: Using the same model in two views

eppleton commented on issue #14: Using the same model in two views URL: https://github.com/apache/incubator-netbeans-html4j/pull/14#issuecomment-462285908 It would be great to get this working. If possible the solution should also work for other use cases, e.g. embedding in a JavaFX