[GitHub] [netbeans] arusinha commented on issue #1409: [NETBEANS-2917]: Support for yield in Switch-Expression for JDK-13

2019-08-13 Thread GitBox
arusinha commented on issue #1409: [NETBEANS-2917]: Support for yield in Switch-Expression for JDK-13 URL: https://github.com/apache/netbeans/pull/1409#issuecomment-520773295 Had addressed all review comments in last commit T

[GitHub] [netbeans] matthiasblaesing commented on issue #1099: WIP: Integration of Graal.js parser with NetBeans

2019-08-13 Thread GitBox
matthiasblaesing commented on issue #1099: WIP: Integration of Graal.js parser with NetBeans URL: https://github.com/apache/netbeans/pull/1099#issuecomment-520964478 I'm removing the `graaljs2` branch, as @jtulach created a relicensed graaljs parser and I'm preparing an update PR, that onl

[GitHub] [netbeans] matthiasblaesing edited a comment on issue #1099: WIP: Integration of Graal.js parser with NetBeans

2019-08-13 Thread GitBox
matthiasblaesing edited a comment on issue #1099: WIP: Integration of Graal.js parser with NetBeans URL: https://github.com/apache/netbeans/pull/1099#issuecomment-520964478 I'm removing the `graaljs2` branch, as @jtulach created a relicensed graaljs parser and I'm preparing an update PR, t

[GitHub] [netbeans] junichi11 opened a new pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
junichi11 opened a new pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423 https://issues.apache.org/jira/browse/NETBEANS-53 - Add types of properties to parameter and return types of constructor, gett

[GitHub] [netbeans] sdedic commented on issue #1099: WIP: Integration of Graal.js parser with NetBeans

2019-08-13 Thread GitBox
sdedic commented on issue #1099: WIP: Integration of Graal.js parser with NetBeans URL: https://github.com/apache/netbeans/pull/1099#issuecomment-521038601 @matthiasblaesing I would advise to keep the branch yet for a while. As far as I understand what was done, the OLD code was relicensed

[GitHub] [netbeans] junichi11 opened a new pull request #1424: [NETBEANS-2971] Missing spaces in anonymous function declaration

2019-08-13 Thread GitBox
junichi11 opened a new pull request #1424: [NETBEANS-2971] Missing spaces in anonymous function declaration URL: https://github.com/apache/netbeans/pull/1424 https://issues.apache.org/jira/browse/NETBEANS-2971 When Within Parentheses - Method / Function Declaration is checked: ```

[GitHub] [netbeans] JaroslavTulach commented on issue #1099: WIP: Integration of Graal.js parser with NetBeans

2019-08-13 Thread GitBox
JaroslavTulach commented on issue #1099: WIP: Integration of Graal.js parser with NetBeans URL: https://github.com/apache/netbeans/pull/1099#issuecomment-521101584 > newer JS specification is still not supported by the now-UPL js parser Right. The language is at most ES2015. `let` is

[GitHub] [netbeans] tmysik merged pull request #1424: [NETBEANS-2971] Missing spaces in anonymous function declaration

2019-08-13 Thread GitBox
tmysik merged pull request #1424: [NETBEANS-2971] Missing spaces in anonymous function declaration URL: https://github.com/apache/netbeans/pull/1424 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313706961 ## File path: php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java ###

[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313707328 ## File path: php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java ###

[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313707423 ## File path: php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java ###

[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313707423 ## File path: php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java ###

[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313707520 ## File path: php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java ###

[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313707520 ## File path: php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java ###

[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313707837 ## File path: php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSInfo.java ###

[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313708129 ## File path: php/php.editor/test/unit/data/testfiles/codegen/testTypedPropertiesGetter/testTy

[GitHub] [netbeans] tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
tmysik commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313708271 ## File path: php/php.editor/test/unit/data/testfiles/codegen/testTypedPropertiesGetter/testTy

[GitHub] [netbeans] tmysik commented on issue #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
tmysik commented on issue #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#issuecomment-521106976 @junichi11 Will wait for your reaction to my comments (no action is needed, those are just hints). I will merge then.

[GitHub] [netbeans] junichi11 commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
junichi11 commented on a change in pull request #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#discussion_r313709846 ## File path: php/php.editor/test/unit/data/testfiles/codegen/testTypedPropertiesGetter/tes

[GitHub] [netbeans] junichi11 commented on issue #1423: [NETBEANS-53] Improve constructor getter setter code generation

2019-08-13 Thread GitBox
junichi11 commented on issue #1423: [NETBEANS-53] Improve constructor getter setter code generation URL: https://github.com/apache/netbeans/pull/1423#issuecomment-521108277 @tmysik Thank you for your review! I'll fix them :)

[GitHub] [netbeans] jlahoda merged pull request #1322: Fixing java.completion tests on JDK 13.

2019-08-13 Thread GitBox
jlahoda merged pull request #1322: Fixing java.completion tests on JDK 13. URL: https://github.com/apache/netbeans/pull/1322 This is an automated message from the Apache Git Service. To respond to the message, please log on t