[GitHub] [netbeans] geertjanw commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13)

2019-09-16 Thread GitBox
geertjanw commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13) URL: https://github.com/apache/netbeans/pull/1509#issuecomment-531828835 Agreed. Needs to be registered the same way as for all the others.

[GitHub] [netbeans] neilcsmith-net commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13)

2019-09-16 Thread GitBox
neilcsmith-net commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13) URL: https://github.com/apache/netbeans/pull/1509#issuecomment-531827842 Out of interest, why is this capitalized with a space when the others are lower case and hyphenated?

[GitHub] [netbeans] emilianbold commented on issue #1260: Adds SHA-512 to external binaries

2019-09-16 Thread GitBox
emilianbold commented on issue #1260: Adds SHA-512 to external binaries URL: https://github.com/apache/netbeans/pull/1260#issuecomment-531845527 Would be an interesting proof of concept to build a JAR with a colliding SHA1 using the https://shattered.io paper and show that if one were to

[GitHub] [netbeans] neilcsmith-net commented on issue #1494: [NETBEANS-2941] Allow the IDE to see the compiler options in Gradle Projects

2019-09-16 Thread GitBox
neilcsmith-net commented on issue #1494: [NETBEANS-2941] Allow the IDE to see the compiler options in Gradle Projects URL: https://github.com/apache/netbeans/pull/1494#issuecomment-531845387 No problem! Merge it when you're ready.

[GitHub] [netbeans] neilcsmith-net commented on issue #1446: An alternate solution to horrendous default font sizes and antialiasing on Linux

2019-09-16 Thread GitBox
neilcsmith-net commented on issue #1446: An alternate solution to horrendous default font sizes and antialiasing on Linux URL: https://github.com/apache/netbeans/pull/1446#issuecomment-531874188 Also, Travis failed again after retriggering so may be a sign of an issue .. or not. Few

[GitHub] [netbeans] geertjanw commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13)

2019-09-16 Thread GitBox
geertjanw commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13) URL: https://github.com/apache/netbeans/pull/1509#issuecomment-531835274 The display name should be Text Block, the programmatic name text-block. See how it is done for the others.

[GitHub] [netbeans] arusinha commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13)

2019-09-16 Thread GitBox
arusinha commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13) URL: https://github.com/apache/netbeans/pull/1509#issuecomment-531835066 Name was changed to make it look better This

[GitHub] [netbeans-jenkins-lib] neilcsmith-net opened a new pull request #1: Fix update_url and plugin_url to match current master

2019-09-16 Thread GitBox
neilcsmith-net opened a new pull request #1: Fix update_url and plugin_url to match current master URL: https://github.com/apache/netbeans-jenkins-lib/pull/1 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] neilcsmith-net commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13)

2019-09-16 Thread GitBox
neilcsmith-net commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13) URL: https://github.com/apache/netbeans/pull/1509#issuecomment-531834151 @arusinha that depends what your reason for changing it is? What does "corrected" mean? To make it work

[GitHub] [netbeans] neilcsmith-net commented on issue #1428: Adding Markdown syntax highlighting

2019-09-16 Thread GitBox
neilcsmith-net commented on issue #1428: Adding Markdown syntax highlighting URL: https://github.com/apache/netbeans/pull/1428#issuecomment-531867278 I've retriggered failing Travis tests. What's the plan with this one? Merge for 11.2 or wait?

[GitHub] [netbeans] arusinha commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13)

2019-09-16 Thread GitBox
arusinha commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13) URL: https://github.com/apache/netbeans/pull/1509#issuecomment-531830564 Hi @neilcsmith-net / @geertjanw should I retain the old name text-block ?

[GitHub] [netbeans] neilcsmith-net commented on issue #1260: Adds SHA-512 to external binaries

2019-09-16 Thread GitBox
neilcsmith-net commented on issue #1260: Adds SHA-512 to external binaries URL: https://github.com/apache/netbeans/pull/1260#issuecomment-531803588 As this hasn't been updated for NB 11.2 and is likely to drift further away from being mergeable I suggest we close this PR, and open another

[GitHub] [netbeans] jlahoda commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13)

2019-09-16 Thread GitBox
jlahoda commented on issue #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13) URL: https://github.com/apache/netbeans/pull/1509#issuecomment-531836620 Should be possible to put text-block=Text Block to the Bundle.properties in the same directory.

[GitHub] [netbeans] neilcsmith-net commented on issue #425: Netbeans 352

2019-09-16 Thread GitBox
neilcsmith-net commented on issue #425: Netbeans 352 URL: https://github.com/apache/netbeans/pull/425#issuecomment-531804522 @matthiasblaesing true! I don't think this is likely to be merged in the direction it's currently going, so shall we bring up above discussion elsewhere and close?

[GitHub] [netbeans] neilcsmith-net commented on issue #1446: An alternate solution to horrendous default font sizes and antialiasing on Linux

2019-09-16 Thread GitBox
neilcsmith-net commented on issue #1446: An alternate solution to horrendous default font sizes and antialiasing on Linux URL: https://github.com/apache/netbeans/pull/1446#issuecomment-531807205 Where are we at with this? Attempting to merge for NB 11.2 or leaving aside for NB 11.3 or

[GitHub] [netbeans] arusinha opened a new pull request #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13)

2019-09-16 Thread GitBox
arusinha opened a new pull request #1509: [NETBEANS-3097]:Corrected font-color type name for text-block(JDK-13) URL: https://github.com/apache/netbeans/pull/1509 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] lkishalmi commented on issue #1494: [NETBEANS-2941] Allow the IDE to see the compiler options in Gradle Projects

2019-09-16 Thread GitBox
lkishalmi commented on issue #1494: [NETBEANS-2941] Allow the IDE to see the compiler options in Gradle Projects URL: https://github.com/apache/netbeans/pull/1494#issuecomment-531839163 Tests are meant to be after merging for this. I'm sorry responding a bit late, living in PDT and just

[GitHub] [netbeans] neilcsmith-net commented on issue #1474: Improving compatibility with the records-and-sealed branch of OpenJDK…

2019-09-16 Thread GitBox
neilcsmith-net commented on issue #1474: Improving compatibility with the records-and-sealed branch of OpenJDK… URL: https://github.com/apache/netbeans/pull/1474#issuecomment-531865598 For NB 11.2? If ready, please merge, thanks.

[GitHub] [netbeans] geertjanw commented on issue #1411: build branding

2019-09-16 Thread GitBox
geertjanw commented on issue #1411: build branding URL: https://github.com/apache/netbeans/pull/1411#issuecomment-531873488 I like it and also the idea of merging this during a non-LTS release and therefore to not necessarily have it 100% done, but as a starting point for 12.0 LTS

[GitHub] [netbeans] jlahoda commented on issue #1428: Adding Markdown syntax highlighting

2019-09-16 Thread GitBox
jlahoda commented on issue #1428: Adding Markdown syntax highlighting URL: https://github.com/apache/netbeans/pull/1428#issuecomment-531894750 I was inclined to incorporate the external plugin if possible, but didn't actually get to really look into that. So I'll leave it up to you if we

[GitHub] [netbeans] aweida commented on issue #1269: [NETBEANS-2417] Update Gradle logo/icon

2019-09-16 Thread GitBox
aweida commented on issue #1269: [NETBEANS-2417] Update Gradle logo/icon URL: https://github.com/apache/netbeans/pull/1269#issuecomment-531992161 Hi all, Charles here from Gradle. Would it be possible to share a screenshot(s) of the icons in context so us design folks who are less

[GitHub] [netbeans] lkishalmi merged pull request #1494: [NETBEANS-2941] Allow the IDE to see the compiler options in Gradle Projects

2019-09-16 Thread GitBox
lkishalmi merged pull request #1494: [NETBEANS-2941] Allow the IDE to see the compiler options in Gradle Projects URL: https://github.com/apache/netbeans/pull/1494 This is an automated message from the Apache Git Service.

[GitHub] [netbeans] junichi11 opened a new pull request #1510: [NETBEANS-3103] Formatting is broken with class constant code completion(self::)

2019-09-16 Thread GitBox
junichi11 opened a new pull request #1510: [NETBEANS-3103] Formatting is broken with class constant code completion(self::) URL: https://github.com/apache/netbeans/pull/1510 https://issues.apache.org/jira/browse/NETBEANS-3103 This issue is related to #1314 . - The parser

[GitHub] [netbeans] jlahoda merged pull request #1474: Improving compatibility with the records-and-sealed branch of OpenJDK…

2019-09-16 Thread GitBox
jlahoda merged pull request #1474: Improving compatibility with the records-and-sealed branch of OpenJDK… URL: https://github.com/apache/netbeans/pull/1474 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] louhy commented on issue #1269: [NETBEANS-2417] Update Gradle logo/icon

2019-09-16 Thread GitBox
louhy commented on issue #1269: [NETBEANS-2417] Update Gradle logo/icon URL: https://github.com/apache/netbeans/pull/1269#issuecomment-532045802 @aweida Does this help? Projects and files have special icons which indicate project or file type:

[GitHub] [netbeans] lkishalmi commented on issue #1477: [NETBEANS-2788] The link provided for downloading Groovy is obsolete

2019-09-16 Thread GitBox
lkishalmi commented on issue #1477: [NETBEANS-2788] The link provided for downloading Groovy is obsolete URL: https://github.com/apache/netbeans/pull/1477#issuecomment-532055237 @neilcsmith-net You can merge this whenever you find it ideal.

[GitHub] [netbeans] junichi11 commented on issue #1510: [NETBEANS-3103] Formatting is broken with class constant code completion(self::)

2019-09-16 Thread GitBox
junichi11 commented on issue #1510: [NETBEANS-3103] Formatting is broken with class constant code completion(self::) URL: https://github.com/apache/netbeans/pull/1510#issuecomment-532039169 @neilcsmith-net This is related to #1314. So we should fix this in NB11.2, I think. Is it OK?

[GitHub] [netbeans] rtaneja1 commented on issue #1505: [NETBEANS-3045]Install subsets

2019-09-16 Thread GitBox
rtaneja1 commented on issue #1505: [NETBEANS-3045]Install subsets URL: https://github.com/apache/netbeans/pull/1505#issuecomment-531659977 > Great, thanks for this, please merge if you're happy with this. > > Make sure the title of the HTML option is: "HTML5/JavaScript" Yes,

[GitHub] [netbeans] JaroslavTulach commented on issue #1503: [NETBEANS-2751] OpenJFX Samples

2019-09-16 Thread GitBox
JaroslavTulach commented on issue #1503: [NETBEANS-2751] OpenJFX Samples URL: https://github.com/apache/netbeans/pull/1503#issuecomment-531655317 Thanks for removing the ` javafx/openjfx.samples` module. This is an automated

[GitHub] [netbeans] geertjanw commented on issue #1505: [NETBEANS-3045]Install subsets

2019-09-16 Thread GitBox
geertjanw commented on issue #1505: [NETBEANS-3045]Install subsets URL: https://github.com/apache/netbeans/pull/1505#issuecomment-531656786 Great, thanks for this, please merge if you're happy with this. Make sure the title of the HTML option is: "HTML5/JavaScript"

[GitHub] [netbeans] arusinha merged pull request #1506: [NETBEANS-3096]:Updation for external nb-javac jar in libs.javacapi a…

2019-09-16 Thread GitBox
arusinha merged pull request #1506: [NETBEANS-3096]:Updation for external nb-javac jar in libs.javacapi a… URL: https://github.com/apache/netbeans/pull/1506 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] geertjanw commented on issue #1504: [NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too

2019-09-16 Thread GitBox
geertjanw commented on issue #1504: [NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too URL: https://github.com/apache/netbeans/pull/1504#issuecomment-531735037 Looks good to me. This is an

[GitHub] [netbeans] geertjanw merged pull request #1505: [NETBEANS-3045]Install subsets

2019-09-16 Thread GitBox
geertjanw merged pull request #1505: [NETBEANS-3045]Install subsets URL: https://github.com/apache/netbeans/pull/1505 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [netbeans] geertjanw commented on issue #1504: [NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too

2019-09-16 Thread GitBox
geertjanw commented on issue #1504: [NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too URL: https://github.com/apache/netbeans/pull/1504#issuecomment-531737084 Following request to not squash.

[GitHub] [netbeans] geertjanw merged pull request #1504: [NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too

2019-09-16 Thread GitBox
geertjanw merged pull request #1504: [NETBEANS-3094] NBI cleaner process must attempt to remove read-only files too URL: https://github.com/apache/netbeans/pull/1504 This is an automated message from the Apache Git

[GitHub] [netbeans] neilcsmith-net commented on issue #1482: JEDDICT-322 org.netbeans.modules.db.metadata.model convert friend to public packages

2019-09-16 Thread GitBox
neilcsmith-net commented on issue #1482: JEDDICT-322 org.netbeans.modules.db.metadata.model convert friend to public packages URL: https://github.com/apache/netbeans/pull/1482#issuecomment-531739687 > As we are nearing feature freeze, I would like to postpone this till release of 11.2 is