[GitHub] [netbeans] jlahoda commented on issue #1551: Module list to log missing code base

2019-10-07 Thread GitBox
jlahoda commented on issue #1551: Module list to log missing code base URL: https://github.com/apache/netbeans/pull/1551#issuecomment-538852175 Yes, I understand findElement() returns null if it cannot find the element - but most here methods don't silently accept nulls as parameters, I

[GitHub] [netbeans-website] geertjanw commented on issue #417: [NETBEANS-3208] Add Snap package to download page

2019-10-07 Thread GitBox
geertjanw commented on issue #417: [NETBEANS-3208] Add Snap package to download page URL: https://github.com/apache/netbeans-website/pull/417#issuecomment-538866599 Makes sense, merging. This is an automated message from the

[GitHub] [netbeans-website] geertjanw commented on issue #416: [NETBEANS-3209] Add JAVA_HOME and ANT_HOME note

2019-10-07 Thread GitBox
geertjanw commented on issue #416: [NETBEANS-3209] Add JAVA_HOME and ANT_HOME note URL: https://github.com/apache/netbeans-website/pull/416#issuecomment-538866397 Thanks, makes sense, merging. This is an automated message

[GitHub] [netbeans-website] geertjanw merged pull request #416: [NETBEANS-3209] Add JAVA_HOME and ANT_HOME note

2019-10-07 Thread GitBox
geertjanw merged pull request #416: [NETBEANS-3209] Add JAVA_HOME and ANT_HOME note URL: https://github.com/apache/netbeans-website/pull/416 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [netbeans-website] geertjanw merged pull request #417: [NETBEANS-3208] Add Snap package to download page

2019-10-07 Thread GitBox
geertjanw merged pull request #417: [NETBEANS-3208] Add Snap package to download page URL: https://github.com/apache/netbeans-website/pull/417 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [netbeans] geertjanw merged pull request #1554: [NETBEANS-3209] Add JAVA_HOME and ANT_HOME note

2019-10-07 Thread GitBox
geertjanw merged pull request #1554: [NETBEANS-3209] Add JAVA_HOME and ANT_HOME note URL: https://github.com/apache/netbeans/pull/1554 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [netbeans] geertjanw commented on issue #1554: [NETBEANS-3209] Add JAVA_HOME and ANT_HOME note

2019-10-07 Thread GitBox
geertjanw commented on issue #1554: [NETBEANS-3209] Add JAVA_HOME and ANT_HOME note URL: https://github.com/apache/netbeans/pull/1554#issuecomment-538865867 Makes sense, thanks. This is a simple change to the README, merging it.

[GitHub] [netbeans] neilcsmith-net merged pull request #1462: [NETBEANS-3019] Using an actual/existing entered CompilationUnit to c…

2019-10-07 Thread GitBox
neilcsmith-net merged pull request #1462: [NETBEANS-3019] Using an actual/existing entered CompilationUnit to c… URL: https://github.com/apache/netbeans/pull/1462 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #1552: Use Material CSS to make the example look nicer

2019-10-07 Thread GitBox
neilcsmith-net commented on a change in pull request #1552: Use Material CSS to make the example look nicer URL: https://github.com/apache/netbeans/pull/1552#discussion_r331965325 ## File path:

[GitHub] [netbeans] Chris2011 removed a comment on issue #1555: NETBEANS-3185 use last maven-nbm-plugin

2019-10-07 Thread GitBox
Chris2011 removed a comment on issue #1555: NETBEANS-3185 use last maven-nbm-plugin URL: https://github.com/apache/netbeans/pull/1555#issuecomment-538992325 I think the vote was successful and on base of this vote, he created the PR.

[GitHub] [netbeans] Chris2011 commented on issue #1555: NETBEANS-3185 use last maven-nbm-plugin

2019-10-07 Thread GitBox
Chris2011 commented on issue #1555: NETBEANS-3185 use last maven-nbm-plugin URL: https://github.com/apache/netbeans/pull/1555#issuecomment-538992325 I think the vote was successful and on base of this vote, he created the PR.

[GitHub] [netbeans] ebarboni opened a new pull request #1555: NETBEANS-3185 use last maven-nbm-plugin

2019-10-07 Thread GitBox
ebarboni opened a new pull request #1555: NETBEANS-3185 use last maven-nbm-plugin URL: https://github.com/apache/netbeans/pull/1555 This is last part of fix for NETBEANS-3185. It's to use the 4.3 version of plugin As vote is in progress it's not yet available.

[GitHub] [netbeans] neilcsmith-net commented on issue #1550: Retry mysql tests in Travis config

2019-10-07 Thread GitBox
neilcsmith-net commented on issue #1550: Retry mysql tests in Travis config URL: https://github.com/apache/netbeans/pull/1550#issuecomment-539012773 @blackleg thanks! Let's see if this improves things. In fact, there are a couple of other tests that occasionally fail on network errors

[GitHub] [netbeans] neilcsmith-net merged pull request #1550: Retry mysql tests in Travis config

2019-10-07 Thread GitBox
neilcsmith-net merged pull request #1550: Retry mysql tests in Travis config URL: https://github.com/apache/netbeans/pull/1550 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [netbeans] neilcsmith-net commented on issue #1547: [NETBEANS-3164]:Fixed issue in Text-Block

2019-10-07 Thread GitBox
neilcsmith-net commented on issue #1547: [NETBEANS-3164]:Fixed issue in Text-Block URL: https://github.com/apache/netbeans/pull/1547#issuecomment-539033780 @jlahoda what is the current spec version? I currently see same version in NB 11.2-beta2 as NB 11.1. Just tried with clean userdir

[GitHub] [netbeans] neilcsmith-net merged pull request #1542: [NETBEANS-3191] ensuring ElementHandle works even for CompilationInfo…

2019-10-07 Thread GitBox
neilcsmith-net merged pull request #1542: [NETBEANS-3191] ensuring ElementHandle works even for CompilationInfo… URL: https://github.com/apache/netbeans/pull/1542 This is an automated message from the Apache Git Service. To

[GitHub] [netbeans] jlahoda commented on issue #1547: [NETBEANS-3164]:Fixed issue in Text-Block

2019-10-07 Thread GitBox
jlahoda commented on issue #1547: [NETBEANS-3164]:Fixed issue in Text-Block URL: https://github.com/apache/netbeans/pull/1547#issuecomment-539143121 Ok, I know now what is going on - the nb-javac modules are not part of the "3rdparty" cluster, and hence are not part of the source zip built

[GitHub] [netbeans] jlahoda opened a new pull request #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t…

2019-10-07 Thread GitBox
jlahoda opened a new pull request #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t… URL: https://github.com/apache/netbeans/pull/1556 …hey are part of the standard distro. Otherwise, the nb-javac modules are not available for builds done from the actual

[GitHub] [netbeans] lkishalmi opened a new pull request #1557: [NETBEANS-2417] Gradle Logo Update

2019-10-07 Thread GitBox
lkishalmi opened a new pull request #1557: [NETBEANS-2417] Gradle Logo Update URL: https://github.com/apache/netbeans/pull/1557 This one is based on the work done in PR #1269 and supersedes that. There is a (VOTING

[GitHub] [netbeans] lkishalmi closed pull request #1269: [NETBEANS-2417] Update Gradle logo/icon

2019-10-07 Thread GitBox
lkishalmi closed pull request #1269: [NETBEANS-2417] Update Gradle logo/icon URL: https://github.com/apache/netbeans/pull/1269 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [netbeans] lkishalmi commented on issue #1269: [NETBEANS-2417] Update Gradle logo/icon

2019-10-07 Thread GitBox
lkishalmi commented on issue #1269: [NETBEANS-2417] Update Gradle logo/icon URL: https://github.com/apache/netbeans/pull/1269#issuecomment-539331165 Closing this one in favor of #1557 This is an automated message from the