[GitHub] matthiasblaesing commented on issue #330: Issue 211

matthiasblaesing commented on issue #330: Issue 211 URL: https://github.com/apache/incubator-netbeans/pull/330#issuecomment-352890966 These changes look good. This looks as if you were successful in finding files, that even Oracle did not find. *nice*

[GitHub] geertjanw commented on issue #334: Readd removed XSD Schemata for XSLT and XML Schema

geertjanw commented on issue #334: Readd removed XSD Schemata for XSLT and XML Schema URL: https://github.com/apache/incubator-netbeans/pull/334#issuecomment-352899129 Makes sense, merging. This is an automated message from

[GitHub] geertjanw closed pull request #334: Readd removed XSD Schemata for XSLT and XML Schema

geertjanw closed pull request #334: Readd removed XSD Schemata for XSLT and XML Schema URL: https://github.com/apache/incubator-netbeans/pull/334 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] sdedic commented on a change in pull request #333: Making nb-javac optional

sdedic commented on a change in pull request #333: Making nb-javac optional URL: https://github.com/apache/incubator-netbeans/pull/333#discussion_r157869854 ## File path: java.source.base/src/org/netbeans/modules/java/source/base/SourceLevelUtils.java ## @@ -0,0 +1,37 @@

[GitHub] matthiasblaesing opened a new pull request #334: Readd removed XSD Schemata for XSLT and XML Schema

matthiasblaesing opened a new pull request #334: Readd removed XSD Schemata for XSLT and XML Schema URL: https://github.com/apache/incubator-netbeans/pull/334 These were removed in: http://hg.netbeans.org/releases/rev/905ace65e3d3?revcount=1500 and there is no reason not to

[GitHub] emilianbold commented on issue #329: Setting tmp directory

emilianbold commented on issue #329: Setting tmp directory URL: https://github.com/apache/incubator-netbeans/pull/329#issuecomment-353310717 At patch level, it might be better to define a netbeans_default_tmpdir next to netbeans_default_cachedir above. I feel conflictual about this

[GitHub] vieiro closed pull request #39: Fixes the first link to the wiki index

vieiro closed pull request #39: Fixes the first link to the wiki index URL: https://github.com/apache/incubator-netbeans-website/pull/39 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] svenreimers commented on issue #538: [NETBEANS-620] Profiling SQL queries doesn't work under JDK 10

svenreimers commented on issue #538: [NETBEANS-620] Profiling SQL queries doesn't work under JDK 10 URL: https://github.com/apache/incubator-netbeans/pull/538#issuecomment-386884116 Debugging through the code I recognized that during updating the ClassRepository for the JDK10 based

[GitHub] svenreimers commented on issue #538: [NETBEANS-620] Profiling SQL queries doesn't work under JDK 10

svenreimers commented on issue #538: [NETBEANS-620] Profiling SQL queries doesn't work under JDK 10 URL: https://github.com/apache/incubator-netbeans/pull/538#issuecomment-386884116 Debugging through the code I recognized that during updating the ClassRepository for the JDK10 based

[GitHub] jlahoda commented on issue #538: [NETBEANS-620] Profiling SQL queries doesn't work under JDK 10

jlahoda commented on issue #538: [NETBEANS-620] Profiling SQL queries doesn't work under JDK 10 URL: https://github.com/apache/incubator-netbeans/pull/538#issuecomment-386882812 Thanks for working on this! Are there any insights on what was the issue? Thanks!

[GitHub] jlahoda commented on a change in pull request #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo…

jlahoda commented on a change in pull request #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo… URL: https://github.com/apache/incubator-netbeans/pull/534#discussion_r186253626 ## File path:

[GitHub] jlahoda opened a new pull request #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo…

jlahoda opened a new pull request #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo… URL: https://github.com/apache/incubator-netbeans/pull/534 …re touching elements - using ELEMENTS_RESOLVED instead of PARSED as a target phase.

[GitHub] ocafebabe commented on a change in pull request #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version

ocafebabe commented on a change in pull request #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version URL: https://github.com/apache/incubator-netbeans/pull/535#discussion_r186310227 ## File path: o.eclipse.jgit/manifest.mf ## @@ -1 +1,4 @@ OpenIDE-Module:

[GitHub] jlahoda commented on a change in pull request #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation

jlahoda commented on a change in pull request #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation URL: https://github.com/apache/incubator-netbeans/pull/504#discussion_r186196752 ## File path:

[GitHub] vieiro commented on issue #491: Allow to postprocess downloaded binaries

vieiro commented on issue #491: Allow to postprocess downloaded binaries URL: https://github.com/apache/incubator-netbeans/pull/491#issuecomment-386788158 Would it be possible to link to our new wiki page? Is this page http://netbeans.apache.org/wiki/DevFaqExternalLibraries.asciidoc the

[GitHub] jlahoda commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

jlahoda commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r186421272 ## File path:

[GitHub] jlahoda commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

jlahoda commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r186421346 ## File path:

[GitHub] jlahoda commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

jlahoda commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r186400954 ## File path:

[GitHub] mcdonnell-john commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

mcdonnell-john commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-386531954 Let's leave this open, if someone wants to come review it great! but if not after a week or so I will

[GitHub] Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-386530426 @mcdonnell-john so I tested it and it seems to work now. I don't know whether there are some other corner

[GitHub] ocafebabe commented on issue #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version

ocafebabe commented on issue #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version URL: https://github.com/apache/incubator-netbeans/pull/535#issuecomment-387555445 @matthiasblaesing no worries and thanks a lot for your feedback! Duly noted regarding the tests and I

[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions

Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-388706086 Hm, maybe there was smth wrong with the merge :/. Sry about that. Will change and test it later. Thx @emilianbold

[GitHub] sdedic commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

sdedic commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r187874376 ## File path:

[GitHub] arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r187920753 ## File path:

[GitHub] arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r187920753 ## File path:

[GitHub] arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

arusinha commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r187920753 ## File path:

[GitHub] arusinha opened a new pull request #547: [NETBEANS-764] JDK10-LVTI: Skip ConvertToVar hint for compound variable declaration

arusinha opened a new pull request #547: [NETBEANS-764] JDK10-LVTI: Skip ConvertToVar hint for compound variable declaration URL: https://github.com/apache/incubator-netbeans/pull/547 Jira Id: https://issues.apache.org/jira/browse/NETBEANS-764 For compound variable declaration

[GitHub] jkovalsky commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

jkovalsky commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-388847723 Status update: while downloading https://netbeans-vm.apache.org/uc/9.0/updates.xml.gz gets

[GitHub] vieiro commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

vieiro commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-388901927 The requests to netbeans.apache.org will be logged in the netbeans.apache.org:/var/log/apache2

[GitHub] neilcsmith-net commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

neilcsmith-net commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-388906704 @vieiro but surely there must be a way to log the redirected request on the VM too? Long

[GitHub] emilianbold opened a new pull request #548: [NETBEANS-781] Adds Maven coordinates for Ant libs

emilianbold opened a new pull request #548: [NETBEANS-781] Adds Maven coordinates for Ant libs URL: https://github.com/apache/incubator-netbeans/pull/548 This is just the first part of a fix for NETBEANS-781. In the end we will switch to Ant 1.10.4 which is alpha now. This commit

[GitHub] ocafebabe commented on issue #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version

ocafebabe commented on issue #535: [NETBEANS-519] Bump Eclipse JGit dependency to latest version URL: https://github.com/apache/incubator-netbeans/pull/535#issuecomment-387221400 Regarding the com.jcraft.jsch module, yes you're right about the OSGi meta data that is added to the original

[GitHub] jlahoda closed pull request #526: Naive fix for Java 10 as WeakPairMap

jlahoda closed pull request #526: Naive fix for Java 10 as WeakPairMap URL: https://github.com/apache/incubator-netbeans/pull/526 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] JaroslavTulach closed pull request #392: form: Fix compile error under Java 9, method cannot be applied to types

JaroslavTulach closed pull request #392: form: Fix compile error under Java 9, method cannot be applied to types URL: https://github.com/apache/incubator-netbeans/pull/392 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] geertjanw closed pull request #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo…

geertjanw closed pull request #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo… URL: https://github.com/apache/incubator-netbeans/pull/534 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] geertjanw commented on issue #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo…

geertjanw commented on issue #534: [NETBEANS-721] Jigsaw module system must be initialized in javac befo… URL: https://github.com/apache/incubator-netbeans/pull/534#issuecomment-387648848 OK, merging. This is an automated

[GitHub] timboudreau commented on issue #537: Maven Indexing Optimizations

timboudreau commented on issue #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#issuecomment-387647186 FYI, I've updated the patch to use 2-3 path elements to determine JDK membership. More than that would not be a smart compromise on

[GitHub] geertjanw commented on issue #392: form: Fix compile error under Java 9, method cannot be applied to types

geertjanw commented on issue #392: form: Fix compile error under Java 9, method cannot be applied to types URL: https://github.com/apache/incubator-netbeans/pull/392#issuecomment-387650267 Any reason not to merge this, any potential side effects anticipated?

[GitHub] geertjanw closed pull request #538: [NETBEANS-620] Profiling SQL queries doesn't work under JDK 10

geertjanw closed pull request #538: [NETBEANS-620] Profiling SQL queries doesn't work under JDK 10 URL: https://github.com/apache/incubator-netbeans/pull/538 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jlahoda commented on issue #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation

jlahoda commented on issue #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation URL: https://github.com/apache/incubator-netbeans/pull/504#issuecomment-387275561 On Tue, May 8, 2018 at 3:57 AM, Jesse Glick

[GitHub] JaroslavTulach commented on issue #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation

JaroslavTulach commented on issue #504: Skip CoS copying of class files when the target is already newer, such as from an external compilation URL: https://github.com/apache/incubator-netbeans/pull/504#issuecomment-387279403 I am not following your discussions fully, but the picture I got

[GitHub] timboudreau opened a new pull request #541: Fix maven output window links for newer versions of Maven

timboudreau opened a new pull request #541: Fix maven output window links for newer versions of Maven URL: https://github.com/apache/incubator-netbeans/pull/541 This patch was already submitted (and IIRC, accepted) in the netbeans.org hg repo, but was applied after the Apache contribution

[GitHub] timboudreau commented on issue #537: Maven Indexing Optimizations

timboudreau commented on issue #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#issuecomment-387620302 Just refine the package list - e.g look for java/x instead of java/. Anything that touches class loaders is likely to be orders of

[GitHub] eirikbakke commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener.

eirikbakke commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener. URL: https://github.com/apache/incubator-netbeans/pull/515#issuecomment-387822051 Myself, I can't think of any possible adverse side-effects to this one.

[GitHub] matthiasblaesing commented on issue #540: [NETBEANS-305] Remove references to GPL/LGPL-21 licenses

matthiasblaesing commented on issue #540: [NETBEANS-305] Remove references to GPL/LGPL-21 licenses URL: https://github.com/apache/incubator-netbeans/pull/540#issuecomment-387841640 I updated the PR, as the first push did not properly remove the `o.jdesktop.beansbinding` directory. Travis

[GitHub] matthiasblaesing commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener.

matthiasblaesing commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener. URL: https://github.com/apache/incubator-netbeans/pull/515#issuecomment-387850642 I know that I'm late to the game, but I would try to avoid changing

[GitHub] sdedic commented on issue #522: Fix @PropertyEditorRegistration to work with inner classes

sdedic commented on issue #522: Fix @PropertyEditorRegistration to work with inner classes URL: https://github.com/apache/incubator-netbeans/pull/522#issuecomment-384929313 Best practices should be followed ... test added.

[GitHub] emilianbold commented on issue #518: [NETBEANS-342] Enable G1's String Deduplication

emilianbold commented on issue #518: [NETBEANS-342] Enable G1's String Deduplication URL: https://github.com/apache/incubator-netbeans/pull/518#issuecomment-384886086 String Deduplication sounds good to me. Could you post a link about the -client flag? I just can't google any page about

[GitHub] sdedic opened a new pull request #522: Fix @PropertyEditorRegistration to work with inner classes

sdedic opened a new pull request #522: Fix @PropertyEditorRegistration to work with inner classes URL: https://github.com/apache/incubator-netbeans/pull/522 I found out that when `targetType` is an inner class, the generated layer registration uses `.` as delimiter between outer and inner

[GitHub] emilianbold commented on issue #518: [NETBEANS-342] Enable G1's String Deduplication

emilianbold commented on issue #518: [NETBEANS-342] Enable G1's String Deduplication URL: https://github.com/apache/incubator-netbeans/pull/518#issuecomment-384886846 Ah, here it is: https://docs.oracle.com/javase/8/docs/technotes/tools/unix/java.html > -client > Selects the

[GitHub] JaroslavTulach closed pull request #522: Fix @PropertyEditorRegistration to work with inner classes

JaroslavTulach closed pull request #522: Fix @PropertyEditorRegistration to work with inner classes URL: https://github.com/apache/incubator-netbeans/pull/522 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mcdonnell-john commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

mcdonnell-john commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-384989512 @Chris2011 Yes, I made sure that the NPE wouldn't get thrown again in this scenario.

[GitHub] Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies.

Chris2011 commented on issue #481: [NETBEANS-290] Provided support for hyperlink on dependencies. URL: https://github.com/apache/incubator-netbeans/pull/481#issuecomment-385029936 Is this helpfull or do you need more info? I have spring-boot framework. This is one little part of my pom

[GitHub] matthiasblaesing closed pull request #517: [NETBEANS-718] Added Debian/Ubuntu library folders for Subversion Native binding searchlist.

matthiasblaesing closed pull request #517: [NETBEANS-718] Added Debian/Ubuntu library folders for Subversion Native binding searchlist. URL: https://github.com/apache/incubator-netbeans/pull/517 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it

[GitHub] matthiasblaesing commented on issue #517: [NETBEANS-718] Added Debian/Ubuntu library folders for Subversion Native binding searchlist.

matthiasblaesing commented on issue #517: [NETBEANS-718] Added Debian/Ubuntu library folders for Subversion Native binding searchlist. URL: https://github.com/apache/incubator-netbeans/pull/517#issuecomment-385186289 Thank you - the change is sound and works. Will merge.

[GitHub] matthiasblaesing commented on issue #518: [NETBEANS-342] Enable G1's String Deduplication

matthiasblaesing commented on issue #518: [NETBEANS-342] Enable G1's String Deduplication URL: https://github.com/apache/incubator-netbeans/pull/518#issuecomment-385187603 I agree with the changes - I'll pull these changes in.

[GitHub] matthiasblaesing closed pull request #518: [NETBEANS-342] Enable G1's String Deduplication

matthiasblaesing closed pull request #518: [NETBEANS-342] Enable G1's String Deduplication URL: https://github.com/apache/incubator-netbeans/pull/518 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jlahoda opened a new pull request #523: Avoid failure of 'ant javadoc' for modules that don't have src dir, l…

jlahoda opened a new pull request #523: Avoid failure of 'ant javadoc' for modules that don't have src dir, l… URL: https://github.com/apache/incubator-netbeans/pull/523 …ike c.google.guava or net.java.html This is an

[GitHub] emilianbold commented on issue #465: [NETBEANS-519] Bump Eclipse JGit dependency to latest version

emilianbold commented on issue #465: [NETBEANS-519] Bump Eclipse JGit dependency to latest version URL: https://github.com/apache/incubator-netbeans/pull/465#issuecomment-385149019 Please ask this question on the dev@ mailing list too. Clearly this PR is not about a fix you want to

[GitHub] emilianbold commented on issue #508: [NETBEANS-643] Mercurial Annotate fails on files with spaces in them …

emilianbold commented on issue #508: [NETBEANS-643] Mercurial Annotate fails on files with spaces in them … URL: https://github.com/apache/incubator-netbeans/pull/508#issuecomment-385168340 Is this PR current? Why is that big commented chunk of JSON related code included?

[GitHub] emilianbold commented on issue #524: [NETBEANS-592] Fixes Git History regression

emilianbold commented on issue #524: [NETBEANS-592] Fixes Git History regression URL: https://github.com/apache/incubator-netbeans/pull/524#issuecomment-385170323 Yes, `SearchCriteria.getLimit()` may be -1 for all commits. So your new code will just skip if `remaining` is -1 while

[GitHub] emilianbold opened a new pull request #524: [NETBEANS-592] Fixes Git History regression

emilianbold opened a new pull request #524: [NETBEANS-592] Fixes Git History regression URL: https://github.com/apache/incubator-netbeans/pull/524 This is an automated message from the Apache Git Service. To respond to the

[GitHub] emilianbold closed pull request #513: [NETBEANS-712] Improve label/button alignment in output pane header on Aqua

emilianbold closed pull request #513: [NETBEANS-712] Improve label/button alignment in output pane header on Aqua URL: https://github.com/apache/incubator-netbeans/pull/513 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] jtulach commented on issue #524: [NETBEANS-592] Fixes Git History regression

jtulach commented on issue #524: [NETBEANS-592] Fixes Git History regression URL: https://github.com/apache/incubator-netbeans/pull/524#issuecomment-385168498 I am not sure I get the difference? Can `remaining` be negative?

[GitHub] emilianbold commented on issue #440: [NETBEANS-438] Cannot Sign Platform app due to symlink

emilianbold commented on issue #440: [NETBEANS-438] Cannot Sign Platform app due to symlink URL: https://github.com/apache/incubator-netbeans/pull/440#issuecomment-385167935 I'll check this next week. This is an automated

[GitHub] emilianbold closed pull request #524: [NETBEANS-592] Fixes Git History regression

emilianbold closed pull request #524: [NETBEANS-592] Fixes Git History regression URL: https://github.com/apache/incubator-netbeans/pull/524 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jtulach commented on issue #524: [NETBEANS-592] Fixes Git History regression

jtulach commented on issue #524: [NETBEANS-592] Fixes Git History regression URL: https://github.com/apache/incubator-netbeans/pull/524#issuecomment-385170508 I see. Thanks for finding this out and correcting my mistake. Feel free to integrate.

[GitHub] emilianbold commented on issue #537: Maven Indexing Optimizations

emilianbold commented on issue #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#issuecomment-387888672 I didn't review the patch, just noticed it is references on the mailing list. @geertjanw, isn't 24 hours kinda short?

[GitHub] timboudreau commented on issue #537: Maven Indexing Optimizations

timboudreau commented on issue #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#issuecomment-387905711 It really isn't that exciting a patch. The resulting code does the same things, just much more efficiently. -Tim On Wed, May

[GitHub] eirikbakke commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener.

eirikbakke commented on issue #515: [NETBEANS-406] Fix a potential memory leak involving DocumentUtilities.addPropertyChangeListener. URL: https://github.com/apache/incubator-netbeans/pull/515#issuecomment-387898258 Yes, matthiasblaesing, that works, too. Tested and seems to work. I added

[GitHub] jlahoda opened a new pull request #40: Trying to setup a location for updates, redirecting to the synergy VM…

jlahoda opened a new pull request #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40 … for now. This is an automated message from the

[GitHub] geertjanw commented on issue #541: Fix maven output window links for newer versions of Maven

geertjanw commented on issue #541: Fix maven output window links for newer versions of Maven URL: https://github.com/apache/incubator-netbeans/pull/541#issuecomment-387886163 I don't see any reason not to merge this. Any comments, objections? If no responses, will merge in 24 hours.

[GitHub] jkovalsky commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

jkovalsky commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-387901695 https://netbeans-vm.apache.org/uc/9.0/updates.xml.gz now exists. Please merge this pull

[GitHub] geertjanw closed pull request #525: [NETBEANS-734] Caught exceptions are always non-null.

geertjanw closed pull request #525: [NETBEANS-734] Caught exceptions are always non-null. URL: https://github.com/apache/incubator-netbeans/pull/525 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] geertjanw commented on issue #525: [NETBEANS-734] Caught exceptions are always non-null.

geertjanw commented on issue #525: [NETBEANS-734] Caught exceptions are always non-null. URL: https://github.com/apache/incubator-netbeans/pull/525#issuecomment-387978875 OK, merging. This is an automated message from the

[GitHub] sdedic commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open.

sdedic commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open. URL: https://github.com/apache/incubator-netbeans/pull/507#discussion_r187284421 ## File path:

[GitHub] sdedic commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open.

sdedic commented on a change in pull request #507: [NETBEANS-403] Avoid scrolling to end of file if End is pressed while popup is open. URL: https://github.com/apache/incubator-netbeans/pull/507#discussion_r187284421 ## File path:

[GitHub] rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187295717 ## File path:

[GitHub] rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187295671 ## File path:

[GitHub] sdedic commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array

sdedic commented on a change in pull request #519: [NETBEANS-481] JDK10-LVTI: Added new ErrorRule to fix compiler error on initialization of var type variable with array URL: https://github.com/apache/incubator-netbeans/pull/519#discussion_r187295749 ## File path:

[GitHub] geertjanw commented on issue #521: [NETBEANS-497] Fix for 'var' compound declaration error hints

geertjanw commented on issue #521: [NETBEANS-497] Fix for 'var' compound declaration error hints URL: https://github.com/apache/incubator-netbeans/pull/521#issuecomment-388024397 OK, this is approved by @sdedic. Is there any reason not to merge, any potential side effects?

[GitHub] sdedic commented on issue #528: added unbound generic type argument to Class in BeanNode and Lib

sdedic commented on issue #528: added unbound generic type argument to Class in BeanNode and Lib URL: https://github.com/apache/incubator-netbeans/pull/528#issuecomment-388024366 Don't you want to fix the other warnings in the BeanNode.java file, too :) ?

[GitHub] sdedic commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

sdedic commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187304330 ## File path:

[GitHub] sdedic commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

sdedic commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187303971 ## File path:

[GitHub] rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187325989 ## File path:

[GitHub] rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187326117 ## File path:

[GitHub] rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes

rtaneja1 commented on a change in pull request #533: [NETBEANS-694] : Support convert to var for diamond operator and other fixes URL: https://github.com/apache/incubator-netbeans/pull/533#discussion_r187326248 ## File path:

[GitHub] geertjanw commented on issue #468: nb-javac jars upgrade for NETBEANS-463 fix

geertjanw commented on issue #468: nb-javac jars upgrade for NETBEANS-463 fix URL: https://github.com/apache/incubator-netbeans/pull/468#issuecomment-387980171 Is there a reason not to merge this? This is an automated

[GitHub] geertjanw commented on issue #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property.

geertjanw commented on issue #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property. URL: https://github.com/apache/incubator-netbeans/pull/514#issuecomment-387979834 Any reason not to merge this? I will merge in 24 hours unless

[GitHub] geertjanw commented on issue #415: [NETBEANS-365] Allow Harness to be more Friendly

geertjanw commented on issue #415: [NETBEANS-365] Allow Harness to be more Friendly URL: https://github.com/apache/incubator-netbeans/pull/415#issuecomment-387980059 What is the status of this PR? This is an automated

[GitHub] emilianbold commented on a change in pull request #537: Maven Indexing Optimizations

emilianbold commented on a change in pull request #537: Maven Indexing Optimizations URL: https://github.com/apache/incubator-netbeans/pull/537#discussion_r187236285 ## File path: maven.indexer/src/org/netbeans/modules/maven/indexer/MatchWords.java ## @@ -0,0 +1,109 @@

[GitHub] geertjanw closed pull request #495: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project

geertjanw closed pull request #495: [NETBEANS-648] Cannot select "Source/Binary Format : 10" in a maven project URL: https://github.com/apache/incubator-netbeans/pull/495 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] vieiro commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

vieiro commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-387942502 NOTE: HTTP 302 (moved temporarily) is better than HTTP 301 (moved permanently) in this case.

[GitHub] neilcsmith-net commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM…

neilcsmith-net commented on issue #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40#issuecomment-387983211 -1 to merging yet :smile: OK, bit late. The redirect should be to https on the VM,

[GitHub] JaroslavTulach commented on issue #415: [NETBEANS-365] Allow Harness to be more Friendly

JaroslavTulach commented on issue #415: [NETBEANS-365] Allow Harness to be more Friendly URL: https://github.com/apache/incubator-netbeans/pull/415#issuecomment-387984766 I am not convinced this PR shall be merged. -1 from me. Feel free to find other +1 to overrule my opinion.

[GitHub] vieiro closed pull request #40: Trying to setup a location for updates, redirecting to the synergy VM…

vieiro closed pull request #40: Trying to setup a location for updates, redirecting to the synergy VM… URL: https://github.com/apache/incubator-netbeans-website/pull/40 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] geertjanw commented on issue #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property.

geertjanw commented on issue #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property. URL: https://github.com/apache/incubator-netbeans/pull/514#issuecomment-387980860 OK, since @sdedic approved, I will merge it now.

[GitHub] geertjanw closed pull request #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property.

geertjanw closed pull request #514: [NETBEANS-713] Have HighlightingManager properly respond to changes in excludes/includes client property. URL: https://github.com/apache/incubator-netbeans/pull/514 This is a PR merged from a forked repository. As GitHub hides the original diff on

[GitHub] geertjanw commented on issue #523: Avoid failure of 'ant javadoc' for modules that don't have src dir, l…

geertjanw commented on issue #523: Avoid failure of 'ant javadoc' for modules that don't have src dir, l… URL: https://github.com/apache/incubator-netbeans/pull/523#issuecomment-387979467 Nothing contentious here, simply going to merge this.

[GitHub] geertjanw commented on issue #520: [NETBEANS-317] Ensuring that jars that are augmented with OSGi metada…

geertjanw commented on issue #520: [NETBEANS-317] Ensuring that jars that are augmented with OSGi metada… URL: https://github.com/apache/incubator-netbeans/pull/520#issuecomment-387979242 Should this be merged, any objections? Does @matthiasblaesing comment need to be responded to, does

  1   2   3   4   5   6   7   8   9   10   >