[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-573360169 > I believe this is resolved by: #1833 (although it is again the case of no data from the server -> nothing to show - but I believe this particular server refuses to return the data at the beginning and then starts to provide them, so it should show the navigator content eventually.) Ok, so before we can merge this to get it into the next version, we need to wait for the merge for #1833. IMHO, to fix this bug before this PR. > Sorry, but these two don't seem to be related to TypeScript at all. Are you sure it doesn't happen on a recent master build? So I cloned netbeans, built it on master, used the command line instructions to get your PR, opened typescript.editor built just this project and run it into a new IDE build with JDK 1.8 with a clean testuserdir. I think everything is inside of the nbbuild folder for that, right? But ok, if you say that this is not related to TS then I'm fine with that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-57396 But yes at the end, it seems that the project ts version overrides the hardcoded one. I tried Optional Chaining and Nullish Coalescing features and no errors in the editor. So this is ok. But because of the other problems, I couldn't check whether a restart of NetBeans is needed or not. This is the end of my research for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-573328299 And when I try to open the main.ts file, I got this exception: ``` org.eclipse.lsp4j.jsonrpc.ResponseErrorException: Request textDocument/documentSymbol failed with message: Error processing request. No Project. Error: No Project. at Object.ThrowNoProject (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:124630:23) at IOSession.Session.getFileAndLanguageServiceForSyntacticOperation (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:130979:42) at IOSession.Session.getNavigationTree (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:131338:31) at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:130198:61) at c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:131671:88 at IOSession.Session.executeWithRequestId (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:131662:28) at IOSession.Session.executeCommand (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:131671:33) at IOSession.Session.onMessage (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:131693:35) at Interface. (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:132984:27) at Interface.emit (events.js:198:13) at Interface._onLine (readline.js:308:10) at Interface._normalWrite (readline.js:451:12) at Socket.ondata (readline.js:165:10) at Socket.emit (events.js:198:13) at addChunk (_stream_readable.js:288:12) at readableAddChunk (_stream_readable.js:269:11) at Socket.Readable.push (_stream_readable.js:224:10) at Pipe.onStreamRead [as onread] (internal/stream_base_commons.js:94:17) at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleResponse(RemoteEndpoint.java:209) at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:193) at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:192) at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:94) at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:113) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Caused: java.util.concurrent.ExecutionException at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895) [catch] at org.netbeans.modules.lsp.client.bindings.NavigatorPanelImpl.run(NavigatorPanelImpl.java:142) at org.netbeans.modules.lsp.client.LSPBindings.lambda$addBackgroundTask$6(LSPBindings.java:245) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) ``` I see smth like No project but it is an HTML5 project, created with NetBeans. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-573327788 @jlahoda I got a NPE when I do this: * take a TS file and type `export default inter` * hit ctrl + space for code completion * choose interface from the code completion * list stays open and press space. * NPE appears ``` org.eclipse.lsp4j.jsonrpc.ResponseErrorException: Request textDocument/documentSymbol failed with message: Error processing request. No Project. Error: No Project. at Object.ThrowNoProject (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:124630:23) at IOSession.Session.getFileAndLanguageServiceForSyntacticOperation (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:130979:42) at IOSession.Session.getNavigationTree (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:131338:31) at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:130198:61) at c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:131671:88 at IOSession.Session.executeWithRequestId (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:131662:28) at IOSession.Session.executeCommand (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:131671:33) at IOSession.Session.onMessage (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:131693:35) at Interface. (c:\Projekte\Others\Vue TypeScript Live Search Sample\node_modules\typescript\lib\tsserver.js:132984:27) at Interface.emit (events.js:198:13) at Interface._onLine (readline.js:308:10) at Interface._normalWrite (readline.js:451:12) at Socket.ondata (readline.js:165:10) at Socket.emit (events.js:198:13) at addChunk (_stream_readable.js:288:12) at readableAddChunk (_stream_readable.js:269:11) at Socket.Readable.push (_stream_readable.js:224:10) at Pipe.onStreamRead [as onread] (internal/stream_base_commons.js:94:17) at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleResponse(RemoteEndpoint.java:209) at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:193) at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.handleMessage(StreamMessageProducer.java:192) at org.eclipse.lsp4j.jsonrpc.json.StreamMessageProducer.listen(StreamMessageProducer.java:94) at org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor.run(ConcurrentMessageProcessor.java:113) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748) Caused: java.util.concurrent.ExecutionException at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1895) [catch] at org.netbeans.modules.lsp.client.bindings.NavigatorPanelImpl.run(NavigatorPanelImpl.java:142) at org.netbeans.modules.lsp.client.LSPBindings.lambda$addBackgroundTask$6(LSPBindings.java:245) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) ``` This is my project: https://github.com/Chris2011/Vue-TypeScript-Live-Search-Sample. I wrote code insie of the main.ts file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-573165355 @jlahoda @matthiasblaesing is this ok for use: https://github.com/Everlaw/nbts/issues/151#issuecomment-573156212 In short: > It's just an edit of NetBeans 8.0.2's JS icon and may be used under the terms of the CDDL version 1.0 and/or the GPL version 2.0 with Classpath Exception. It is about this icon: https://github.com/Everlaw/nbts/blob/master/src/netbeanstypescript/resources/typescript.png from the nbts plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-573165355 @jlahoda @matthiasblaesing is this ok for: https://github.com/Everlaw/nbts/issues/151#issuecomment-573156212 In short: > It's just an edit of NetBeans 8.0.2's JS icon and may be used under the terms of the CDDL version 1.0 and/or the GPL version 2.0 with Classpath Exception. It is about this icon: https://github.com/Everlaw/nbts/blob/master/src/netbeanstypescript/resources/typescript.png from the nbts plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-573165355 @jlahoda @matthiasblaesing is this ok to use it: https://github.com/Everlaw/nbts/issues/151#issuecomment-573156212 In short: > It's just an edit of NetBeans 8.0.2's JS icon and may be used under the terms of the CDDL version 1.0 and/or the GPL version 2.0 with Classpath Exception. It is about this icon: https://github.com/Everlaw/nbts/blob/master/src/netbeanstypescript/resources/typescript.png from the nbts plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-573034539 I'm testing it now. Just to let you know. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-572793986 Yes, there is definetely no problem to have 2.8.3 as a backup if there is no other version. I mean it is the same on the local machine. I can npm install typescript global and project specific. So thats fine. The user only needs to have the option to change the TS version to a custom one or the project TSC needs to take over the NetBeans one :). So if this is still possible, w/o having a special gui for than I would say merge. Hope the restart is not needed, when I change the version in my project to another one or up/downgrade if I have some trouble with version compatibilites. Just asking. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-572780479 IMHO, you can't set a specific version in the ecosystem of JS. If you use it today, in a week it could be obsolete. It is not like in Java, or in PHP. Just saying. I know that it is possible to change it, as you already said it, but it is not obvious to every user of NetBeans. I also need to research how to do that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-572777506 The jump from 2.8.* to 3.7.* is huge with 3.7. Optional Chaining and Nullish Coalescing are only 2 of an amount of features. I can't even give you all of the features from 2.8.* to 3.7.4 because it is huge. Just this link: https://www.typescriptlang.org/docs/handbook/release-notes/overview.html. So at the end it would be better to give the user the option via an option in the project properties to choose the specific TSC that I want. Like in the PHP projects where I can say I want this PHP version for my project or Java projects where I can choose a different JDK to compile. Here it is needed that the user, like me, install the newest TSC on my machine and set the executable to my project. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 edited a comment on issue #1692: Add TypeScript editor
Chris2011 edited a comment on issue #1692: Add TypeScript editor URL: https://github.com/apache/netbeans/pull/1692#issuecomment-572278363 Ok, thx for the info. Is there a possibilty to change the TypeScript version manually? The NBTS project has it, since a couple of versions, because this was a requested feature. So if this is possible, there is no need to update to the latest version, I mean sure it is, but if I need a newer version, I can do that by my own. A lot of stuff in the JS ecosystem changes in a very short time. Just as an info. In the eco system of Node and TS and the TS Compiler and the LSP for that. like this is working in VS Code, it should work very well, I guess. It was just a question from me, I thought you have a problem with compatibilities with the LSP and TS, I didn't checked it by myself with other versions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
