[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367212250 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: OK, they seem to be really close in the existing defaults as well. Maybe they're supposed to look the same... (nevermind this comment, I was looking at the BlueTheme) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367213204 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: Sure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367212250 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: OK, they seem to be really close in the existing defaults as well. Maybe they're supposed to look the same... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207379 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: What does "inferred" mean? This green color is almost identical to that of nbcoverage-covered. It should be some distinct color. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207379 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + + Review comment: What does "inferred" mean? This green color is almost identical to that of nbcoverage-covered. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367207918 ## File path: platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/fontscolors/FlatLafDark-highlights.xml ## @@ -49,4 +49,8 @@ + + Review comment: This one is a neutral grey, but it should be some variant of red. Perhaps try 813438 instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights.
eirikbakke commented on a change in pull request #1875: [NETBEANS-3700] No more harcoding for Code Coverage Highlights. URL: https://github.com/apache/netbeans/pull/1875#discussion_r367205572 ## File path: ide/defaults/src/org/netbeans/modules/defaults/BlueTheme-editor.xml ## @@ -62,4 +62,9 @@ + + + + Review comment: Why "nbcoverage"? Perhaps just "coverage"? (Everything in NetBeans is NetBeans...) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
