[GitHub] [netbeans] neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t…
neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t… URL: https://github.com/apache/netbeans/pull/1556#issuecomment-541732207 Closing in favour of #1560 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t…
neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t… URL: https://github.com/apache/netbeans/pull/1556#issuecomment-540984953 @jlahoda thanks! I see two test failures. First is with RAT - think license-info files have wrong links for the jar.external files now?! Second is ergonomics - will retrigger to make sure it's related - have seen that fail without cause a few times. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t…
neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t… URL: https://github.com/apache/netbeans/pull/1556#issuecomment-539925280 @jlahoda totally understand your problem over the JavaFX approach. That they get included when doing a straight build of the source is an annoyance here too. We need some options to disable that - causes issues in testing releases as well. However, the binary builds as done on the build server do not include the extra cluster at all. The binary build is Apache compliant AFAIK. And JavaFX must be explicitly enabled. What we need to also do is document better how an end user can build that compliant binary locally. However, for NB 11.2 I'd prefer we copy the JavaFX approach fully and then seek to address the above issues as soon as master reopens for 11.3? Or revert and switch back to plan B and a temporary update centre? I can't remember the exact issues with the JavaFX support. @matthiasblaesing probably knows better. I think we initially thought the binaries were being included in places they shouldn't, but was actually more to do with licenses showing up where they shouldn't? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t…
neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t… URL: https://github.com/apache/netbeans/pull/1556#issuecomment-539625631 @jlahoda can you clarify what being part of source build but not binary build means? Concerned about us replicating a blocking issue that arose with JavaFX. Out of interest, having looked at JavaFX files being in `external` rather than `release/modules/ext` is there a reason this one has to be done differently? Also, eg. https://github.com/apache/netbeans/blob/master/extra/libs.javafx.linux/nbproject/project.properties#L23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t…
neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t… URL: https://github.com/apache/netbeans/pull/1556#issuecomment-539603313 @jlahoda I noticed - just retriggered to see, although looked like it might be a valid issue - complaining about one of the nb-javac jars. Don't worry, I merge nothing until it's green - just gives me headaches! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t…
neilcsmith-net commented on issue #1556: Must include the extra/nbjavac* modules in the 3rdparty cluster, so t… URL: https://github.com/apache/netbeans/pull/1556#issuecomment-539528612 The JavaFX ones are excluded though. We should be consistent one way or another IMO. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
