[GitHub] neilcsmith-net commented on issue #425: Netbeans 352
neilcsmith-net commented on issue #425: Netbeans 352 URL: https://github.com/apache/incubator-netbeans/pull/425#issuecomment-368455829 @JaroslavTulach fair enough. I've obviously made a lousy case for why this is impossible to fix _inside_ the platform, sorry! :smile: I've opened an issue in JIRA, linked to the original issue - not sure it's good discussing this on a PR. Maybe we should close this and find consensus there? Issues related to this do crop up now and again, but it would be good to have a solution that you can be in favour of! And also one that solves @SirIntellegence problem. https://issues.apache.org/jira/browse/NETBEANS-427 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] neilcsmith-net commented on issue #425: Netbeans 352
neilcsmith-net commented on issue #425: Netbeans 352 URL: https://github.com/apache/incubator-netbeans/pull/425#issuecomment-368035513 To use pluggable formatters we'd still have to be able to wrap or override `NbBundle.getMessage()` to use our own `MessageFormat` to achieve this? It's not a proposal to break the idea of referentially transparent you're talking about then - it's about being able to override / wrap the default behaviour of `NbBundle.getMessage()`. That _could_ be abused, but the proposal is meant to be that you still get the same output for any distinct set of input arguments. At the moment there is an assumption that a module is providing all / the right inputs you need to construct the output message you want, but this doesn't always hold in a platform application (it probably does for translations). The OP's problem is one, but there are lots of times you might want to calculate something differently eg. turning an `X of Y files` message into an `X files remaining` message, etc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] neilcsmith-net commented on issue #425: Netbeans 352
neilcsmith-net commented on issue #425: Netbeans 352 URL: https://github.com/apache/incubator-netbeans/pull/425#issuecomment-367251507 Surely `NbBundle.getMessage()` isn't referentially transparent already? At least with respect to locale and branding token, otherwise there wouldn't be a need for it. Filter might have been a bad choice of word (think FilterInputStream) - but, yes, really I'm wanting a way to dynamically (well, at run time) transform the input arguments! Taking a step back, branding cannot achieve what the OP wants to achieve because it's static, and here there's a need to transform the input arguments into the message via code. I've come across, and seen other people with, similar problems in various different areas of the platform, and sometimes hacked around them (including exactly what the OP is doing for this). I was trying to come up with the least intrusive way we could fix it in one place, rather than PR's all over the platform and / or requiring people to rewrite big chunks of it. They all come down to needing to change the input arguments to (or wrap entirely) `NbBundle.getMessage()`, _from code_. Am I right in thinking there is no way to do that currently? Do you have ideas on a better way to achieve this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] neilcsmith-net commented on issue #425: Netbeans 352
neilcsmith-net commented on issue #425: Netbeans 352 URL: https://github.com/apache/incubator-netbeans/pull/425#issuecomment-367038068 @JaroslavTulach the actual issue here cannot be handled by branding as far as I can see - there needs to be a way to filter / change the arguments passed into `NbBundle.getMessage()` to do this. As I mentioned on the first PR for this, I'm -1 to adding a new API to try and fix this one issue, because it's not the only place I've seen this problem. I did suggest we provide a way to filter input arguments - https://github.com/apache/incubator-netbeans/pull/393#issuecomment-362662452 What would be your thoughts on trying to do that instead? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
