[jira] [Created] (OFBIZ-9578) Collection added to itself

2017-08-14 Thread JC (JIRA)
JC created OFBIZ-9578: - Summary: Collection added to itself Key: OFBIZ-9578 URL: https://issues.apache.org/jira/browse/OFBIZ-9578 Project: OFBiz Issue Type: Bug Components: framework

[jira] [Updated] (OFBIZ-9306) Check there are no white spaces around the name of a form field when updating a form

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9306: --- Attachment: OFBIZ-9306-ModelFormField.java.patch Michael, Oh right, a new pair of eyes was

[jira] [Commented] (OFBIZ-9306) Check there are no white spaces around the name of a form field when updating a form

2017-08-14 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126120#comment-16126120 ] Michael Brohl commented on OFBIZ-9306: -- Jacques, if returnValue is null, you'll get a

[jira] [Commented] (OFBIZ-9571) [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125368#comment-16125368 ] Jacques Le Roux commented on OFBIZ-9571: In a 1st step at revision: 1804953, I did an easy global

[jira] [Assigned] (OFBIZ-9400) GenericServiceJob.failed(Throwable) avoid logging stacktraces for non technical service semaphore exceptions

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9400: -- Assignee: Jacques Le Roux > GenericServiceJob.failed(Throwable) avoid logging

[jira] [Updated] (OFBIZ-9486) [FB] Package org.apache.ofbiz.accounting.thirdparty.gosoftware

2017-08-14 Thread Kyra Pritzel-Hentley (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyra Pritzel-Hentley updated OFBIZ-9486: Attachment:

[jira] [Updated] (OFBIZ-9486) [FB] Package org.apache.ofbiz.accounting.thirdparty.gosoftware

2017-08-14 Thread Kyra Pritzel-Hentley (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyra Pritzel-Hentley updated OFBIZ-9486: Flags: Patch > [FB] Package org.apache.ofbiz.accounting.thirdparty.gosoftware >

[jira] [Updated] (OFBIZ-9486) [FB] Package org.apache.ofbiz.accounting.thirdparty.gosoftware

2017-08-14 Thread Kyra Pritzel-Hentley (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyra Pritzel-Hentley updated OFBIZ-9486: Attachment:

[jira] [Commented] (OFBIZ-9486) [FB] Package org.apache.ofbiz.accounting.thirdparty.gosoftware

2017-08-14 Thread Kyra Pritzel-Hentley (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125523#comment-16125523 ] Kyra Pritzel-Hentley commented on OFBIZ-9486: - Hello Jacques, I removed the modifier because

[jira] [Commented] (OFBIZ-9486) [FB] Package org.apache.ofbiz.accounting.thirdparty.gosoftware

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125425#comment-16125425 ] Jacques Le Roux commented on OFBIZ-9486: Same for RitaApi. > [FB] Package

[jira] [Commented] (OFBIZ-9486) [FB] Package org.apache.ofbiz.accounting.thirdparty.gosoftware

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125423#comment-16125423 ] Jacques Le Roux commented on OFBIZ-9486: Hi Kyra, I did not review all, but why did you remove

[jira] [Closed] (OFBIZ-9397) New UtilMisc method collectionToString(...) building safely a String with the given collection and delimiter

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9397. -- Resolution: Implemented Fix Version/s: Upcoming Release Thanks Martin, Your patch is in

[jira] [Created] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO

2017-08-14 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-9572: -- Summary: Replace all "BigDecimal ZERO" by BigDecimal.ZERO Key: OFBIZ-9572 URL: https://issues.apache.org/jira/browse/OFBIZ-9572 Project: OFBiz Issue

[jira] [Updated] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9572: --- Description: Using "BigDecimal ZERO" instead of BigDecimal.ZERO does not add anything but

[jira] [Comment Edited] (OFBIZ-9571) [DEPRECATION] Replace BigDecimal.ROUND_* by RoundingMode.*

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125368#comment-16125368 ] Jacques Le Roux edited comment on OFBIZ-9571 at 8/14/17 9:37 AM: - In a 1st

[jira] [Closed] (OFBIZ-9400) GenericServiceJob.failed(Throwable) avoid logging stacktraces for non technical service semaphore exceptions

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9400. -- Resolution: Implemented Fix Version/s: Upcoming Release Thanks Martin, Your patch is in

[jira] [Assigned] (OFBIZ-9397) New UtilMisc method collectionToString(...) building safely a String with the given collection and delimiter

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9397: -- Assignee: Jacques Le Roux > New UtilMisc method collectionToString(...) building

[jira] [Commented] (OFBIZ-9394) FileUtil.java: New method to get absolute path from given relative path on base of ofbiz.home dir

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125309#comment-16125309 ] Jacques Le Roux commented on OFBIZ-9394: That's right Deepak, but I find Martin's proposition

[jira] [Assigned] (OFBIZ-9306) Check there are no white spaces in the name of a form field when updating a form

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9306: -- Assignee: Jacques Le Roux > Check there are no white spaces in the name of a form

[jira] [Commented] (OFBIZ-9558) Manage deprecated service on the ModelService

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125591#comment-16125591 ] Jacques Le Roux commented on OFBIZ-9558: I'm waiting a bit in this thread

[jira] [Updated] (OFBIZ-9558) Manage deprecated service on the ModelService

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9558: --- Description: Following the thread https://s.apache.org/6PzU on how manage the deprecated

[jira] [Updated] (OFBIZ-9574) [FB] Package org.apache.ofbiz.base.test

2017-08-14 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-9574: - Attachment: OFBIZ-9574_org.apache.ofbiz.base.test_bugfixes.patch - fixed Diamond Operators did

[jira] [Created] (OFBIZ-9576) [FB] Package org.apache.ofbiz.base.util.cache.test

2017-08-14 Thread Dennis Balkir (JIRA)
Dennis Balkir created OFBIZ-9576: Summary: [FB] Package org.apache.ofbiz.base.util.cache.test Key: OFBIZ-9576 URL: https://issues.apache.org/jira/browse/OFBIZ-9576 Project: OFBiz Issue Type:

[jira] [Created] (OFBIZ-9574) [FB] Package org.apache.ofbiz.base.test

2017-08-14 Thread Dennis Balkir (JIRA)
Dennis Balkir created OFBIZ-9574: Summary: [FB] Package org.apache.ofbiz.base.test Key: OFBIZ-9574 URL: https://issues.apache.org/jira/browse/OFBIZ-9574 Project: OFBiz Issue Type: Sub-task

[jira] [Created] (OFBIZ-9575) [FB] Package org.apache.ofbiz.base.util.cache

2017-08-14 Thread Dennis Balkir (JIRA)
Dennis Balkir created OFBIZ-9575: Summary: [FB] Package org.apache.ofbiz.base.util.cache Key: OFBIZ-9575 URL: https://issues.apache.org/jira/browse/OFBIZ-9575 Project: OFBiz Issue Type:

[jira] [Closed] (OFBIZ-9333) Random failings of tests on Buildbot

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9333. -- Resolution: Cannot Reproduce Assignee: Jacques Le Roux Seems that since INFRA-14463 I

[jira] [Created] (OFBIZ-9573) [FB] Package org.apache.ofbiz.base.start

2017-08-14 Thread Dennis Balkir (JIRA)
Dennis Balkir created OFBIZ-9573: Summary: [FB] Package org.apache.ofbiz.base.start Key: OFBIZ-9573 URL: https://issues.apache.org/jira/browse/OFBIZ-9573 Project: OFBiz Issue Type: Sub-task

[jira] [Updated] (OFBIZ-9573) [FB] Package org.apache.ofbiz.base.start

2017-08-14 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-9573: - Attachment: OFBIZ-9573_org.apache.ofbiz.base.start_bugfixes.patch - fixed Diamond Operators

[jira] [Updated] (OFBIZ-9575) [FB] Package org.apache.ofbiz.base.util.cache

2017-08-14 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-9575: - Attachment: OFBIZ-9575_org.apache.ofbiz.base.util.cache_bugfixes.patch - fixed Diamond Operators

[jira] [Commented] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO

2017-08-14 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125805#comment-16125805 ] Gil Portenseigne commented on OFBIZ-9572: - +1 on removing variable declaration and using

[jira] [Commented] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125841#comment-16125841 ] Jacques Le Roux commented on OFBIZ-9572: Thanks Gil, Indeed I finally see no reasons to use

[jira] [Comment Edited] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO

2017-08-14 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125805#comment-16125805 ] Gil Portenseigne edited comment on OFBIZ-9572 at 8/14/17 3:30 PM: -- +1 on

[jira] [Comment Edited] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125841#comment-16125841 ] Jacques Le Roux edited comment on OFBIZ-9572 at 8/14/17 3:32 PM: - Thanks

[jira] [Updated] (OFBIZ-9306) Check there are no white spaces in the name of a form field when updating a form

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9306: --- Attachment: OFBIZ-9306-ModelFormField.java.patch It seems to me that a name should not be

[jira] [Commented] (OFBIZ-9306) Check there are no white spaces in the name of a form field when updating a form

2017-08-14 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125775#comment-16125775 ] Michael Brohl commented on OFBIZ-9306: -- I agree with the trim, but you should check for null first.

[jira] [Commented] (OFBIZ-9486) [FB] Package org.apache.ofbiz.accounting.thirdparty.gosoftware

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125747#comment-16125747 ] Jacques Le Roux commented on OFBIZ-9486: Hi Kyra, I guess it was a mistake, actually in your 1st

[jira] [Updated] (OFBIZ-9576) [FB] Package org.apache.ofbiz.base.util.cache.test

2017-08-14 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-9576: - Attachment: OFBIZ-9576_org.apache.ofbiz.base.util.cache.test_bugfixes.patch - fixed Diamond

[jira] [Updated] (OFBIZ-9306) Check there are no white spaces around the name of a form field when updating a form

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9306: --- Summary: Check there are no white spaces around the name of a form field when updating a form

[jira] [Commented] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125965#comment-16125965 ] Jacques Le Roux commented on OFBIZ-9572: To be completly clear: # BigDecimal.ZERO is the real zero

[jira] [Updated] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9572: --- Description: Using "BigDecimal ZERO" instead of BigDecimal.ZERO does not add anything but

[jira] [Updated] (OFBIZ-9572) Replace all "BigDecimal ZERO" by BigDecimal.ZERO

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9572: --- Description: Using "BigDecimal ZERO" instead of BigDecimal.ZERO does not add anything but

[jira] [Commented] (OFBIZ-9306) Check there are no white spaces around the name of a form field when updating a form

2017-08-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125990#comment-16125990 ] Jacques Le Roux commented on OFBIZ-9306: Thanks Michael, Why do you think introducing a check for

[jira] [Created] (OFBIZ-9577) Manage File upload with auto-fields-service

2017-08-14 Thread Nicolas Malin (JIRA)
Nicolas Malin created OFBIZ-9577: Summary: Manage File upload with auto-fields-service Key: OFBIZ-9577 URL: https://issues.apache.org/jira/browse/OFBIZ-9577 Project: OFBiz Issue Type: