[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml

2018-02-02 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350495#comment-16350495 ] Dennis Balkir commented on OFBIZ-10146: --- I just added a new patch, this should work with the

[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350429#comment-16350429 ] Jacques Le Roux commented on OFBIZ-10146: - OK the patch does not completely apply, it seems

[jira] [Assigned] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10146: --- Assignee: Jacques Le Roux > Removing of loadBestSellingCategory and all related

[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml

2018-02-02 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350449#comment-16350449 ] Dennis Balkir commented on OFBIZ-10146: --- Hi [~jacques.le.roux], I'll take a look. This may be the

[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml

2018-02-02 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350491#comment-16350491 ] Nicolas Malin commented on OFBIZ-10146: --- My fault, with the issue OFBIZ-10031 these services has

[jira] [Commented] (OFBIZ-9993) Convert CommonPermissionServices.xml mini lang to groovy

2018-02-02 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350519#comment-16350519 ] Dennis Balkir commented on OFBIZ-9993: -- Hi Nicolas, actually I got this too. I tested the services

[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-02-02 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350487#comment-16350487 ] Dennis Balkir commented on OFBIZ-5157: -- Hi Jacques, I can do that as soon as I have some free time.

[jira] [Commented] (OFBIZ-10188) Add new FileUtil methods for zip management

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350421#comment-16350421 ] Jacques Le Roux commented on OFBIZ-10188: - Thanks Gil, I guess you agree about using

[jira] [Updated] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml

2018-02-02 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10146: -- Attachment: OFBIZ-10146.patch > Removing of loadBestSellingCategory and all related methods in

[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-02-02 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350570#comment-16350570 ] Dennis Balkir commented on OFBIZ-5157: -- It doesn't look like I can assign myself to this.. > Error

[jira] [Assigned] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-02-02 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-5157: Assignee: Dennis Balkir (was: Jacques Le Roux) > Error on createShoppingListItem when

[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-02-02 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350647#comment-16350647 ] Michael Brohl commented on OFBIZ-5157: -- Dennis was not assigned to the contributors role, I just

[jira] [Commented] (OFBIZ-10196) Set security object on groovy context

2018-02-02 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350540#comment-16350540 ] Dennis Balkir commented on OFBIZ-10196: --- I know, this is closed, but I would propose to put the

[jira] [Updated] (OFBIZ-10196) Set security object on groovy context

2018-02-02 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Balkir updated OFBIZ-10196: -- Attachment: 10196.patch > Set security object on groovy context >

[jira] [Closed] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10146. --- Resolution: Implemented Fix Version/s: Upcoming Branch Thanks Dennis, Your patch is

[jira] [Commented] (OFBIZ-10196) Set security object on groovy context

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350637#comment-16350637 ] Jacques Le Roux commented on OFBIZ-10196: - +1 Good idea Dennis > Set security object on groovy

[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350719#comment-16350719 ] Jacques Le Roux commented on OFBIZ-5157: Thanks Michael > Error on createShoppingListItem when

[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350552#comment-16350552 ] Jacques Le Roux commented on OFBIZ-10146: - Thank you both, I apply and commit... > Removing of

[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350633#comment-16350633 ] Jacques Le Roux commented on OFBIZ-5157: Not sure why, anyway I know you are on it ;) > Error on

[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350549#comment-16350549 ] Jacques Le Roux commented on OFBIZ-5157: OK clear, I can't assign you but that's no pb > Error on

[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350563#comment-16350563 ] Jacques Le Roux commented on OFBIZ-5157: BTW, I think you can > Error on createShoppingListItem

[jira] [Commented] (OFBIZ-10164) Splitter Widget

2018-02-02 Thread James Yong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351283#comment-16351283 ] James Yong commented on OFBIZ-10164: Hi all, Okay. The splitter can be implemented as a separate

[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy

2018-02-02 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350115#comment-16350115 ] Dennis Balkir commented on OFBIZ-10031: --- Hi Nicolas, I reviewed the changes you made and I think

[jira] [Commented] (OFBIZ-5157) Error on createShoppingListItem when adding item to cart as anonymous

2018-02-02 Thread Dennis Balkir (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350129#comment-16350129 ] Dennis Balkir commented on OFBIZ-5157: -- [~jacques.le.roux] I see, this was not really a good patch I

[jira] [Closed] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2018-02-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8411. -- Thanks Arun, closing > popup image takes full width of browser window for ecommerce multiflex

[jira] [Commented] (OFBIZ-10188) Add new FileUtil methods for zip management

2018-02-02 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350029#comment-16350029 ] Gil Portenseigne commented on OFBIZ-10188: -- zos.setLevel(9) can be rewritten to

[jira] [Comment Edited] (OFBIZ-10188) Add new FileUtil methods for zip management

2018-02-02 Thread Gil Portenseigne (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350029#comment-16350029 ] Gil Portenseigne edited comment on OFBIZ-10188 at 2/2/18 9:29 AM: --