[jira] [Updated] (OFBIZ-10646) Clean some Groovy files in base component

[ https://issues.apache.org/jira/browse/OFBIZ-10646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10646: Description: Following discussion at [https://markmail.org/message/y3izmnxd7jd6jbkf] we

[jira] [Closed] (OFBIZ-10646) Clean some Groovy files in base and common components

[ https://issues.apache.org/jira/browse/OFBIZ-10646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10646. --- Resolution: Implemented Assignee: Jacques Le Roux Fix Version/s: Upcoming

[jira] [Commented] (OFBIZ-10611) Allow unit tests to be written in Groovy

[ https://issues.apache.org/jira/browse/OFBIZ-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684725#comment-16684725 ] Jacques Le Roux commented on OFBIZ-10611: - At revision: 1846485, I removed FileUtilTests.groovy

[jira] [Commented] (OFBIZ-10214) Update build.gradle to the latest dependencies

[ https://issues.apache.org/jira/browse/OFBIZ-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684765#comment-16684765 ] Jacques Le Roux commented on OFBIZ-10214: - I forgot to attach the [^OFBIZ-10214-plugins.patch]

[jira] [Updated] (OFBIZ-10646) Clean some Groovy files in base and common components

[ https://issues.apache.org/jira/browse/OFBIZ-10646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10646: Summary: Clean some Groovy files in base and common components (was: Clean some Groovy

[jira] [Comment Edited] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683472#comment-16683472 ] Jacques Le Roux edited comment on OFBIZ-10645 at 11/12/18 9:46 AM: --- Hi

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683545#comment-16683545 ] Pierre Smits commented on OFBIZ-4160: - I agree. let's not dilute this issue (too much). > Tax not

[jira] [Closed] (OFBIZ-10611) Allow unit tests to be written in Groovy

[ https://issues.apache.org/jira/browse/OFBIZ-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10611. --- Resolution: Implemented Thanks Mathieu, Your patch is in trunk at revision: 1846393 I had

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683472#comment-16683472 ] Jacques Le Roux commented on OFBIZ-10645: - Hi Aditya, I'm all for returning Optionals instead

[jira] [Assigned] (OFBIZ-10611) Allow unit tests to be written in Groovy

[ https://issues.apache.org/jira/browse/OFBIZ-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10611: --- Assignee: Jacques Le Roux > Allow unit tests to be written in Groovy >

[jira] [Comment Edited] (OFBIZ-10327) CatalogServices #createProductCategoryAttribute doesn't check for existing attributes

[ https://issues.apache.org/jira/browse/OFBIZ-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683480#comment-16683480 ] Benjamin Jugl edited comment on OFBIZ-10327 at 11/12/18 9:49 AM: - It

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683456#comment-16683456 ] Mathieu Lirzin commented on OFBIZ-10645: What I mean is that you can use

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

[ https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683521#comment-16683521 ] Benjamin Jugl commented on OFBIZ-4160: -- That is exactly how it is used in Germany and I think most

[jira] [Comment Edited] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683760#comment-16683760 ] Jacques Le Roux edited comment on OFBIZ-10645 at 11/12/18 12:55 PM:

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683597#comment-16683597 ] Aditya Sharma commented on OFBIZ-10645: --- Thanks  [~mthl] and [~jacques.le.roux] :). Makes sense. I

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683738#comment-16683738 ] Jacques Le Roux commented on OFBIZ-10645: - Hi Aditya, bq. I prefer the same but still couldn't

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683798#comment-16683798 ] Aditya Sharma commented on OFBIZ-10645: --- So we can proceed with only checking entity-name then, as

[jira] [Commented] (OFBIZ-10611) Allow unit tests to be written in Groovy

[ https://issues.apache.org/jira/browse/OFBIZ-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683641#comment-16683641 ] Mathieu Lirzin commented on OFBIZ-10611: Thanks Jacques! > Allow unit tests to be written in

[jira] [Commented] (OFBIZ-10327) CatalogServices #createProductCategoryAttribute doesn't check for existing attributes

[ https://issues.apache.org/jira/browse/OFBIZ-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683480#comment-16683480 ] Benjamin Jugl commented on OFBIZ-10327: --- It seems that CategrieServices.groovy is missing. This

[jira] [Created] (OFBIZ-10646) Clean some Groovy files in base component

Jacques Le Roux created OFBIZ-10646: --- Summary: Clean some Groovy files in base component Key: OFBIZ-10646 URL: https://issues.apache.org/jira/browse/OFBIZ-10646 Project: OFBiz Issue Type:

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684046#comment-16684046 ] Jacques Le Roux commented on OFBIZ-10645: - bq. So we can proceed with only checking entity-name