[jira] [Commented] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840070#comment-16840070 ] Jacques Le Roux commented on OFBIZ-10895: - Fixed in HR: trunk r1859263 R18 r1859264 Not a

[jira] [Commented] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2019-05-15 Thread Suraj Khurana (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840078#comment-16840078 ] Suraj Khurana commented on OFBIZ-10518: --- Improved condition in which reservation block was not

[jira] [Created] (OFBIZ-11031) Improve SalesOrderItemFact table

2019-05-15 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-11031: Summary: Improve SalesOrderItemFact table Key: OFBIZ-11031 URL: https://issues.apache.org/jira/browse/OFBIZ-11031 Project: OFBiz Issue Type: Improvement

[jira] [Commented] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840068#comment-16840068 ] Jacques Le Roux commented on OFBIZ-5776: HI Deepak, All, What is the situation here? > Move

[jira] [Commented] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840071#comment-16840071 ] Jacques Le Roux commented on OFBIZ-10895: - BTW [we have a problem with "images" at

[jira] [Comment Edited] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840070#comment-16840070 ] Jacques Le Roux edited comment on OFBIZ-10895 at 5/15/19 6:17 AM: --

[jira] [Assigned] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-15 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-7963: --- Assignee: Pierre Smits (was: Jacques Le Roux) > Create a Gradle Sonar task >

[jira] [Reopened] (OFBIZ-7963) Create a Gradle Sonar task

2019-05-15 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reopened OFBIZ-7963: - Re-opening as it is related to OFBIZ-10917 > Create a Gradle Sonar task >

[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840109#comment-16840109 ] Jacques Le Roux commented on OFBIZ-10969: - Sorry Olivier, Your patches don't apply on trunk

[jira] [Commented] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840221#comment-16840221 ] Jacques Le Roux commented on OFBIZ-11032: - Hi Mathieu, Girish, The patch looks good to me, +1

[jira] [Created] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11032: -- Summary: ServiceDispatcher implementation details should be private Key: OFBIZ-11032 URL: https://issues.apache.org/jira/browse/OFBIZ-11032 Project: OFBiz

[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840113#comment-16840113 ] Jacques Le Roux commented on OFBIZ-10969: - I guess OFBIZ-11028 patch should be applied before,

[jira] [Commented] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840128#comment-16840128 ] Mathieu Lirzin commented on OFBIZ-11032: I will wait a couple of days for comments before

[jira] [Updated] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11032: --- Attachment: OFBIZ-11032_ServiceDispatcher-is-not-meant-to-be-extend.patch >

[jira] [Commented] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Girish Vasmatkar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840173#comment-16840173 ] Girish Vasmatkar commented on OFBIZ-11032: -- Hi Mathieu, With these changes we might as well

[jira] [Commented] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840203#comment-16840203 ] Mathieu Lirzin commented on OFBIZ-11032: I agree :) > ServiceDispatcher implementation details

[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Olivier Heintz (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840227#comment-16840227 ] Olivier Heintz commented on OFBIZ-10969: Yes, and the two patch are included in OFBIZ-11028 so

[jira] [Commented] (OFBIZ-11019) Cleaning the bloated ‘Security’ interface

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840246#comment-16840246 ] Jacques Le Roux commented on OFBIZ-11019: - Hi Mathieu, I don't see a urgent need for that but

[jira] [Updated] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10969: Attachment: (was: OFBIZ-10969.services.xml.patch) > Unable to create Employments >

[jira] [Updated] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10969: Attachment: (was: OFBIZ-10969.HumanResServices.xml.patch) > Unable to create

[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840277#comment-16840277 ] Jacques Le Roux commented on OFBIZ-10969: - Oivier, I tried to create an employment for

[jira] [Updated] (OFBIZ-11028) field emplFromDate is forgot in PayHistory entity

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11028: Issue Type: Bug (was: Sub-task) Parent: (was: OFBIZ-10969) > field

[jira] [Commented] (OFBIZ-10969) Unable to create Employments

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840258#comment-16840258 ] Jacques Le Roux commented on OFBIZ-10969: - No worries, to clarifiy I removed them and make this

[jira] [Commented] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840423#comment-16840423 ] Jacques Le Roux commented on OFBIZ-11021: - +1 sounds good to me. Thanks Pawan, well spotted

[jira] [Commented] (OFBIZ-11026) HR Doc drive by process

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840368#comment-16840368 ] Jacques Le Roux commented on OFBIZ-11026: - Hi Olivier, I had a quick look trying to use a HTML

[jira] [Created] (OFBIZ-11033) service 'loadSalesOrderItemFact' has hard coded currencyUomId

2019-05-15 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-11033: Summary: service 'loadSalesOrderItemFact' has hard coded currencyUomId Key: OFBIZ-11033 URL: https://issues.apache.org/jira/browse/OFBIZ-11033 Project: OFBiz

[jira] [Commented] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Suraj Khurana (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840318#comment-16840318 ] Suraj Khurana commented on OFBIZ-11032: --- +1. Looks good to me. > ServiceDispatcher implementation

[jira] [Commented] (OFBIZ-11001) Applicable Promo Recommendations

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840446#comment-16840446 ] Jacques Le Roux commented on OFBIZ-11001: - Hi Rishi, >From your description (did not look into

[jira] [Reopened] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-5254: Reopen after discussion at https://markmail.org/message/jnaitmwahjcjmdn5 > Services allow

[jira] [Updated] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-5254: --- Attachment: OFBIZ-5254.patch > Services allow arbitrary HTML for parameters with allow-html

[jira] [Commented] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840561#comment-16840561 ] Jacques Le Roux commented on OFBIZ-5254: BTW I have not tested anything yet :) But I trust it

[jira] [Commented] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840554#comment-16840554 ] Jacques Le Roux commented on OFBIZ-5254: With [^OFBIZ-5254.patch] I propose a solution to use

[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code

2019-05-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840568#comment-16840568 ] Jacques Le Roux commented on OFBIZ-10187: - I reopened OFBIZ-5254 and will handle it there. >