[jira] [Created] (OFBIZ-11746) Enforce noninstantiability to ConfigXMLReader Class

2020-05-27 Thread Suraj Khurana (Jira)
Suraj Khurana created OFBIZ-11746: - Summary: Enforce noninstantiability to ConfigXMLReader Class Key: OFBIZ-11746 URL: https://issues.apache.org/jira/browse/OFBIZ-11746 Project: OFBiz Issue

[jira] [Created] (OFBIZ-11747) Enforce noninstantiability to LoginWorker Class

2020-05-27 Thread Suraj Khurana (Jira)
Suraj Khurana created OFBIZ-11747: - Summary: Enforce noninstantiability to LoginWorker Class Key: OFBIZ-11747 URL: https://issues.apache.org/jira/browse/OFBIZ-11747 Project: OFBiz Issue

[jira] [Created] (OFBIZ-11748) Enforce noninstantiability to ExpressionUiHelper Class

2020-05-27 Thread Suraj Khurana (Jira)
Suraj Khurana created OFBIZ-11748: - Summary: Enforce noninstantiability to ExpressionUiHelper Class Key: OFBIZ-11748 URL: https://issues.apache.org/jira/browse/OFBIZ-11748 Project: OFBiz

[jira] [Commented] (OFBIZ-11722) Create a Github PR template

2020-05-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117798#comment-17117798 ] ASF subversion and git services commented on OFBIZ-11722: - Commit

[jira] [Commented] (OFBIZ-11722) Create a Github PR template

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117808#comment-17117808 ] Jacques Le Roux commented on OFBIZ-11722: - As the Github PR template is not related to OFBiz I

[jira] [Commented] (OFBIZ-11739) Change resource with RESOURCE in all application components

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117667#comment-17117667 ] Jacques Le Roux commented on OFBIZ-11739: - Works for me, just applied both patches and compiled,

[jira] [Created] (OFBIZ-11749) Enforce noninstantiability to JobUtil Class

2020-05-27 Thread Suraj Khurana (Jira)
Suraj Khurana created OFBIZ-11749: - Summary: Enforce noninstantiability to JobUtil Class Key: OFBIZ-11749 URL: https://issues.apache.org/jira/browse/OFBIZ-11749 Project: OFBiz Issue Type:

[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117723#comment-17117723 ] Jacques Le Roux commented on OFBIZ-11745: - You are actually right Olivier, works also for me if

[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

2020-05-27 Thread Olivier Heintz (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117656#comment-17117656 ] Olivier Heintz commented on OFBIZ-11745: Hi Jacques, Thank for your answers, Maybe it's a

[jira] [Created] (OFBIZ-11750) Enforce noninstantiability to ServiceGroupReader Class

2020-05-27 Thread Suraj Khurana (Jira)
Suraj Khurana created OFBIZ-11750: - Summary: Enforce noninstantiability to ServiceGroupReader Class Key: OFBIZ-11750 URL: https://issues.apache.org/jira/browse/OFBIZ-11750 Project: OFBiz

[jira] [Commented] (OFBIZ-11468) Convert ShipmentReceiptServices.xml mini lang to groovy

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117818#comment-17117818 ] Jacques Le Roux commented on OFBIZ-11468: - Actually it can be removed since it's only used by

[jira] [Comment Edited] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

2020-05-27 Thread Aditya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117840#comment-17117840 ] Aditya Sharma edited comment on OFBIZ-11304 at 5/27/20, 3:11 PM: - >> is

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

2020-05-27 Thread Aditya Sharma (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117840#comment-17117840 ] Aditya Sharma commented on OFBIZ-11304: --- >> is there a way to block a commit if

[jira] [Issue Comment Deleted] (OFBIZ-11722) Create a Github PR template

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11722: Comment: was deleted (was: As the Github PR template is not related to OFBiz I followed

[jira] [Commented] (OFBIZ-11722) Create a Github PR template

2020-05-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118007#comment-17118007 ] ASF subversion and git services commented on OFBIZ-11722: - Commit

[jira] [Commented] (OFBIZ-11741) Headerize external script in multi-block html template

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118334#comment-17118334 ] Jacques Le Roux commented on OFBIZ-11741: - Hi James, I tried to apply but got this reject:

[jira] [Updated] (OFBIZ-11741) Headerize external script in multi-block html template

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11741: Attachment: HtmlWidget.java.rej > Headerize external script in multi-block html template

[jira] [Created] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

2020-05-27 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-11745: -- Summary: plugins in common-theme/webapp/common/js is not monitored by git Key: OFBIZ-11745 URL: https://issues.apache.org/jira/browse/OFBIZ-11745 Project: OFBiz

[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

2020-05-27 Thread Olivier Heintz (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117522#comment-17117522 ] Olivier Heintz commented on OFBIZ-11745: status is "Patch Available", because there is only one

[jira] [Assigned] (OFBIZ-11722) Create a Github PR template

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11722: --- Assignee: Jacques Le Roux > Create a Github PR template >

[jira] [Commented] (OFBIZ-11722) Create a Github PR template

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117547#comment-17117547 ] Jacques Le Roux commented on OFBIZ-11722: - This follows

[jira] [Commented] (OFBIZ-11722) Create a Github PR template

2020-05-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117548#comment-17117548 ] ASF subversion and git services commented on OFBIZ-11722: - Commit

[jira] [Closed] (OFBIZ-11722) Create a Github PR template

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11722. --- Resolution: Done > Create a Github PR template > --- > >

[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117554#comment-17117554 ] Jacques Le Roux commented on OFBIZ-11745: - Hi Olivier Plugins are part of another repository:

[jira] [Commented] (OFBIZ-11744) As an OFBiz Developer I want to use parametrized Unit Testing

2020-05-27 Thread Carsten Schinzer (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117556#comment-17117556 ] Carsten Schinzer commented on OFBIZ-11744: -- Obviously, the current setup will not be aware of

[jira] [Commented] (OFBIZ-11745) plugins in common-theme/webapp/common/js is not monitored by git

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117560#comment-17117560 ] Jacques Le Roux commented on OFBIZ-11745: - BTW I think you made a confusion.

[jira] [Commented] (OFBIZ-11693) Help system using asciidoc files

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117493#comment-17117493 ] Jacques Le Roux commented on OFBIZ-11693: - I'll do the RAT part after INFRA-20311 > Help

[jira] [Updated] (OFBIZ-11744) As an OFBiz Developer I want to use parametrized Unit Testing

2020-05-27 Thread Carsten Schinzer (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Schinzer updated OFBIZ-11744: - Priority: Minor (was: Major) > As an OFBiz Developer I want to use parametrized Unit

[jira] [Closed] (OFBIZ-11298) Adapt the commit template to Git convention

2020-05-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11298. --- Resolution: Done > Adapt the commit template to Git convention >

[jira] [Created] (OFBIZ-11744) As an OFBiz Developer I want to use parametrized Unit Testing

2020-05-27 Thread Carsten Schinzer (Jira)
Carsten Schinzer created OFBIZ-11744: Summary: As an OFBiz Developer I want to use parametrized Unit Testing Key: OFBIZ-11744 URL: https://issues.apache.org/jira/browse/OFBIZ-11744 Project: OFBiz

[jira] [Commented] (OFBIZ-11744) As an OFBiz Developer I want to use parametrized Unit Testing

2020-05-27 Thread Carsten Schinzer (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117418#comment-17117418 ] Carsten Schinzer commented on OFBIZ-11744: -- In a first attempt to implement the JUnit4 or

[jira] [Updated] (OFBIZ-11739) Change resource with RESOURCE in all application components

2020-05-27 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11739: -- Attachment: OFBIZ-11739.patch OFBIZ-11739_plugins.patch > Change resource

[jira] [Updated] (OFBIZ-11350) Checkstyle improvements

2020-05-27 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11350: -- Sprint: OFBiz Community Day (May 2020) > Checkstyle improvements > --- >