[jira] [Commented] (OFBIZ-11749) Enforce noninstantiability to JobUtil Class

[ https://issues.apache.org/jira/browse/OFBIZ-11749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124843#comment-17124843 ] ASF subversion and git services commented on OFBIZ-11749: - Commit

[GitHub] [ofbiz-framework] surajkhurana merged pull request #176: Improved: Enforce noninstantiability to JobUtil Class.

surajkhurana merged pull request #176: URL: https://github.com/apache/ofbiz-framework/pull/176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Closed] (OFBIZ-11749) Enforce noninstantiability to JobUtil Class

[ https://issues.apache.org/jira/browse/OFBIZ-11749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11749. - Fix Version/s: Upcoming Branch Resolution: Implemented > Enforce noninstantiability to

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

sonarcloud[bot] commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638161272 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=185=false=BUG)

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124848#comment-17124848 ] Priya Sharma commented on OFBIZ-11762: -- Perfect, that works. Thanks, Pawan and Jacques. > Use

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #117: Improved: Update Data Sets

sonarcloud[bot] commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-638007630 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

sonarcloud[bot] removed a comment on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-637294053 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124710#comment-17124710 ] Priya Sharma commented on OFBIZ-11762: -- Hello All, I have one more concern regarding this

[jira] [Comment Edited] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124710#comment-17124710 ] Priya Sharma edited comment on OFBIZ-11762 at 6/3/20, 7:38 AM: --- Hello All,

[jira] [Commented] (OFBIZ-11748) Enforce noninstantiability to ExpressionUiHelper Class

[ https://issues.apache.org/jira/browse/OFBIZ-11748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124839#comment-17124839 ] ASF subversion and git services commented on OFBIZ-11748: - Commit

[GitHub] [ofbiz-framework] surajkhurana merged pull request #173: Improved: Enforce noninstantiability to ExpressionUiHelper Class.

surajkhurana merged pull request #173: URL: https://github.com/apache/ofbiz-framework/pull/173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124816#comment-17124816 ] Jacques Le Roux commented on OFBIZ-11762: - Thanks Priya, Iwas no aware of that. Hi Pawan, if

[GitHub] [ofbiz-framework] priyasharma1 opened a new pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

priyasharma1 opened a new pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185 (OFBIZ-11762) - Replaced the debug.log methods with the respective groovy utility method - Enhanced the GroovyBaseScript to entertain the fetch the current class name as the

[jira] [Updated] (OFBIZ-6976) Updating data sets

[ https://issues.apache.org/jira/browse/OFBIZ-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-6976: Attachment: ORRTIZ-OFBiz-6976.pdf > Updating data sets > -- > >

[jira] [Closed] (OFBIZ-11748) Enforce noninstantiability to ExpressionUiHelper Class

[ https://issues.apache.org/jira/browse/OFBIZ-11748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11748. - Fix Version/s: Upcoming Branch Resolution: Implemented > Enforce noninstantiability to

[jira] [Commented] (OFBIZ-11762) Use GroovyBaseScript's logging utility methods instead of using Debug in each Groovy files

[ https://issues.apache.org/jira/browse/OFBIZ-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124768#comment-17124768 ] Pawan Verma commented on OFBIZ-11762: - Hi Priya, This is because of the current module. It always

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

JacquesLeRoux commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638354697 Thanks Priya, It's OK with me but for EditSurveyQuestions.groovy OpenOrderItemsReport.groovy ComputeProductSellThroughData.groovy

[GitHub] [ofbiz-framework] mbrohl commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

mbrohl commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638374937 I am not able to check right now but are we sure that this change does not introduce unwanted changes? Does it respect the log configurations with log4j?

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

sonarcloud[bot] removed a comment on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638161272 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=185=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

sonarcloud[bot] commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638164702 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=185=false=BUG)

[GitHub] [ofbiz-framework] priyasharma1 closed pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

priyasharma1 closed pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] priyasharma1 commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

priyasharma1 commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638601279 Thanks Jacques, Actually in these files, I found the message to be Debug.logError(e, "Failure in " + module) Thus I did not omit the "module" in the error

[GitHub] [ofbiz-framework] priyasharma1 commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

priyasharma1 commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638602910 > I am not able to check right now but are we sure that this change does not introduce unwanted changes? Does it respect the log configurations with log4j?

[GitHub] [ofbiz-framework] priyasharma1 edited a comment on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

priyasharma1 edited a comment on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638601279 Thanks, Jacques Actually, in these files, I found the message to be like Debug.logError(e, "Failure in " + module) Thus I did not omit the "module"

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

sonarcloud[bot] commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638602270 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=185=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

sonarcloud[bot] removed a comment on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638164702 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=185=false=BUG)

[GitHub] [ofbiz-plugins] priyasharma1 opened a new pull request #24: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

priyasharma1 opened a new pull request #24: URL: https://github.com/apache/ofbiz-plugins/pull/24 (OFBIZ-11762) Explanation: - As per the discussion, updated all Debug.log* to log* - Removed unused Debug import from the files - Removed module variables as they are no

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #24: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

sonarcloud[bot] commented on pull request #24: URL: https://github.com/apache/ofbiz-plugins/pull/24#issuecomment-637986063 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=24=false=BUG)

[GitHub] [ofbiz-plugins] JacquesLeRoux commented on pull request #24: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

JacquesLeRoux commented on pull request #24: URL: https://github.com/apache/ofbiz-plugins/pull/24#issuecomment-637996192 Hi Priya, Instead of logError(e, "") why not simply using logError(e) ? This is

[GitHub] [ofbiz-plugins] priyasharma1 commented on pull request #24: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

priyasharma1 commented on pull request #24: URL: https://github.com/apache/ofbiz-plugins/pull/24#issuecomment-638001095 > Hi Priya, > > Instead of > logError(e, "") > why not simply using > logError(e) > ? In that case, we will have to overload logError once again,