[jira] [Closed] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12247. --- Resolution: Implemented > Allow to pass a Google API key for geolocation >

[jira] [Closed] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12247. --- Resolution: Implemented > Allow to pass a Google API key for geolocation >

[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353706#comment-17353706 ] ASF subversion and git services commented on OFBIZ-12247: - Commit

[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353757#comment-17353757 ] ASF subversion and git services commented on OFBIZ-10386: - Commit

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #220: Make latitude and longitude numeric fields for correct comparisons

2021-05-29 Thread GitBox
JacquesLeRoux merged pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353701#comment-17353701 ] ASF subversion and git services commented on OFBIZ-12247: - Commit

[jira] [Commented] (OFBIZ-12177) Possibly currency display bug in "Find Invoices"

2021-05-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353738#comment-17353738 ] Jacques Le Roux commented on OFBIZ-12177: - Hi Priya, Will you commit and backport? Do you want

[jira] [Created] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-12247: --- Summary: Allow to pass a Google API key for geolocation Key: OFBIZ-12247 URL: https://issues.apache.org/jira/browse/OFBIZ-12247 Project: OFBiz Issue

[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2021-05-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353761#comment-17353761 ] Jacques Le Roux commented on OFBIZ-10386: - Thanks guys, {noformat} I did not close because I

[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353758#comment-17353758 ] ASF subversion and git services commented on OFBIZ-10386: - Commit

[jira] [Commented] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353759#comment-17353759 ] ASF subversion and git services commented on OFBIZ-10386: - Commit

[GitHub] [ofbiz-framework] danwatford commented on a change in pull request #113: Improved: Convert EntitySyncServices.xml mini-lang to groovy (OFBIZ-11660)

2021-05-29 Thread GitBox
danwatford commented on a change in pull request #113: URL: https://github.com/apache/ofbiz-framework/pull/113#discussion_r641907111 ## File path: framework/entityext/servicedef/services.xml ## @@ -447,7 +447,7 @@ under the License. +

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons

2021-05-29 Thread GitBox
JacquesLeRoux commented on pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-850808960 Hi Daniel, Please test and confirm OFBIZ-12247 is OK with you, TIA -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Reopened] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-12247: - There are some issues with the current state, I'll fix them... WIP... > Allow to pass a

[jira] [Updated] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12247: Issue Type: Bug (was: Improvement) > Allow to pass a Google API key for geolocation >

[jira] [Updated] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12247: Fix Version/s: (was: Upcoming Branch) > Allow to pass a Google API key for

[jira] [Reopened] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-12247: - > Allow to pass a Google API key for geolocation >

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons

2021-05-29 Thread GitBox
JacquesLeRoux commented on pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-850938934 Hi Michael, I thought about creating a Jira but did not. I did not thought about the DB changes, too. You are right, I'll, thanks -- This is an automated

[jira] [Commented] (OFBIZ-12109) Invalid Currency symbol in cashflow statement csv export

2021-05-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353927#comment-17353927 ] Jacques Le Roux commented on OFBIZ-12109: - Sorry [~thirumurugan_mani], I tested locally and it

[GitHub] [ofbiz-framework] danwatford commented on a change in pull request #113: Improved: Convert EntitySyncServices.xml mini-lang to groovy (OFBIZ-11660)

2021-05-29 Thread GitBox
danwatford commented on a change in pull request #113: URL: https://github.com/apache/ofbiz-framework/pull/113#discussion_r641980688 ## File path: framework/entityext/servicedef/services.xml ## @@ -447,7 +447,7 @@ under the License. Clean

[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353922#comment-17353922 ] ASF subversion and git services commented on OFBIZ-12247: - Commit

[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353923#comment-17353923 ] ASF subversion and git services commented on OFBIZ-12247: - Commit

[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353924#comment-17353924 ] ASF subversion and git services commented on OFBIZ-12247: - Commit

[jira] [Closed] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12247. --- Fix Version/s: 18.12.01 Resolution: Fixed Thanks Daniel, as it was simple to

[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353921#comment-17353921 ] ASF subversion and git services commented on OFBIZ-12247: - Commit

[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation

2021-05-29 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353783#comment-17353783 ] Daniel Watford commented on OFBIZ-12247: Hi [~jleroux], Slight change needed on line 49 of

[GitHub] [ofbiz-framework] mbrohl commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons

2021-05-29 Thread GitBox
mbrohl commented on pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-850869743 @JacquesLeRoux doe we have a Jira for this change? IMO this is not complete because there is no documentation / changelog for the database changes. Users who use the