[jira] [Comment Edited] (OFBIZ-11005) Missing uiLabel for Create New on CMS Content Find Screen

2019-05-02 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831430#comment-16831430
 ] 

Pawan Verma edited comment on OFBIZ-11005 at 5/2/19 6:31 AM:
-

Yes Suraj, You are right.

CommonCreate is the right uiLabel to use. OFBIZ-9905 missed two uiLabels 
OrderNotesCreateNew and ProjectMgrNotesCreateNew. I have removed both of them 
and used CommonCreate Instead.

 

I did not find LuceneScreens in release 17 branch. I think other changes 
releated to OrderNotesCreateNew and ProjectMgrNotesCreateNew uiLabels should go 
in release branches. 

Attached patch for the applications and plugins. 

 


was (Author: pawan.verma):
Yes Suraj, You are right.

CommonCreate is the right uiLabel to use. 
[OFBIZ-9905|https://issues.apache.org/jira/browse/OFBIZ-9905] missed two 
uiLabels OrderNotesCreateNew and ProjectMgrNotesCreateNew. I have removed both 
of them and used CommonCreate Instead.

 

I did not find LuceneScreens in release 17 branch. I think other changes 
releated to OrderNotesCreateNew and ProjectMgrNotesCreateNew uiLabels should go 
in release branches. 

 

 

> Missing uiLabel for Create New on CMS Content Find Screen
> -
>
> Key: OFBIZ-11005
> URL: https://issues.apache.org/jira/browse/OFBIZ-11005
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-11005-plugins.patch, OFBIZ-11005.patch, 
> OFBIZ-11005.patch
>
>
> Steps to regenerate:
>  # Go to [https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind]
>  # Find missing uiLabel for Create New, showing as CommonCreateNew.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-11005) Missing uiLabel for Create New on CMS Content Find Screen

2019-05-02 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831424#comment-16831424
 ] 

Suraj Khurana edited comment on OFBIZ-11005 at 5/2/19 6:06 AM:
---

Hello Pawan,

Thanks for your contribution.
We have done some changes recently on OFBIZ-9905, I don't know are they related.
 Also, IMO, we can remove OrderNotesCreateNew and use this CommonCreateNew 
instead.

WDYT.

Please check if this is for trunk only or update affects version/s instead.

Thanks !!


was (Author: suraj.khurana):
Hello Pawan,

Thanks for your contribution.
We have done some changes recently on OFBIZ-9905, I don't know it it is related.
Also, IMO, we can remove OrderNotesCreateNew and use this CommonCreateNew 
instead.

WDYT.

Please check if this is for trunk only or also affect/s release versions.

Thanks !!

> Missing uiLabel for Create New on CMS Content Find Screen
> -
>
> Key: OFBIZ-11005
> URL: https://issues.apache.org/jira/browse/OFBIZ-11005
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11005.patch
>
>
> Steps to regenerate:
>  # Go to [https://demo-trunk.ofbiz.apache.org/content/control/CMSContentFind]
>  # Find missing uiLabel for Create New, showing as CommonCreateNew.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)