[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099261#comment-17099261 ] ASF subversion and git services commented on OFBIZ-10031: - Commit 9e08611e130124ac4a20e43ee36289c453408077 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9e08611 ] Fixed: Freamework only integration tests don't pass due to missing data only present in ecommerce (OFBIZ- OFBIZ-6110) OFBIZ-10031 and OFBIZ-8579 did not take care of that. It seems that, for a reason, fixing OFBIZ-11620 mades them popup > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Fix For: 18.12.01 > > Attachments: CategoryServices.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380300#comment-16380300
]
Dennis Balkir commented on OFBIZ-10031:
---
I tested this one better, this works now.
The problem was, that the value {{newEntity}} was made with the {{parameters}}
map, which resulted in a value, which didn't had the sequenced id, that I tried
to fix.
But after removing the map, everything works just fine
> Convert CategoryServices.xml mini lang to groovy
>
>
> Key: OFBIZ-10031
> URL: https://issues.apache.org/jira/browse/OFBIZ-10031
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: CategoryServices.patch,
> OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch,
> OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch
>
>
> Migration of the CategoryServices.xml to Groovy
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380166#comment-16380166 ] Dennis Balkir commented on OFBIZ-10031: --- I made some additional testing, and found out, that my patch seem to only partially fix the problem. I will provide a finished version asap though > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378942#comment-16378942 ] Dennis Balkir commented on OFBIZ-10031: --- I did some deeper research in the Java implementations of the MiniLang methods and found out, that it looks like I made a mistake in here. The new patch should fix it. Sorry for the inconvenience > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: CategoryServices.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350115#comment-16350115 ] Dennis Balkir commented on OFBIZ-10031: --- Hi Nicolas, I reviewed the changes you made and I think it's better this way. I didn't know some of the things you changed could be so simple, that's good to know for future conversions. In my opinion this can be closed. Thanks for helping and reviewing! > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339489#comment-16339489 ] Dennis Balkir commented on OFBIZ-10031: --- Hey [~soledad], I applied your suggested changes to this file and deleted the "login-rewquired tag?" comment, since this question was answered in the mailing-list by you and [~jacques.le.roux]. Thanks for that! I hope this makes the file a bit better and if there still is something to do please tell me so I can make the needed changes > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch, > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331203#comment-16331203
]
Nicolas Malin commented on OFBIZ-10031:
---
Hi Dennis, nice staff
After a first review, I seem we can improve some following code :
{code:java}
GenericValue lookedUpValue = delegator.makeValidValue("ProductCategory",
parameters)
lookedUpValue = from("ProductCategory")
.where(lookedUpValue.getFields(lookedUpValue.getModelEntity().getPkFieldNames()))
.queryOne(){code}
by
{code:java}lookedUpValue =
from("ProductCategory").where(parameters).queryOne(){code}
{code:java}
GenericValue newEntity = delegator.makeValidValue("ProductCategoryRole",
parameters){code}
by{code:java}
GenericValue newEntity = makeValue("ProductCategoryRole", parameters)
{code}
{code:java}
Map callCreateProductMap =
dispatcher.dispatchContext.makeValidContext("createProduct",
ModelService.IN_PARAM, parameters)
if (!callCreateProductMap.productTypeId) {
callCreateProductMap.productTypeId = "FINISHED_GOOD"
}
Map cPRes = run service: "createProduct", with: callCreateProductMap{code}
by
{code:java}if (!callCreateProductMap.parameters) {
parameters.productTypeId = "FINISHED_GOOD"
}
Map cPRes = run service: "createProduct", with: parameters{code}
I will check if we can improve the groovy context to simplify this
{code:java}Security security = dispatcher.dispatchContext.security{code}
> Convert CategoryServices.xml mini lang to groovy
>
>
> Key: OFBIZ-10031
> URL: https://issues.apache.org/jira/browse/OFBIZ-10031
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments:
> OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch
>
>
> Migration of the CategoryServices.xml to Groovy
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330224#comment-16330224 ] Nicolas Malin commented on OFBIZ-10031: --- Hi Dennis, I will try to look your work soon > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Nicolas Malin >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10031) Convert CategoryServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327122#comment-16327122 ] Dennis Balkir commented on OFBIZ-10031: --- * didn’t convert the unnecessary services, as seen in this issue, maybe someone can have a look at that too * Line 465: this seems like it was planned to be changed, maybe this is the right time to do that, since we’re already doing changes to this Service * Couldn’t fully delete CatalogServices.xml, since one of its simple-methods (checkCategoryRelatedPermission) is used in another method in another .xml-file (/applications/commonext/minilang/setup/SetupEvents.xml). Unfortunately there is no service which defines this method, which means, that I cannot use a service instead. * I tested all the services in this file as good as I could, they seem to work and do what they should do I would appreciate if one of the involved people can give me a feedback on this file, thanks :) > Convert CategoryServices.xml mini lang to groovy > > > Key: OFBIZ-10031 > URL: https://issues.apache.org/jira/browse/OFBIZ-10031 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: > OFBIZ-10031_org.apache.ofbiz.product.category.CategoryServices_convert.patch > > > Migration of the CategoryServices.xml to Groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)
