[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350552#comment-16350552 ] Jacques Le Roux commented on OFBIZ-10146: - Thank you both, I apply and commit... > Removing of loadBestSellingCategory and all related methods in > CategoryServices.xml > --- > > Key: OFBIZ-10146 > URL: https://issues.apache.org/jira/browse/OFBIZ-10146 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10146.patch, OFBIZ-10146.patch > > > While doing some conversions from MiniLang to Groovy, I stumbled across these > methods: > {{loadBestSellingCategory}} > {{RemoveProductFromBestSellCategory}} > {{AddProductToBestSellCategory}} > {{FindCategoryChild}} > {{FindBestSellingProduct}} > These are all in {{CategoryServices.xml}}. > I started realizing, that the simple-method {{loadBestSellingCategory}} > doesn't work right (there are some logical failures in it) and while fixing > it, > I searched for places where this is used, but couldn't find any. > I started looking deeper into it and found that all of these methods are > never used anywhere in OFBiz, neither are the services which are declared for > this methods. > This is why I propose to remove them; they have no real use, since they don't > work properly, and also are never used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350491#comment-16350491 ] Nicolas Malin commented on OFBIZ-10146: --- My fault, with the issue OFBIZ-10031 these services has been deleted from CatalogServices.xml in the patch. I restore them but sure with few padding :) > Removing of loadBestSellingCategory and all related methods in > CategoryServices.xml > --- > > Key: OFBIZ-10146 > URL: https://issues.apache.org/jira/browse/OFBIZ-10146 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10146.patch > > > While doing some conversions from MiniLang to Groovy, I stumbled across these > methods: > {{loadBestSellingCategory}} > {{RemoveProductFromBestSellCategory}} > {{AddProductToBestSellCategory}} > {{FindCategoryChild}} > {{FindBestSellingProduct}} > These are all in {{CategoryServices.xml}}. > I started realizing, that the simple-method {{loadBestSellingCategory}} > doesn't work right (there are some logical failures in it) and while fixing > it, > I searched for places where this is used, but couldn't find any. > I started looking deeper into it and found that all of these methods are > never used anywhere in OFBiz, neither are the services which are declared for > this methods. > This is why I propose to remove them; they have no real use, since they don't > work properly, and also are never used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350495#comment-16350495 ] Dennis Balkir commented on OFBIZ-10146: --- I just added a new patch, this should work with the current trunk > Removing of loadBestSellingCategory and all related methods in > CategoryServices.xml > --- > > Key: OFBIZ-10146 > URL: https://issues.apache.org/jira/browse/OFBIZ-10146 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10146.patch, OFBIZ-10146.patch > > > While doing some conversions from MiniLang to Groovy, I stumbled across these > methods: > {{loadBestSellingCategory}} > {{RemoveProductFromBestSellCategory}} > {{AddProductToBestSellCategory}} > {{FindCategoryChild}} > {{FindBestSellingProduct}} > These are all in {{CategoryServices.xml}}. > I started realizing, that the simple-method {{loadBestSellingCategory}} > doesn't work right (there are some logical failures in it) and while fixing > it, > I searched for places where this is used, but couldn't find any. > I started looking deeper into it and found that all of these methods are > never used anywhere in OFBiz, neither are the services which are declared for > this methods. > This is why I propose to remove them; they have no real use, since they don't > work properly, and also are never used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350449#comment-16350449 ] Dennis Balkir commented on OFBIZ-10146: --- Hi [~jacques.le.roux], I'll take a look. This may be the case, because the .xml-file was changed yesterday due to my groovy-conversion of this services-file > Removing of loadBestSellingCategory and all related methods in > CategoryServices.xml > --- > > Key: OFBIZ-10146 > URL: https://issues.apache.org/jira/browse/OFBIZ-10146 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10146.patch > > > While doing some conversions from MiniLang to Groovy, I stumbled across these > methods: > {{loadBestSellingCategory}} > {{RemoveProductFromBestSellCategory}} > {{AddProductToBestSellCategory}} > {{FindCategoryChild}} > {{FindBestSellingProduct}} > These are all in {{CategoryServices.xml}}. > I started realizing, that the simple-method {{loadBestSellingCategory}} > doesn't work right (there are some logical failures in it) and while fixing > it, > I searched for places where this is used, but couldn't find any. > I started looking deeper into it and found that all of these methods are > never used anywhere in OFBiz, neither are the services which are declared for > this methods. > This is why I propose to remove them; they have no real use, since they don't > work properly, and also are never used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350429#comment-16350429 ] Jacques Le Roux commented on OFBIZ-10146: - OK the patch does not completely apply, it seems benign, I'll look at it ASAP... > Removing of loadBestSellingCategory and all related methods in > CategoryServices.xml > --- > > Key: OFBIZ-10146 > URL: https://issues.apache.org/jira/browse/OFBIZ-10146 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10146.patch > > > While doing some conversions from MiniLang to Groovy, I stumbled across these > methods: > {{loadBestSellingCategory}} > {{RemoveProductFromBestSellCategory}} > {{AddProductToBestSellCategory}} > {{FindCategoryChild}} > {{FindBestSellingProduct}} > These are all in {{CategoryServices.xml}}. > I started realizing, that the simple-method {{loadBestSellingCategory}} > doesn't work right (there are some logical failures in it) and while fixing > it, > I searched for places where this is used, but couldn't find any. > I started looking deeper into it and found that all of these methods are > never used anywhere in OFBiz, neither are the services which are declared for > this methods. > This is why I propose to remove them; they have no real use, since they don't > work properly, and also are never used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10146) Removing of loadBestSellingCategory and all related methods in CategoryServices.xml
[ https://issues.apache.org/jira/browse/OFBIZ-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333493#comment-16333493 ] Jacques Le Roux commented on OFBIZ-10146: - This was put in with http://svn.apache.org/viewvc?view=revision=1055774 So if [~hansbak] has nothing more to say about it I think we can indeed remove the whole > Removing of loadBestSellingCategory and all related methods in > CategoryServices.xml > --- > > Key: OFBIZ-10146 > URL: https://issues.apache.org/jira/browse/OFBIZ-10146 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: OFBIZ-10146.patch > > > While doing some conversions from MiniLang to Groovy, I stumbled across these > methods: > {{loadBestSellingCategory}} > {{RemoveProductFromBestSellCategory}} > {{AddProductToBestSellCategory}} > {{FindCategoryChild}} > {{FindBestSellingProduct}} > These are all in {{CategoryServices.xml}}. > I started realizing, that the simple-method {{loadBestSellingCategory}} > doesn't work right (there are some logical failures in it) and while fixing > it, > I searched for places where this is used, but couldn't find any. > I started looking deeper into it and found that all of these methods are > never used anywhere in OFBiz, neither are the services which are declared for > this methods. > This is why I propose to remove them; they have no real use, since they don't > work properly, and also are never used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)