[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351340#comment-16351340 ] Taher Alkhateeb commented on OFBIZ-10164: - It's up to you, but you can perhaps update this Jira instead of creating a new one? And if you can do the entire thing in a theme, then i think common-theme might be the best candidate for that. > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. > Update on 20180128: > 1) The patch comes with an example where you can view the splitter at > https://localhost:8443/catalog/control/main > 2) No need to add square brackets when defining sizes. > 3) parentId attribute is removed, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351283#comment-16351283 ] James Yong commented on OFBIZ-10164: Hi all, Okay. The splitter can be implemented as a separate theme. So there is also no need for a splitter tag in the widget. Will close this issue since the current approach is incorrect. Thanks all for the explanation. Regards, James > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. > Update on 20180128: > 1) The patch comes with an example where you can view the splitter at > https://localhost:8443/catalog/control/main > 2) No need to add square brackets when defining sizes. > 3) parentId attribute is removed, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343459#comment-16343459 ] James Yong commented on OFBIZ-10164: Much appreciate the various feedbacks. The plan is to create splitter tag to aid in adding splitter(s) like those seen at https://nathancahill.github.io/Split.js/. Having a fixed header & footer is one common requirement I have seen on the use of splitter, and made some effort to achieve that in the example at CommonScreens.xml. As a result more changes is done than what a splitter should be doing. The splitter can and should do more than just an horizontal split, and hope to explore more scenarios 1st. Hopefully I can standardise on the required CSS for the various possible splits. That said I am also fine with removing the splitter tag altogether if doing entirely in the theme make better sense. Maybe will explore these, next weekend. If you got more time with the applied patch, can you look into the usability aspects of having fixed header and footer. Thinking if we can allow developer to turn on or off the fixed header / footer via a property. Maybe another JIRA issue for this... > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. > Update on 20180128: > 1) The patch comes with an example where you can view the splitter at > https://localhost:8443/catalog/control/main > 2) No need to add square brackets when defining sizes. > 3) parentId attribute is removed, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343391#comment-16343391 ] Jacques Le Roux commented on OFBIZ-10164: - BTW I'm not sure it's related (did not review yet), but I was the one who introduced the drop down and asm select mechanisms (there are examples in FormWidgetExampleScreens.xml). The asmselect jQuery plugin was recently replaced by the Select2 plugin with OFBIZ-10113. There Aditya, who did most of the work, rightly suggested to refactor the asm select mechanism and created OFBIZ-10165 for that. I wonder if we could not get to an even better solution to avoid and replace the drop down and asm select mechanisms and ultimately rely on require.js to better organise things, OFBIZ-9976 was created for that. Please bear with me, I'll get back to review and see if this comment makes sense in this context... > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. > Update on 20180128: > 1) The patch comes with an example where you can view the splitter at > https://localhost:8443/catalog/control/main > 2) No need to add square brackets when defining sizes. > 3) parentId attribute is removed, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343351#comment-16343351 ] Jacques Le Roux commented on OFBIZ-10164: - >From the peanuts gallery, I like this idea: bq. Alternatively, if you like to make this a full solution, then we can design a full splitter (vertical and horizontal) system and replace completely any old CSS styles relating to splitting with this new tag architecture. However, this might require community consensus because it would probably break some existing implementations. Please don't take it too seriously, I did not get a chance yet to get deeper in this issue, so just my 2cts... > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. > Update on 20180128: > 1) The patch comes with an example where you can view the splitter at > https://localhost:8443/catalog/control/main > 2) No need to add square brackets when defining sizes. > 3) parentId attribute is removed, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342611#comment-16342611 ] Taher Alkhateeb commented on OFBIZ-10164: - Thank you for the clarification. Now I understand exactly what is done. Thank you for your efforts, dedication and explanation. The idea is nice, but I see a few problems with the implementation. Essentially, you created a splitter tag specifically designed to accommodate a jquery plugin and you've incorporated it into the common theme. The problems with this design are as follows: * First, there is HTML related stuff in the widget (CommonScreens). It could be done with less verbosity perhaps? * Second, the idea of a tag existing to serve specifically and be logically tied to a jquery plugin is going against the philosophy of the widget system being an independent layer from the actual view. * You've added a tag that does not create a new structure (just add the splitter library behavior). As far as structure of the page is concerned, it is the same structure and achieved with CSS. I would suggest that less is more. It makes more sense to make the changes purely in the common theme, and link up the CSS from the styles to the actual library without touching the core or with minimal modifications. We discussed this in the community before, and the reason we created the common-theme is to completely remove "web" related stuff from the widget system and core framework. So my recommendation is to re-design with minimal or no change to the core. Alternatively, if you like to make this a full solution, then we can design a full splitter (vertical and horizontal) system and replace completely any old CSS styles relating to splitting with this new tag architecture. However, this might require community consensus because it would probably break some existing implementations. The reason for my suggestion is to reduce user confusion. There should be preferably only one way to structure a page. If we have multiple ways then we are adding complexity and confusing the users of the system. > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. > Update on 20180128: > 1) The patch comes with an example where you can view the splitter at > https://localhost:8443/catalog/control/main > 2) No need to add square brackets when defining sizes. > 3) parentId attribute is removed, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342602#comment-16342602 ] James Yong commented on OFBIZ-10164: Hi Taher, Sorry for not being clear. Can you try https://localhost:8443/catalog/control/main ? Regards, James > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342599#comment-16342599 ] Taher Alkhateeb commented on OFBIZ-10164: - Hi James, I cannot observe the effect of using the splitter, this is just wrapping a few decorators. Perhaps a sample screen to observe exactly what's going on would help? > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342579#comment-16342579 ] James Yong commented on OFBIZ-10164: Uploaded a 3rd version of the patch with the following improvements: 1. Improved CSS definition for each theme Hi Jacques, The splitter's common css definition is moved to the respective theme’s style.css. Hi Taher, I have migrate the patch to the new common-theme folder. Can refer to the CommonScreens.xml file for an example on its usage. If you know of other suitable location for the splitter(s), I can work on it to provide further examples. Thanks. > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, > horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339088#comment-16339088 ] Taher Alkhateeb commented on OFBIZ-10164: - Hi James, So I applied the patch and I'm not sure how to test it, can you give me an example context / screen of applying the splitter to observe the effect? Also, the patch needs an update (my fault) because of renaming common to common-theme > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, horizontal.png, > vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334028#comment-16334028 ] Jacques Le Roux commented on OFBIZ-10164: - Hi James, I did not review, nor tested, nor anything: could the "custom CSS for the Commons Widget" not be defined in a new style.css in common-theme? We could then also have common themes css definitions in this file. Not sure it makes much sense, just thinking. > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, horizontal.png, > vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16333568#comment-16333568 ] James Yong commented on OFBIZ-10164: Uploaded a 2nd version of the patch with the following improvements. 1) Improved documentation 2) No need for define Id of the parent container 3) Core CSS remains in split.css while custom CSS for the Commons Widget is defined in the style.css file of each theme. > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, horizontal.png, > vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1628#comment-1628 ] Taher Alkhateeb commented on OFBIZ-10164: - Okay so I see based on your feedback a number of problems. This is making the widget system too tightly coupled to HTML (just like we discussed in rhe email thread). The dependence of a widget on a javascript library and hard wiring of logic is removing the neutrality of the widget system. I recommend revisiting the whole design and approaching it in a platform independe t way. > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332488#comment-16332488 ] James Yong commented on OFBIZ-10164: Hi Taher, Thanks for the review. Internally, the splitter library accepts a javascript array of numbers. Maybe less confusing if the need for brackets is removed. Will also look into avoiding the parent ID attribute. Regards, James > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10164) Splitter Widget
[ https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328926#comment-16328926 ] Taher Alkhateeb commented on OFBIZ-10164: - Hello James, Great work! may I ask why you chose the sizes format as a bracketed comma separated list (and how is it parsed)? And why do you have the parent id specified when it should be automatically implied from the structure? > Splitter Widget > --- > > Key: OFBIZ-10164 > URL: https://issues.apache.org/jira/browse/OFBIZ-10164 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10164.patch, horizontal.png, vertical.png > > > A new splitter widget that will use a tag named 'splitter'. > This splitter tag has the following attributes: > a. sizes = [25, 75] where the containers within will be splitted with a ratio > of 25% and 75% > b. parentId which is the ID of the parent container > c. direction = vertical or horizonal (default) > The splitter tag can only contains container(s) as immediate child. > Using the library from http://nathancahill.github.io/Split.js/ which is > licensed under MIT license. -- This message was sent by Atlassian JIRA (v7.6.3#76005)