[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-06-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526182#comment-16526182
 ] 

Jacques Le Roux commented on OFBIZ-10221:
-

OK, the right solution for r1829700, to align the input fields at 
catalog/control/main, is to use a form widget. I'll do so at OFBIZ-10454


> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-05-04 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463643#comment-16463643
 ] 

Jacques Le Roux commented on OFBIZ-10221:
-

I just tested all catalog main pages, all the same than in stable (at 1st 
glance) and OK with me.

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-05-04 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463635#comment-16463635
 ] 

Jacques Le Roux commented on OFBIZ-10221:
-

Wait, I was just testing OFBIZ-10036 and found a difference in the 
product/catalog main page between stable and trunk and I prefer stable. I'd 
like to have other opinions, please compare

[https://demo-stable.ofbiz.apache.org/catalog/control/main?USERNAME=admin=ofbiz=Y]

[https://demo-trunk.ofbiz.apache.org/catalog/control/main?USERNAME=admin=ofbiz=Y]

and let me know

I have not checked much other pages yet, 
[https://localhost:8443/catalog/control/FindCatalog] and 
[https://localhost:8443/catalog/control/FindCategory] and it's maybe only "an 
issue" with /applications/product/template/Main.ftl (or other ftl files?)

 

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-28 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457607#comment-16457607
 ] 

Jacques Le Roux commented on OFBIZ-10221:
-

+1 Nicolas, the risk is low (it"s only UI AFAIK - no reviews yet) so backport 
is OK with me

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-28 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457404#comment-16457404
 ] 

Nicolas Malin commented on OFBIZ-10221:
---

{quote}Same question as for OFBIZ-10242: should we backport these changes to 
17.12?\{quote}

I agree [~mbrohl] to backport this, because I see it as UI correction and can 
help to create plugin theme compatible with the 17.12

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-21 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446723#comment-16446723
 ] 

Deepak Dixit commented on OFBIZ-10221:
--

>>I thought it would be easier to review if the different applications were 
>>separated.

I agree, instead of attaching patch on this ticket, we can crate ticket by 
component

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-21 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446722#comment-16446722
 ] 

Deepak Dixit commented on OFBIZ-10221:
--

Thanks [~Dennis Balkir],

product.template.Main has been committed at ofbiz framework trunk at r#1829700

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430581#comment-16430581
 ] 

Dennis Balkir commented on OFBIZ-10221:
---

Hi [~deepak.dixit],
I added a new patch, this should fix it.

Thanks for your comment on the patches

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-product.template.Main.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430451#comment-16430451
 ] 

Deepak Dixit commented on OFBIZ-10221:
--

Hi [~Dennis Balkir],

Thanks for your effort, I did cursory review and all changes looks good to me 
except changes done in OFBIZ-10221_product.template.Main.patch, in this patch 
markup is not semantically correct, form used inside table incorrectly, 

form is not a valid child of table,

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-04-09 Thread Dennis Balkir (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430426#comment-16430426
 ] 

Dennis Balkir commented on OFBIZ-10221:
---

Hello,

I provided new patches, which should fix the ordermanager issues.

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221-order.template.entry.OrderHeaderInfo.patch, 
> OFBIZ-10221_common-theme.template.includes.GenericLink.patch, 
> OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_order.template.entry.CheckInits.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog.patch, 
> OFBIZ-10221_order.template.entry.ChooseCatalog2.patch, 
> OFBIZ-10221_order.template.entry.OrderAgreements.patch, 
> OFBIZ-10221_order.template.entry.OrderEntryTabBar.patch, 
> OFBIZ-10221_order.template.entry.OrderShortcuts.patch, 
> OFBIZ-10221_order.template.entry.cart.ShowCart.patch, 
> OFBIZ-10221_order.template.entry.catalog.AdvancedSearch.patch, 
> OFBIZ-10221_order.template.entry.catalog.KeywordSearchBox.patch, 
> OFBIZ-10221_order.template.order.FindOrders.patch, 
> OFBIZ-10221_order.template.order.OrderList.patch, 
> OFBIZ-10221_order.template.order.OrderStats.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch, 
> OFBiz-10221_order.template.order.OrderContactInfo.patch, 
> OFBiz-10221_order.template.order.OrderInfo.patch, 
> OFBiz-10221_order.template.order.OrderItems.patch, 
> OFBiz-10221_order.template.order.OrderPaymentInfo.patch, 
> OFBiz-10221_order.template.order.OrderShippingInfo.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-03-23 Thread Julian Leichert (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411283#comment-16411283
 ] 

Julian Leichert commented on OFBIZ-10221:
-

Hello Michael,
thank you for commiting my changes.
I provided a new patch for product.template.Main .

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_party.template.party.AddressMatchMap.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-03-17 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403394#comment-16403394
 ] 

Michael Brohl commented on OFBIZ-10221:
---

Thanks Julian,

the patches are committed to trunk r1827077.

The patch OFBIZ-10221_product.template.Main.patch could not be applied because 
of recent other changes. Please provide a new patch for it, thanks!

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-03-17 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403392#comment-16403392
 ] 

Michael Brohl commented on OFBIZ-10221:
---

Same question as for OFBIZ-10242: should we backport these changes to 17.12?

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: backport-needed
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_content.content.ContentSearchOptions.patch, 
> OFBIZ-10221_content.template.cms.AddSubSite.patch, 
> OFBIZ-10221_content.template.contentsetup.UserPermissions.patch, 
> OFBIZ-10221_product.template.AddMultipleImages.patch, 
> OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-02-27 Thread Julian Leichert (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378418#comment-16378418
 ] 

Julian Leichert commented on OFBIZ-10221:
-

I propose to surround Forms, in one screenlet, with a table so that alignment 
and widths, are easy to style.
As an example you can view the patch 

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_product.template.Main.patch, 
> OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-02-24 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375634#comment-16375634
 ] 

Michael Brohl commented on OFBIZ-10221:
---

Thanks Julian,

the current patches are in trunk r1825261.

I leave this issue open for more to come ;)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-02-24 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375627#comment-16375627
 ] 

Michael Brohl commented on OFBIZ-10221:
---

Thanks [~soledad],

yes, our focus is on a consistent layout for easier theme layouts so we only 
improved the status quo instead of changing the used technology.

I'm going to commit the first changes.

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-02-23 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374061#comment-16374061
 ] 

Nicolas Malin commented on OFBIZ-10221:
---

No objections, just a suggest that it would be more generic to convert the 
current ftl to xml instead of improve the ftl. But sure this conversion will be 
realize in a future

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.CheckDb.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-02-21 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371208#comment-16371208
 ] 

Michael Brohl commented on OFBIZ-10221:
---

Are there any objections against these changes?

If not, I will start to commit them in the next days. Thank you!

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_webtools.entity.ArtifactInfo.patch, 
> OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch, 
> OFBIZ-10221_webtools.entity.FetchLogs.patch, 
> OFBIZ-10221_webtools.entity.ViewDataFile.patch, 
> OFBIZ-10221_webtools.entity.XmlDsDump.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-02-16 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366780#comment-16366780
 ] 

Jacques Le Roux commented on OFBIZ-10221:
-

.bq Viewing the patch, I think so Nicolas
Oops I was wrong, sorry Nicolas, I see now that it's not form widget but just 
FTL transformation. So my question about using  field makes no 
sense please ignore my comments (flag)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_webtools.entity.EntityExportAll.patch, 
> OFBIZ-10221_webtools.entity.EntityImport.patch, 
> OFBIZ-10221_webtools.entity.EntityImportDir.patch, 
> OFBIZ-10221_webtools.entity.EntityImportReaders.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-02-16 Thread Julian Leichert (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366701#comment-16366701
 ] 

Julian Leichert commented on OFBIZ-10221:
-

Hi Jacques and NIcolas,
 there was no particular reason for the use of renderDateTimeField, it was 
already used in the form ( I wanted to change as little as possible).
 Yes it tried to convert the ftl to the widget/screen engine, so that a theme 
can be applied.

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_webtools.entity.EntityExportAll.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-02-15 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365318#comment-16365318
 ] 

Jacques Le Roux commented on OFBIZ-10221:
-

BTW Julian,

Is there a reason why you used the renderDateTimeField macro instead of the 
 field ? (just quickly reviewed for now, not test)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_webtools.entity.EntityExportAll.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-02-15 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365314#comment-16365314
 ] 

Jacques Le Roux commented on OFBIZ-10221:
-

Hi Nicolas, Julian,

Viewing the patch, I think so Nicolas. Though it's actually the widget engine 
and replacing FTL by forms as much as possible. Even FTL passes by the  "screen 
engine" ;)

BTW I suggested the same some years ago and [~ofbizzer] began to work on that 
https://s.apache.org/97Pl

I even thought I created an unmbrella task for that, but it seems we actually 
referred to OFBIZ-5040 which is not totally related. We could use this Jira 
(I'll continue to look for the one I thought I created)

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_webtools.entity.EntityExportAll.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10221) Improve layout and structure of forms

2018-02-14 Thread Nicolas Malin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364828#comment-16364828
 ] 

Nicolas Malin commented on OFBIZ-10221:
---

Hello Julian, do you try to convert this ftl form to the screen engine ?

> Improve layout and structure of forms
> -
>
> Key: OFBIZ-10221
> URL: https://issues.apache.org/jira/browse/OFBIZ-10221
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Julian Leichert
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10221_webtools.entity.EntityExportAll.patch
>
>
> While working at a Theme, i discovered that the forms differ in their style 
> and structure.
>  I propose a standard form-structure, so that further styling and look is 
> coherent.
>  I.e. class definitions ( class="basic-form") are often missing, input-fields 
> vary in size and the layout does not follow a standard structure.
> As mentioned in 
> [https://lists.apache.org/thread.html/3654e2f8ee3a7f8d6dd6e9dfe8b4184d11d4609a811daa03f6ab2805@%3Cdev.ofbiz.apache.org%3E]
> I have attached an example patch, which modifies a form defined in FreeMarker 
> to conform it to the forms defined in any *Forms.xml.
> Often those forms within FreeMarker templates differ from most other forms in 
> Ofbiz,
> I propose a refactoring of these FreeMarker forms, to equalize all forms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)