[jira] [Commented] (OFBIZ-10342) Service Log screen is broken

2018-09-30 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633621#comment-16633621
 ] 

Swapnil M Mane commented on OFBIZ-10342:


Thanks [~jacques.le.roux]!

> Service Log screen is broken
> 
>
> Key: OFBIZ-10342
> URL: https://issues.apache.org/jira/browse/OFBIZ-10342
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Reporter: Swapnil M Mane
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, Release Branch 16.11
>
> Attachments: OFBIZ-10342.patch, serviceLog.png
>
>
> Service Log screen is broken.
> Steps to regenerate
>  # Navigate to Logging menu under webtools
>  [https://demo-trunk.ofbiz.apache.org/webtools/control/LogView]
>  # Select Service Log menu
> *Console Logs*
> {code:java}
>  |T| [[[ServiceLog(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2018-04-16 16:23:03,482 |jsse-nio-8443-exec-8 |RequestHandler
> |I| Rendering View [ServiceLog].  Hidden sessionId by default.
> 2018-04-16 16:23:03,483 |jsse-nio-8443-exec-8 |ServiceDispatcher 
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] 
> milliseconds
> 2018-04-16 16:23:03,484 |jsse-nio-8443-exec-8 |ScriptUtil
> |W| Error running script at location 
> [component://webtools/groovyScripts/service/Services.groovy]: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at 
> org.apache.ofbiz.service.RunningService.getEndStamp(RunningService.java:63) 
> ~[ofbiz.jar:?]
> at org.apache.ofbiz.service.RunningService$getEndStamp$2.call(Unknown 
> Source) ~[?:?]
> at Services$_run_closure1.doCall(Services.groovy:43) ~[?:?]
> at sun.reflect.GeneratedMethodAccessor98.invoke(Unknown Source) ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.Closure.call(Closure.java:414) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.callClosureForMapEntry(DefaultGroovyMethods.java:5276)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2117)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at org.codehaus.groovy.runtime.dgm$164.invoke(Unknown Source) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:274)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:56)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at Services.run(Services.groovy:38) ~[?:?]
> at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:209)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:342) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:324) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:634)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:115)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.webapp.control.RequestHandler.renderVie

[jira] [Commented] (OFBIZ-10342) Service Log screen is broken

2018-09-30 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633361#comment-16633361
 ] 

Swapnil M Mane commented on OFBIZ-10342:


Thanks you so much [~jacques.le.roux] for sharing your time in this issue.
Changes in the patch looks good to me.

Thanks [~rishisolankii]!

> Service Log screen is broken
> 
>
> Key: OFBIZ-10342
> URL: https://issues.apache.org/jira/browse/OFBIZ-10342
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Reporter: Swapnil M Mane
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10342.patch, serviceLog.png
>
>
> Service Log screen is broken.
> Steps to regenerate
>  # Navigate to Logging menu under webtools
>  [https://demo-trunk.ofbiz.apache.org/webtools/control/LogView]
>  # Select Service Log menu
> *Console Logs*
> {code:java}
>  |T| [[[ServiceLog(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2018-04-16 16:23:03,482 |jsse-nio-8443-exec-8 |RequestHandler
> |I| Rendering View [ServiceLog].  Hidden sessionId by default.
> 2018-04-16 16:23:03,483 |jsse-nio-8443-exec-8 |ServiceDispatcher 
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] 
> milliseconds
> 2018-04-16 16:23:03,484 |jsse-nio-8443-exec-8 |ScriptUtil
> |W| Error running script at location 
> [component://webtools/groovyScripts/service/Services.groovy]: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at 
> org.apache.ofbiz.service.RunningService.getEndStamp(RunningService.java:63) 
> ~[ofbiz.jar:?]
> at org.apache.ofbiz.service.RunningService$getEndStamp$2.call(Unknown 
> Source) ~[?:?]
> at Services$_run_closure1.doCall(Services.groovy:43) ~[?:?]
> at sun.reflect.GeneratedMethodAccessor98.invoke(Unknown Source) ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.Closure.call(Closure.java:414) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.callClosureForMapEntry(DefaultGroovyMethods.java:5276)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2117)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at org.codehaus.groovy.runtime.dgm$164.invoke(Unknown Source) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:274)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:56)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at Services.run(Services.groovy:38) ~[?:?]
> at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:209)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:342) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:324) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:634)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:115)
>  [ofbiz.jar:?]
> at 
>

[jira] [Commented] (OFBIZ-10342) Service Log screen is broken

2018-09-29 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632928#comment-16632928
 ] 

Jacques Le Roux commented on OFBIZ-10342:
-

Without reviews, I'll commit this weekend...

> Service Log screen is broken
> 
>
> Key: OFBIZ-10342
> URL: https://issues.apache.org/jira/browse/OFBIZ-10342
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Reporter: Swapnil M Mane
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10342.patch, serviceLog.png
>
>
> Service Log screen is broken.
> Steps to regenerate
>  # Navigate to Logging menu under webtools
>  [https://demo-trunk.ofbiz.apache.org/webtools/control/LogView]
>  # Select Service Log menu
> *Console Logs*
> {code:java}
>  |T| [[[ServiceLog(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2018-04-16 16:23:03,482 |jsse-nio-8443-exec-8 |RequestHandler
> |I| Rendering View [ServiceLog].  Hidden sessionId by default.
> 2018-04-16 16:23:03,483 |jsse-nio-8443-exec-8 |ServiceDispatcher 
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] 
> milliseconds
> 2018-04-16 16:23:03,484 |jsse-nio-8443-exec-8 |ScriptUtil
> |W| Error running script at location 
> [component://webtools/groovyScripts/service/Services.groovy]: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at 
> org.apache.ofbiz.service.RunningService.getEndStamp(RunningService.java:63) 
> ~[ofbiz.jar:?]
> at org.apache.ofbiz.service.RunningService$getEndStamp$2.call(Unknown 
> Source) ~[?:?]
> at Services$_run_closure1.doCall(Services.groovy:43) ~[?:?]
> at sun.reflect.GeneratedMethodAccessor98.invoke(Unknown Source) ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.Closure.call(Closure.java:414) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.callClosureForMapEntry(DefaultGroovyMethods.java:5276)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2117)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at org.codehaus.groovy.runtime.dgm$164.invoke(Unknown Source) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:274)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:56)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at Services.run(Services.groovy:38) ~[?:?]
> at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:209)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:342) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:324) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:634)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:115)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1014)
>  [ofbi

[jira] [Commented] (OFBIZ-10342) Service Log screen is broken

2018-09-25 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627146#comment-16627146
 ] 

Jacques Le Roux commented on OFBIZ-10342:
-

Hi Rishi, All,

Right,  actually {{rs.setEndStamp()}} is needed where an exception is thrown, 
not only in in catch blocks. For all the rest, the last {{rs.setEndStamp()}} is 
sufficient.

I wondered if we should also add these somehow related lines, which are just 
after the last current {{rs.setEndStamp()}}, while adding {{rs.setEndStamp()}} 
elsewhere
{code}
long timeToRun = System.currentTimeMillis() - serviceStartTime;
long showServiceDurationThreshold = 
UtilProperties.getPropertyAsLong("service", "showServiceDurationThreshold", 0);
long showSlowServiceThreshold = 
UtilProperties.getPropertyAsLong("service", "showSlowServiceThreshold", 1000);
{code}

But there is already another existing {{rs.setEndStamp()}} in this catch block
{code}
} catch (Throwable t) {
if (Debug.timingOn()) {
UtilTimer.closeTimer(localName + " / " + modelService.name, 
"Sync service failed...", module);
}
String errMsg = "Service [" + modelService.name + "] threw an 
unexpected exception/error";
engine.sendCallbacks(modelService, context, t, 
GenericEngine.SYNC_MODE);
try {
TransactionUtil.rollback(beganTrans, errMsg, t);
} catch (GenericTransactionException te) {
Debug.logError(te, "Cannot rollback transaction", module);
}
rs.setEndStamp();
if (t instanceof ServiceAuthException) {
throw (ServiceAuthException) t;
} else if (t instanceof ServiceValidationException) {
throw (ServiceValidationException) t;
} else if (t instanceof GenericServiceException) {
throw (GenericServiceException) t;
} else {
throw new GenericServiceException("Service [" + 
modelService.name + "] Failed" + modelService.debugInfo() , t);
}
} finally {
{code}
with no set for timeToRun, showServiceDurationThreshold and 
showSlowServiceThreshold.

I did not digg further but I guess it's OK to do the same everywhere else it's 
needed (ie neglecting timeToRun, showServiceDurationThreshold and 
showSlowServiceThreshold).

Also I did not try to improve the code in this issue (could be done, 273 
lines... but not easy...).

Please check the attached patch in case I missed something, thanks.

> Service Log screen is broken
> 
>
> Key: OFBIZ-10342
> URL: https://issues.apache.org/jira/browse/OFBIZ-10342
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Reporter: Swapnil M Mane
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10342.patch, serviceLog.png
>
>
> Service Log screen is broken.
> Steps to regenerate
>  # Navigate to Logging menu under webtools
>  [https://demo-trunk.ofbiz.apache.org/webtools/control/LogView]
>  # Select Service Log menu
> *Console Logs*
> {code:java}
>  |T| [[[ServiceLog(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2018-04-16 16:23:03,482 |jsse-nio-8443-exec-8 |RequestHandler
> |I| Rendering View [ServiceLog].  Hidden sessionId by default.
> 2018-04-16 16:23:03,483 |jsse-nio-8443-exec-8 |ServiceDispatcher 
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] 
> milliseconds
> 2018-04-16 16:23:03,484 |jsse-nio-8443-exec-8 |ScriptUtil
> |W| Error running script at location 
> [component://webtools/groovyScripts/service/Services.groovy]: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at 
> org.apache.ofbiz.service.RunningService.getEndStamp(RunningService.java:63) 
> ~[ofbiz.jar:?]
> at org.apache.ofbiz.service.RunningService$getEndStamp$2.call(Unknown 
> Source) ~[?:?]
> at Services$_run_closure1.doCall(Services.groovy:43) ~[?:?]
> at sun.reflect.GeneratedMethodAccessor98.invoke(Unknown Source) ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
>  ~[groovy-all-2.4.13.jar:2.4

[jira] [Commented] (OFBIZ-10342) Service Log screen is broken

2018-09-22 Thread Rishi Solanki (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624624#comment-16624624
 ] 

Rishi Solanki commented on OFBIZ-10342:
---

As mentioned by [~jacques.le.roux] we should add rs.setEndStamp() when 
GenericTransactionException catch block as well. Also let the other places to 
set end stamp, no changes required.

> Service Log screen is broken
> 
>
> Key: OFBIZ-10342
> URL: https://issues.apache.org/jira/browse/OFBIZ-10342
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Reporter: Swapnil M Mane
>Priority: Major
> Attachments: serviceLog.png
>
>
> Service Log screen is broken.
> Steps to regenerate
>  # Navigate to Logging menu under webtools
>  [https://demo-trunk.ofbiz.apache.org/webtools/control/LogView]
>  # Select Service Log menu
> *Console Logs*
> {code:java}
>  |T| [[[ServiceLog(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2018-04-16 16:23:03,482 |jsse-nio-8443-exec-8 |RequestHandler
> |I| Rendering View [ServiceLog].  Hidden sessionId by default.
> 2018-04-16 16:23:03,483 |jsse-nio-8443-exec-8 |ServiceDispatcher 
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] 
> milliseconds
> 2018-04-16 16:23:03,484 |jsse-nio-8443-exec-8 |ScriptUtil
> |W| Error running script at location 
> [component://webtools/groovyScripts/service/Services.groovy]: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at 
> org.apache.ofbiz.service.RunningService.getEndStamp(RunningService.java:63) 
> ~[ofbiz.jar:?]
> at org.apache.ofbiz.service.RunningService$getEndStamp$2.call(Unknown 
> Source) ~[?:?]
> at Services$_run_closure1.doCall(Services.groovy:43) ~[?:?]
> at sun.reflect.GeneratedMethodAccessor98.invoke(Unknown Source) ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.Closure.call(Closure.java:414) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.callClosureForMapEntry(DefaultGroovyMethods.java:5276)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2117)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at org.codehaus.groovy.runtime.dgm$164.invoke(Unknown Source) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:274)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:56)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at Services.run(Services.groovy:38) ~[?:?]
> at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:209)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:342) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:324) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:634)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:115)
>  [ofbiz.jar:?]
> at 
> org.apache.o

[jira] [Commented] (OFBIZ-10342) Service Log screen is broken

2018-09-11 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611676#comment-16611676
 ] 

Jacques Le Roux commented on OFBIZ-10342:
-

Hi Swapnil, Nicolas,

This is not always reproductible. For instance just after restarting it's not, 
neither at the moment on trunk demo while it was yesterday. Could be that we 
need to use rs.setEndStamp() in ServiceDispatcher::runSync when exception are 
thrown, ie at the end of the method rather than just above exceptions handling. 
It's the only place where it's used.

> Service Log screen is broken
> 
>
> Key: OFBIZ-10342
> URL: https://issues.apache.org/jira/browse/OFBIZ-10342
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: serviceLog.png
>
>
> Service Log screen is broken.
> Steps to regenerate
>  # Navigate to Logging menu under webtools
>  [https://demo-trunk.ofbiz.apache.org/webtools/control/LogView]
>  # Select Service Log menu
> *Console Logs*
> {code:java}
>  |T| [[[ServiceLog(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2018-04-16 16:23:03,482 |jsse-nio-8443-exec-8 |RequestHandler
> |I| Rendering View [ServiceLog].  Hidden sessionId by default.
> 2018-04-16 16:23:03,483 |jsse-nio-8443-exec-8 |ServiceDispatcher 
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] 
> milliseconds
> 2018-04-16 16:23:03,484 |jsse-nio-8443-exec-8 |ScriptUtil
> |W| Error running script at location 
> [component://webtools/groovyScripts/service/Services.groovy]: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at 
> org.apache.ofbiz.service.RunningService.getEndStamp(RunningService.java:63) 
> ~[ofbiz.jar:?]
> at org.apache.ofbiz.service.RunningService$getEndStamp$2.call(Unknown 
> Source) ~[?:?]
> at Services$_run_closure1.doCall(Services.groovy:43) ~[?:?]
> at sun.reflect.GeneratedMethodAccessor98.invoke(Unknown Source) ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.Closure.call(Closure.java:414) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.callClosureForMapEntry(DefaultGroovyMethods.java:5276)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2117)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at org.codehaus.groovy.runtime.dgm$164.invoke(Unknown Source) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:274)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:56)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at Services.run(Services.groovy:38) ~[?:?]
> at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:209)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:342) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:324) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:634)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.rend

[jira] [Commented] (OFBIZ-10342) Service Log screen is broken

2018-09-11 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610942#comment-16610942
 ] 

Swapnil M Mane commented on OFBIZ-10342:


Hi [~soledad],

Thank you for your note. I appreciate your help, if you have any pointers 
around the issue, please share.
Also, if you are planning to work on it, please feel free to reassign the issue 
:-)

> Service Log screen is broken
> 
>
> Key: OFBIZ-10342
> URL: https://issues.apache.org/jira/browse/OFBIZ-10342
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: serviceLog.png
>
>
> Service Log screen is broken.
> Steps to regenerate
>  # Navigate to Logging menu under webtools
>  [https://demo-trunk.ofbiz.apache.org/webtools/control/LogView]
>  # Select Service Log menu
> *Console Logs*
> {code:java}
>  |T| [[[ServiceLog(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2018-04-16 16:23:03,482 |jsse-nio-8443-exec-8 |RequestHandler
> |I| Rendering View [ServiceLog].  Hidden sessionId by default.
> 2018-04-16 16:23:03,483 |jsse-nio-8443-exec-8 |ServiceDispatcher 
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] 
> milliseconds
> 2018-04-16 16:23:03,484 |jsse-nio-8443-exec-8 |ScriptUtil
> |W| Error running script at location 
> [component://webtools/groovyScripts/service/Services.groovy]: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at 
> org.apache.ofbiz.service.RunningService.getEndStamp(RunningService.java:63) 
> ~[ofbiz.jar:?]
> at org.apache.ofbiz.service.RunningService$getEndStamp$2.call(Unknown 
> Source) ~[?:?]
> at Services$_run_closure1.doCall(Services.groovy:43) ~[?:?]
> at sun.reflect.GeneratedMethodAccessor98.invoke(Unknown Source) ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.Closure.call(Closure.java:414) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.callClosureForMapEntry(DefaultGroovyMethods.java:5276)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2117)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at org.codehaus.groovy.runtime.dgm$164.invoke(Unknown Source) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:274)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:56)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at Services.run(Services.groovy:38) ~[?:?]
> at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:209)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:342) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:324) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:634)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHa

[jira] [Commented] (OFBIZ-10342) Service Log screen is broken

2018-09-11 Thread Nicolas Malin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610811#comment-16610811
 ] 

Nicolas Malin commented on OFBIZ-10342:
---

Hi [~swapnilmmane] do you need some help to resolve this issue ?

> Service Log screen is broken
> 
>
> Key: OFBIZ-10342
> URL: https://issues.apache.org/jira/browse/OFBIZ-10342
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: serviceLog.png
>
>
> Service Log screen is broken.
> Steps to regenerate
>  # Navigate to Logging menu under webtools
>  [https://demo-trunk.ofbiz.apache.org/webtools/control/LogView]
>  # Select Service Log menu
> *Console Logs*
> {code:java}
>  |T| [[[ServiceLog(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2018-04-16 16:23:03,482 |jsse-nio-8443-exec-8 |RequestHandler
> |I| Rendering View [ServiceLog].  Hidden sessionId by default.
> 2018-04-16 16:23:03,483 |jsse-nio-8443-exec-8 |ServiceDispatcher 
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] 
> milliseconds
> 2018-04-16 16:23:03,484 |jsse-nio-8443-exec-8 |ScriptUtil
> |W| Error running script at location 
> [component://webtools/groovyScripts/service/Services.groovy]: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at 
> org.apache.ofbiz.service.RunningService.getEndStamp(RunningService.java:63) 
> ~[ofbiz.jar:?]
> at org.apache.ofbiz.service.RunningService$getEndStamp$2.call(Unknown 
> Source) ~[?:?]
> at Services$_run_closure1.doCall(Services.groovy:43) ~[?:?]
> at sun.reflect.GeneratedMethodAccessor98.invoke(Unknown Source) ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.Closure.call(Closure.java:414) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.callClosureForMapEntry(DefaultGroovyMethods.java:5276)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2117)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at org.codehaus.groovy.runtime.dgm$164.invoke(Unknown Source) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:274)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:56)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at Services.run(Services.groovy:38) ~[?:?]
> at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:209)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:342) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:324) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:634)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroScreenViewHandler.render(MacroScreenViewHandler.java:115)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:1014)
>  [ofbiz.ja

[jira] [Commented] (OFBIZ-10342) Service Log screen is broken

2018-04-16 Thread Swapnil M Mane (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439286#comment-16439286
 ] 

Swapnil M Mane commented on OFBIZ-10342:


After some exploration, I found this issue is generated in the special 
situation.

ofbiz/framework/service/src/main/java/org/apache/ofbiz/service/*RunningService.java*
{code:java}
public Timestamp getEndStamp() {
return (Timestamp) this.endStamp.clone();
}
{code}
When the endStamp is null, we face the NullPointerException.

> Service Log screen is broken
> 
>
> Key: OFBIZ-10342
> URL: https://issues.apache.org/jira/browse/OFBIZ-10342
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: serviceLog.png
>
>
> Service Log screen is broken.
> Steps to regenerate
>  # Navigate to Logging menu under webtools
>  [https://demo-trunk.ofbiz.apache.org/webtools/control/LogView]
>  # Select Service Log menu
> *Console Logs*
> {code:java}
>  |T| [[[ServiceLog(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2018-04-16 16:23:03,482 |jsse-nio-8443-exec-8 |RequestHandler
> |I| Rendering View [ServiceLog].  Hidden sessionId by default.
> 2018-04-16 16:23:03,483 |jsse-nio-8443-exec-8 |ServiceDispatcher 
> |T| Sync service [webtools/getUserPreferenceGroup] finished in [1] 
> milliseconds
> 2018-04-16 16:23:03,484 |jsse-nio-8443-exec-8 |ScriptUtil
> |W| Error running script at location 
> [component://webtools/groovyScripts/service/Services.groovy]: 
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at 
> org.apache.ofbiz.service.RunningService.getEndStamp(RunningService.java:63) 
> ~[ofbiz.jar:?]
> at org.apache.ofbiz.service.RunningService$getEndStamp$2.call(Unknown 
> Source) ~[?:?]
> at Services$_run_closure1.doCall(Services.groovy:43) ~[?:?]
> at sun.reflect.GeneratedMethodAccessor98.invoke(Unknown Source) ~[?:?]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_66]
> at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:93) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:325) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:294)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1022) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at groovy.lang.Closure.call(Closure.java:414) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.callClosureForMapEntry(DefaultGroovyMethods.java:5276)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.DefaultGroovyMethods.each(DefaultGroovyMethods.java:2117)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at org.codehaus.groovy.runtime.dgm$164.invoke(Unknown Source) 
> ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:274)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:56)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  ~[groovy-all-2.4.13.jar:2.4.13]
> at Services.run(Services.groovy:38) ~[?:?]
> at 
> org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(GroovyUtil.java:209)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:342) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUtil.java:324) 
> [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction$Script.runAction(AbstractModelAction.java:634)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:140)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:102