[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539901#comment-16539901 ] Jacques Le Roux commented on OFBIZ-10464: - OK thanks > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539797#comment-16539797 ] Dennis Balkir commented on OFBIZ-10464: --- I already created a Jira for AR: OFBIZ-10469 > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539760#comment-16539760 ] Jacques Le Roux commented on OFBIZ-10464: - BTW did you create a Jira for the same for AR? > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539728#comment-16539728 ] Jacques Le Roux commented on OFBIZ-10464: - Hi Dennis, Long ago, after creating the Widgets Forms, we decided that we should use FTL with parsimony in the backend. Because it's easier to set rules in Widgets Forms than in FTL where you can digress more easily. And if developers have more possibilites with the code you will see more difference in it ;) But I agree it's unfortunately our legacy (FTL was largely used before Widgets Forms) and it's now hard to get back when it's so easy to tune existing code. And though I'm reluctant to do so, because of lack of time, I think I will do that for OFBIZ-10454 :/ > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539623#comment-16539623 ] Dennis Balkir commented on OFBIZ-10464: --- Hi Jacques, there is actually no difference seen, the only difference is in the code. Before the change, the screenlets didn't just "sit" in the surrounding page containers, but were nested inside a table. Since this wasn't something I found anywhere else in the code, I removed it to make the whole HTML more equal and more friendly to stylize. The main page from AR had the same issue > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539229#comment-16539229 ] Jacques Le Roux commented on OFBIZ-10464: - Pierre, As we like to say, feel free to improve the portal thing :) > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539227#comment-16539227 ] Jacques Le Roux commented on OFBIZ-10464: - Dennis, I don't see much difference, but I used only the default theme. Maybe it's more relevant with another? Also what about AR? Same issue no? > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539222#comment-16539222 ] Jacques Le Roux commented on OFBIZ-10464: - Hi Dennis, You wrote: bq. Most of the times, the main screens just include .ftl files Which is a pity. For instance you improved catalog/control/main with r1829700 for OFBIZ-10221. But then the fields are no longer aligned. So I have created OFBIZ-10454. We should only use form widgets in the backend to easily keep things concistent. Unfortunately we have a ton of legacy to change. Anyway, thanks for your good work :) > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[
https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538295#comment-16538295
]
Dennis Balkir commented on OFBIZ-10464:
---
Hi [~pfm.smits],
that's right, but I made the changes while looking at the other main pages from
other applications, from which none seem to use this portal page logic.
Most of the times, the main screens just include .ftl files, but for example
humanres' main page includes the screen to show just like I did:
{code:xml}
{code}
This was the reason I changed the pages like I did.
> Improve Accounting -AP
> --
>
> Key: OFBIZ-10464
> URL: https://issues.apache.org/jira/browse/OFBIZ-10464
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: accounting-ap_main-page.patch
>
>
> I found some structural differences while looking on accounting-ap -> main.
> While all the other screenlets on such pages are nested inside the
> surrounding div-containers, these ones are actually inside a table, which
> then is inside the normally surrounding divs.
>
> This makes styling for new themes difficult and should be changed, since it
> is an exception in the normally used structure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538221#comment-16538221 ] Pierre Smits commented on OFBIZ-10464: -- Hi [~Dennis Balkir], It seems that the problem lies in how portal pages are handled by the rendering engine. Would it not be better to fix that, instead of removing that functionality and replacing it with hard-coded screen definitions? > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10464) Improve Accounting -AP
[ https://issues.apache.org/jira/browse/OFBIZ-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16534636#comment-16534636 ] Dennis Balkir commented on OFBIZ-10464: --- The provided patch will fix this difference in structure. I checked the look in all current and older available themes, and it looks completely the same. For the structure being now the same as the other pages like that, it will make future themes and designs easier. > Improve Accounting -AP > -- > > Key: OFBIZ-10464 > URL: https://issues.apache.org/jira/browse/OFBIZ-10464 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Dennis Balkir >Priority: Minor > Attachments: accounting-ap_main-page.patch > > > I found some structural differences while looking on accounting-ap -> main. > While all the other screenlets on such pages are nested inside the > surrounding div-containers, these ones are actually inside a table, which > then is inside the normally surrounding divs. > > This makes styling for new themes difficult and should be changed, since it > is an exception in the normally used structure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
