[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724898#comment-16724898 ] Aditya Sharma commented on OFBIZ-10645: --- Thanks [~mthl] :) I will test with your changes and

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724886#comment-16724886 ] Mathieu Lirzin commented on OFBIZ-10645: Hello [~aditya.sharma], I have done some (untested)

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724878#comment-16724878 ] Aditya Sharma commented on OFBIZ-10645: --- I will commit in a day if no conflicts. > Empty entity

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722984#comment-16722984 ] Aditya Sharma commented on OFBIZ-10645: --- Thanks [~jacques.le.roux] for the review :)  > Empty

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722710#comment-16722710 ] Aditya Sharma commented on OFBIZ-10645: --- Hi [~jacques.le.roux] [~mthl] , I have updated the patch.

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684046#comment-16684046 ] Jacques Le Roux commented on OFBIZ-10645: - bq. So we can proceed with only checking entity-name

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683798#comment-16683798 ] Aditya Sharma commented on OFBIZ-10645: --- So we can proceed with only checking entity-name then, as

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683738#comment-16683738 ] Jacques Le Roux commented on OFBIZ-10645: - Hi Aditya, bq. I prefer the same but still couldn't

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683597#comment-16683597 ] Aditya Sharma commented on OFBIZ-10645: --- Thanks  [~mthl] and [~jacques.le.roux] :). Makes sense. I

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683472#comment-16683472 ] Jacques Le Roux commented on OFBIZ-10645: - Hi Aditya, I'm all for returning Optionals instead

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683456#comment-16683456 ] Mathieu Lirzin commented on OFBIZ-10645: What I mean is that you can use

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683234#comment-16683234 ] Aditya Sharma commented on OFBIZ-10645: --- Thanks [~mthl] for reviewing the patch. Suggestion by

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682902#comment-16682902 ] Mathieu Lirzin commented on OFBIZ-10645: Hello [~aditya.sharma], I would suggest modifying

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682367#comment-16682367 ] Aditya Sharma commented on OFBIZ-10645: --- I am adding 2 solution patches: Added check in