[jira] [Commented] (OFBIZ-10759) Replace document.write() occurrences with some legitimate code
[ https://issues.apache.org/jira/browse/OFBIZ-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805782#comment-16805782 ] Aditya Sharma commented on OFBIZ-10759: --- I think the plugin is no longer visible and the code is pure JS code so leaving the instances as it is. Closing as no more instances > Replace document.write() occurrences with some legitimate code > -- > > Key: OFBIZ-10759 > URL: https://issues.apache.org/jira/browse/OFBIZ-10759 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > > Using document.write() is considered a bad practice. > > Refer: > [https://blog.dareboost.com/en/2016/09/avoid-using-document-write-scripts-injection/] > [https://stackoverflow.com/questions/802854/why-is-document-write-considered-a-bad-practice] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10759) Replace document.write() occurrences with some legitimate code
[ https://issues.apache.org/jira/browse/OFBIZ-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805715#comment-16805715 ] Aditya Sharma commented on OFBIZ-10759: --- Hi [~jacques.le.roux] , I can still find some instances in pricat plugins. I will get it done asap. > Replace document.write() occurrences with some legitimate code > -- > > Key: OFBIZ-10759 > URL: https://issues.apache.org/jira/browse/OFBIZ-10759 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > > Using document.write() is considered a bad practice. > > Refer: > [https://blog.dareboost.com/en/2016/09/avoid-using-document-write-scripts-injection/] > [https://stackoverflow.com/questions/802854/why-is-document-write-considered-a-bad-practice] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10759) Replace document.write() occurrences with some legitimate code
[ https://issues.apache.org/jira/browse/OFBIZ-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800086#comment-16800086 ] Jacques Le Roux commented on OFBIZ-10759: - Hi Aditya, I'm not sure when this derailled (it's not present in R13.07) but it's no longer a popup since at least R14 (I tried R15 and R16 also). Anyway I don't think much people care about that nowaydays, so it's OK with me. I mean you can close if you want. > Replace document.write() occurrences with some legitimate code > -- > > Key: OFBIZ-10759 > URL: https://issues.apache.org/jira/browse/OFBIZ-10759 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > > Using document.write() is considered a bad practice. > > Refer: > [https://blog.dareboost.com/en/2016/09/avoid-using-document-write-scripts-injection/] > [https://stackoverflow.com/questions/802854/why-is-document-write-considered-a-bad-practice] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10759) Replace document.write() occurrences with some legitimate code
[ https://issues.apache.org/jira/browse/OFBIZ-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788559#comment-16788559 ] Aditya Sharma commented on OFBIZ-10759: --- Removed js code and added Js files in LookupDecorator. Added Js library files as there were some errors in console logs Done for trunk at r1855083 and release18.12 at r1855087 Steps to verify: # Login to example component. # Navigate to [Form Widget Examples|https://localhost:8443/example/control/FormWidgetExamples] # Try using Popup lookup field (old way, maybe be useful in some cases, notably if javascript is not enabled) It should work as expected. Removed document.write.lastFocusedName as code works without it Done for trunk plugins at r1855084 and release18.12 at r1855092 > Replace document.write() occurrences with some legitimate code > -- > > Key: OFBIZ-10759 > URL: https://issues.apache.org/jira/browse/OFBIZ-10759 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Minor > > Using document.write() is considered a bad practice. > > Refer: > [https://blog.dareboost.com/en/2016/09/avoid-using-document-write-scripts-injection/] > [https://stackoverflow.com/questions/802854/why-is-document-write-considered-a-bad-practice] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
