[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284871#comment-17284871 ] ASF subversion and git services commented on OFBIZ-10791: - Commit 315bdea44bf1a96d5141c9344d5d30ec1439f9b5 in ofbiz-framework's branch refs/heads/release17.12 from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=315bdea ] Fixed: Unable to add product (of ASSET_USAGE type) in order (OFBIZ-10791) The patch was manually applied due to conflicts/renamed ressources. Thanks Priya Sharma for providing the patch. > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Sebastian Berg >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from > 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot > from 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284843#comment-17284843 ] ASF subversion and git services commented on OFBIZ-10791: - Commit f9fc00ad3b556e14c812ffa7033fe5be65884519 in ofbiz-framework's branch refs/heads/release18.12 from Sebastian Berg [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f9fc00a ] Fixed: Unable to add product (of ASSET_USAGE type) in order OFBIZ-10791 Thanks Priya for providing the patch > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Sebastian Berg >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Fix For: Upcoming Branch > > Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from > 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot > from 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284839#comment-17284839 ] ASF subversion and git services commented on OFBIZ-10791: - Commit 18b83b91c200dbdefc0d8dfba45412d492cdc8bb in ofbiz-framework's branch refs/heads/trunk from Sebastian Berg [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=18b83b9 ] Fixed: Unable to add product (of ASSET_USAGE type) in order OFBIZ-10791 Thanks Priya for providing the patch > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Sebastian Berg >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from > 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot > from 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283685#comment-17283685 ] Sebastian Berg commented on OFBIZ-10791: [~mbrohl] I had no issues applying the patch. I created a PR for convenience. > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Sebastian Berg >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from > 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot > from 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283224#comment-17283224 ] Michael Brohl commented on OFBIZ-10791: --- [~sberg] can you please check the patch and try to apply it on lastest trunk / provide a pr? Thanks! > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Sebastian Berg >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from > 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot > from 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167235#comment-17167235 ] Priya Sharma commented on OFBIZ-10791: -- Thanks for the review Pawan. Yes, that was a good suggestion, updated the patch. > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Priya Sharma >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from > 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot > from 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[
https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167180#comment-17167180
]
Pawan Verma commented on OFBIZ-10791:
-
Hi [~priya.sharma.9362]
The solution makes sense to me. Just one suggestion shouldn't we use a
condition like:
if (quantity.compareTo(BigDecimal.ZERO) > 0) {
Does this make sense to you?
> Unable to add product (of ASSET_USAGE type) in order
>
>
> Key: OFBIZ-10791
> URL: https://issues.apache.org/jira/browse/OFBIZ-10791
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12, Trunk
>Reporter: Praveen Sharma
>Assignee: Priya Sharma
>Priority: Major
> Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL,
> SALES_RENTAL
> Attachments: OFBIZ-10791.patch, Screenshot from 2019-03-09
> 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot from
> 2019-03-09 11-06-36.png, asset-addtocart.png
>
>
> Steps to regenerate:
> # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
> # Click on order entry
> # Set customer and click on continue
> # Click continue on Enter Order Currency, Agreements, and Ship Dates page
> (Please refer attachment: 2-Continue)
> # Try to add product from Quick Lookup.
> Actual: Unable to add product for order.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128202#comment-17128202 ] Priya Sharma commented on OFBIZ-10791: -- Hello Pierre and All, As per my exploration, this issue was specific to the bulk add to cart feature. So I thought of handling it the same way as it is handled for a single item add to cart. In the latter, we are navigated to the product detail page, where you can fill in the reservation start and end date. Thus I have added a condition to render the detail page if the item added is of asset type. But you are still not able to add the details because the submission form does not contain these parameters and it keeps on asking for the required details. Thus updated the markup to enclose the fields in the respective form. !asset-addtocart.png! Please have a look at the approach and suggest if there is a better way to do so. > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Priya Sharma >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Attachments: OFBIZ-10791.patch, Screenshot from 2019-03-09 > 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot from > 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789149#comment-16789149 ] Priya Sharma commented on OFBIZ-10791: -- Agreed Pierre. Let's take up the first case and start the analysis and testing of the above-mentioned scenarios I will also prepare a document if needed. Thanks for the guidance, will definitely need your insights going forward. > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Praveen Sharma >Assignee: Priya Sharma >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Attachments: Screenshot from 2019-03-09 11-05-31.png, Screenshot from > 2019-03-09 11-06-20.png, Screenshot from 2019-03-09 11-06-36.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
